Merge pull request #727 from prometheus/beorn7/fingerprint

Use an RW lock to checkpoint fingerprint mappings.
11 years ago · c86f5fdfd1
parent acd2df7507 dbcb3d9333
commit c86f5fdfd1
1 changed files with 2 additions and 2 deletions
--- a/storage/local/mapper.go
+++ b/storage/local/mapper.go
@ -141,10 +141,10 @@ func (m *fpMapper) maybeAddMapping(
 		// A new mapping has to be created.
 		mappedFP = m.nextMappedFP()
 		mappedFPs[ms] = mappedFP
-		m.mtx.RLock()
+		m.mtx.Lock()
 		// Checkpoint mappings after each change.
 		err := m.p.checkpointFPMappings(m.mappings)
-		m.mtx.RUnlock()
+		m.mtx.Unlock()
 		log.Infof(
 			"Collision detected for fingerprint %v, metric %v, mapping to new fingerprint %v.",
 			fp, collidingMetric, mappedFP,