37 Commits (bwplotka-patch-1)

Author	SHA1	Message	Date
Ben Ye	872e2db2a9	Implement json encoder/decoder for regexp (#15383) ... * implement json encoder/decoder for regexp --------- Signed-off-by: Ben Ye <benye@amazon.com>	1 year ago
Matthieu MOREL	af1a19fc78	enable errorf rule from perfsprint linter ... Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>	1 year ago
Mario Fernandez	5814920601	Fix: optimize .* regexp performance ... Shortcut for `.*` matches newlines as well. Add preamble change ^(?s: Add test dotAll flag por al regex Add and fix regex tests Signed-off-by: Mario Fernandez <mariofer@redhat.com>	1 year ago
Marco Pracucci	d4f098ae80	Fix relabel.Regexp zero value marshalling (#14517) ... Signed-off-by: Marco Pracucci <marco@pracucci.com>	1 year ago
Oleksandr Redko	f10c3454e9	Enable perfsprint linter and fix up code ... Signed-off-by: Oleksandr Redko <oleksandr.red+github@gmail.com>	2 years ago
Arve Knudsen	d699dc3c77	Fix language in docs and comments (#14041) ... Fix language in docs and comments --------- Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com> Co-authored-by: Björn Rabenstein <github@rabenste.in>	2 years ago
Liam Howe	35d897ced4	Add test case for default regex explicitly provided ... Signed-off-by: Liam Howe <liam.howe@maersk.com>	2 years ago
Liam Howe	5d97f17ff1	Replace MarshalYAML() with IsZero() method for Regexp ... Signed-off-by: Liam Howe <liam.howe@maersk.com>	2 years ago
Liam Howe	835dfa7eb6	Implement MarshalYAML for relabel.Config so that we do not generate a regex field if it was not provided in the first place ... Signed-off-by: Liam Howe <liam.howe@maersk.com>	2 years ago
roger.wang	7e8f03663a	Code optimization: The relabel operation is used very frequently, and strconv.FormatInt() with better performance should be used. ... Signed-off-by: roger.wang <roger.wang@cloudwise.com>	2 years ago
Bryan Boreham	17f48f2b3b	Tests: use replacement DeepEquals in more places ... Signed-off-by: Bryan Boreham <bjboreham@gmail.com>	2 years ago
Xiaochao Dong (@damnever)	b3b5c0022e	Simplify the logic as per the comments ... Signed-off-by: Xiaochao Dong (@damnever) <the.xcdong@gmail.com>	2 years ago
Xiaochao Dong (@damnever)	1601b2a79e	check new line in target ... Signed-off-by: Xiaochao Dong (@damnever) <the.xcdong@gmail.com>	2 years ago
Xiaochao Dong (@damnever)	2d0d333371	Fix lint issue ... Signed-off-by: Xiaochao Dong (@damnever) <the.xcdong@gmail.com>	2 years ago
Xiaochao Dong (@damnever)	20e3c295ae	Optimize constant label pair adding with relabel.Replace ... Signed-off-by: Xiaochao Dong (@damnever) <the.xcdong@gmail.com>	2 years ago
Bryan Boreham	0289dd6157	relabel: blank replacement deletes label post-regexp ... If `cfg.TargetLabel` is a template like `$1`, it won't match any labels, so no point calling `lb.Del` with it. Similarly if `target` is not a valid label name, it won't match any labels, so don't call with that either. The intention seems to have been that a blank _value_ would delete the target, so change that code to use `target` instead of `cfg.TargetLabel`. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>	2 years ago
Bryan Boreham	000182e4b8	relabel: check validity of all test cases ... Thought this would be a nice check on the `Validate()` function, but some of the test cases needed tweaking to pass. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>	2 years ago
Bryan Boreham	2d4c367d87	relabel: stricter check that target labels are valid ... For `Lowercase`, `KeepEqual`, etc., we do not expand a regexp, so the target label name must not contain anything like `${1}`. Also for the common case that the `Replace` target does not require any template expansion, check that the entire string passes label name validity rules. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>	2 years ago
Bryan Boreham	9ab7e3b3de	relabel: refactor: extract config.Validate method ... And add a test for it, which fails because validation is not strong enough. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>	2 years ago
Bryan Boreham	e278195e39	Cherry-pick bugfix #12322 and create v2.43.1 (#12324) ... * labels: respect Set after Del in Builder (#12322) The implementations are not symmetric between `Set()` and `Del()`, so we must be careful. Add tests for this, both in labels and in relabel where the issue was reported. Also make the slice implementation consistent re `slices.Contains`. * Create v2.43.1 with bugfix Signed-off-by: Bryan Boreham <bjboreham@gmail.com> Co-authored-by: Julius Volz <julius.volz@gmail.com>	3 years ago
Bryan Boreham	7a48a266b6	labels: respect Set after Del in Builder (#12322) ... * labels: respect Set after Del in Builder The implementations are not symmetric between `Set()` and `Del()`, so we must be careful. Add tests for this, both in labels and in relabel where the issue was reported. Also make the slice implementation consistent re `slices.Contains`. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>	3 years ago
Bryan Boreham	b987afa7ef	labels: simplify call to get Labels from Builder ... It took a `Labels` where the memory could be re-used, but in practice this hardly ever benefitted. Especially after converting `relabel.Process` to `relabel.ProcessBuilder`. Comparing the parameter to `nil` was a bug; `EmptyLabels` is not `nil` so the slice was reallocated multiple times by `append`. Lastly `Builder.Labels()` now estimates that the final size will depend on labels added and deleted. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>	3 years ago
Bryan Boreham	11d019ed5a	relabel: keep intermediate results in labels.Builder ... Save work converting between Builder and Labels. Also expose ProcessBuilder, so callers can supply a Builder. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>	3 years ago
Renning Bruns	5ec1b4baaf	make hashmod a lot easier to read and a little faster (#11551) ... Previous code was effectively doing BigEndian.Uint64, so call that and save time. An md5.Sum result is always 16 bytes. The first 8 are not used in the result, just as before. Signed-off-by: Renning Bruns <ren@renmail.net>	3 years ago
Bryan Boreham	fe9fe0e1e5	Update package model/relabel tests for new labels.Labels type ... Signed-off-by: Bryan Boreham <bjboreham@gmail.com>	3 years ago
Bryan Boreham	8ad7b64c0f	Update package model/relabel for new labels.Labels type ... Signed-off-by: Bryan Boreham <bjboreham@gmail.com>	3 years ago
Julien Pivotto	005ede70de	relabel: add keepequal/dropequal relabel action ... Signed-off-by: Julien Pivotto <roidelapluie@o11y.eu>	3 years ago
Douglas Camata	28a66e183d	Update relabel.Process comment ... Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com>	3 years ago
Bryan Boreham	8b863c42dd	Optimise relabeling by re-using memory (#11147) ... * model/relabel: Add benchmark Signed-off-by: Bryan Boreham <bjboreham@gmail.com> * model/relabel: re-use Builder across relabels Saves memory allocations. Signed-off-by: Bryan Boreham <bjboreham@gmail.com> * labels.Builder: allow re-use of result slice This reduces memory allocations where the caller has a suitable slice available. Signed-off-by: Bryan Boreham <bjboreham@gmail.com> * model/relabel: re-use source values slice To reduce memory allocations. Signed-off-by: Bryan Boreham <bjboreham@gmail.com> * Unwind one change causing test failures Restore original behaviour in PopulateLabels, where we must not overwrite the input set. Signed-off-by: Bryan Boreham <bjboreham@gmail.com> * relabel: simplify values optimisation Use a stack-based array for up to 16 source labels, which will be the vast majority of cases. Signed-off-by: Bryan Boreham <bjboreham@gmail.com> * lint Signed-off-by: Bryan Boreham <bjboreham@gmail.com> Signed-off-by: Bryan Boreham <bjboreham@gmail.com>	3 years ago
Matthieu MOREL	c2b4de3611	refactor (package model): move from github.com/pkg/errors to 'errors' and 'fmt' packages (#10747) ... Signed-off-by: Matthieu MOREL <mmorel-35@users.noreply.github.com> Co-Authored-By: Julien Pivotto <roidelapluie@gmail.com> Co-authored-by: Julien Pivotto <roidelapluie@gmail.com>	4 years ago
Paschalis Tsilias	4f3791024a	Drop extra string held in relabel.Regexp struct (#10846) ... * Drop extra string held in relabel.Regexp struct Signed-off-by: Paschalis Tsilias <paschalist0@gmail.com> * Use slice operations instead of TrimPrefix/TrimSuffix; Override String() method Signed-off-by: Paschalis Tsilias <paschalist0@gmail.com>	4 years ago
Julien Pivotto	71dbb4d091	Add lowercase and uppercase relabel action (#10641) ... Signed-off-by: Julien Pivotto <roidelapluie@o11y.eu>	4 years ago
Julien Pivotto	9a2e93228e	Switch to grafana/regexp everywhere (#10268) ... Let's have a consistent library for regexp. Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu>	4 years ago
beorn7	c954cd9d1d	Move packages out of deprecated pkg directory ... This creates a new `model` directory and moves all data-model related packages over there: exemplar labels relabel rulefmt textparse timestamp value All the others are more or less utilities and have been moved to `util`: gate logging modetimevfs pool runtime Signed-off-by: beorn7 <beorn@grafana.com>	4 years ago