prometheus

Commit Graph

Author	SHA1	Message	Date
avoidaway	fe4e817007	chore: fix some function names in comment Signed-off-by: avoidaway <cmoman@126.com>	1 year ago
Owen Williams	8d4bcd2c77	promql: Fix various UTF-8 bugs related to quoting Fixes UTF-8 aggregator label list items getting mutated with quote marks when String-ified. Fixes quoted metric names not supported in metric declarations. Fixes UTF-8 label names not being quoted when String-ified. Fixes https://github.com/prometheus/prometheus/issues/15470 Fixes https://github.com/prometheus/prometheus/issues/15528 Signed-off-by: Owen Williams <owen.williams@grafana.com> Co-authored-by: Bryan Boreham <bjboreham@gmail.com>	1 year ago
Arve Knudsen	a574335d6b	OTLP receiver: Don't call NormalizeLabel in NoUTF8EscapingWithSuffixes mode Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>	1 year ago
George Krajcsovits	1b2cf7edcf	Update storage/remote/otlptranslator/prometheusremotewrite/metrics_to_prw_test.go Co-authored-by: Arve Knudsen <arve.knudsen@gmail.com> Signed-off-by: George Krajcsovits <krajorama@users.noreply.github.com>	1 year ago
György Krajcsovits	174f828d70	Rename to keep_identifying_resource_attributes Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>	1 year ago
György Krajcsovits	ffabc04829	Make the behavior configurable Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>	1 year ago
Bryan Boreham	fd4797d756	[PERF] RW: Remove interning hook It does nothing for standard Prometheus builds with -tags stringlabels, but the check to see if labels are being replaced has a cost. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>	1 year ago
György Krajcsovits	a53b48a912	OTLP translate: keep identifying attributes in target_info Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>	1 year ago
Arve Knudsen	89bbb885e5	Upgrade to golangci-lint v1.62.0 (#15424 ) Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>	1 year ago
Arve Knudsen	9c02c26418	OTLP receiver: Convert also metric metadata (#15416 ) Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>	1 year ago
Đurica Yuri Nikolić	101b1c307f	[ENHANCEMEN] Remote-Write: optionally use a DNS resolver that picks a random IP (#15329 ) When a remote-write is executed towards a host name that is resolved to multiple IP addresses, this PR introduces a possibility to force creation of new connections used for the remote-write request to a randomly chosen IP address from the ones corresponding to the host name. The default behavior remains unchanged, i.s., the IP address used for the connection creation remains the one chosen by Go. This is an experimental feature, it is disabled by default. Signed-off-by: Yuri Nikolic <durica.nikolic@grafana.com>	1 year ago
Bryan Boreham	0ef0b75a4f	[TESTS] Remote-Write: Fix BenchmarkStartup It was crashing due to uninitialized metrics, and not terminating due to incorrectly reading segment names. We need to export `SetMetrics` to avoid the first problem. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>	1 year ago
Arthur Silva Sens	55e34c8c5f	Allow UTF-8 characters in metric and label names as opt-in feature (#15258 ) * Allow UTF-8 characters in metric and label names as opt-in feature --------- Signed-off-by: Arthur Silva Sens <arthursens2005@gmail.com>	1 year ago
SuperQ	bc1bc5c118	Update sigv4 library Migrate use of prometheus/common/sigv4 to prometheus/sigv4. Related to: https://github.com/prometheus/common/issues/709 Signed-off-by: SuperQ <superq@gmail.com>	1 year ago
Arthur Silva Sens	03995775a7	Allow UTF-8 characters in metric and label names as opt-in feature (#15258 ) * Allow UTF-8 characters in metric and label names as opt-in feature --------- Signed-off-by: Arthur Silva Sens <arthursens2005@gmail.com>	1 year ago
Matthieu MOREL	af1a19fc78	enable errorf rule from perfsprint linter Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>	1 year ago
Arve Knudsen	7c4f877881	otlptranslator: Harmonize non-UTF8 sanitization w/ naming rules. (#15314 ) * otlptranslator: Harmonize non-UTF8 sanitization w/ naming rules. Harmonize non-UTF8 sanitization w/ Prometheus naming rules. --------- Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>	1 year ago
Arthur Silva Sens	1a22b1d846	bugfix: Fix otlp translator switching colons to undescores (#15251 ) Signed-off-by: Arthur Silva Sens <arthursens2005@gmail.com>	1 year ago
Arthur Silva Sens	034d2b24bc	Fix typos in tests (#15312 ) Signed-off-by: Arthur Silva Sens <arthursens2005@gmail.com>	1 year ago
Arthur Silva Sens	ea06f1a1d1	bugfix: Fix otlp translation of foreign characters Signed-off-by: Arthur Silva Sens <arthursens2005@gmail.com>	1 year ago
Arthur Silva Sens	8588289c24	otlp translator: Add test showing bugs Signed-off-by: Arthur Silva Sens <arthursens2005@gmail.com>	1 year ago
Juraj Michalek	76ff12b32a	chore: only create span events Signed-off-by: Juraj Michalek <juraj.michalek132@gmail.com>	1 year ago
Juraj Michalek	7ecdb55b02	chore: use otelhttptrace instead Signed-off-by: Juraj Michalek <juraj.michalek132@gmail.com>	1 year ago
Juraj Michalek	3c1ffbb2fd	chore: added idleTimeMs and fixed linting issues Signed-off-by: Juraj Michalek <juraj.michalek132@gmail.com>	1 year ago
Juraj Michalek	2e7c739d44	chore: add tcp events to remote store span Signed-off-by: Juraj Michalek <juraj.michalek132@gmail.com>	1 year ago
Pedro Tanaka	bab587b9dc	Agent: allow for ingestion of CT samples (#15124 ) * Remove unused option from HeadOptions Signed-off-by: Pedro Tanaka <pedro.tanaka@shopify.com> * Improve docs for appendable() method in head appender Signed-off-by: Pedro Tanaka <pedro.tanaka@shopify.com> * Ingest CT (float) samples in Agent DB Signed-off-by: Pedro Tanaka <pedro.tanaka@shopify.com> * allow for ingestion of CT native histogram Signed-off-by: Pedro Tanaka <pedro.tanaka@shopify.com> * adding some verification for ct ts Signed-off-by: Pedro Tanaka <pedro.tanaka@shopify.com> * Validating CT histogram before append and add newly created series to pending series Signed-off-by: Pedro Tanaka <pedro.tanaka@shopify.com> * checking the wal for written samples Signed-off-by: Pedro Tanaka <pedro.tanaka@shopify.com> * Checking for samples in test Signed-off-by: Pedro Tanaka <pedro.tanaka@shopify.com> * adding case for validations Signed-off-by: Pedro Tanaka <pedro.tanaka@shopify.com> * fixing comparison when dedupelabels is enabled Signed-off-by: Pedro Tanaka <pedro.tanaka@shopify.com> * unite tests, use table testing Signed-off-by: Pedro Tanaka <pedro.tanaka@shopify.com> * Implement CT related methods in timestampTracker for write storage Signed-off-by: Pedro Tanaka <pedro.tanaka@shopify.com> * adding error case to test Signed-off-by: Pedro Tanaka <pedro.tanaka@shopify.com> * removing unused fields Signed-off-by: Pedro Tanaka <pedro.tanaka@shopify.com> * Updating lastTs for series when adding CT to invalidate duplicates Signed-off-by: Pedro Tanaka <pedro.tanaka@shopify.com> * making sure that updating the lastTS wont cause OOO later on in Commit(); Signed-off-by: Pedro Tanaka <pedro.tanaka@shopify.com> --------- Signed-off-by: Pedro Tanaka <pedro.tanaka@shopify.com>	1 year ago
Charlie Le	d87f7440ca	support int exemplar value type When the exemplar type is an int, it incorrectly gets converted to a 0 when DoubleValue() is called on the exemplar. This adds a check to ensure that the value is converted properly based on the type. Signed-off-by: Charlie Le <charlie_le@apple.com>	1 year ago
Vanshika	cccbe72514	TSDB: Fix some edge cases when OOO is enabled (#14710 ) Fix some edge cases when OOO is enabled Signed-off-by: Vanshikav123 <vanshikav928@gmail.com> Signed-off-by: Vanshika <102902652+Vanshikav123@users.noreply.github.com> Signed-off-by: Jesus Vazquez <jesusvzpg@gmail.com> Co-authored-by: Jesus Vazquez <jesusvzpg@gmail.com>	1 year ago
TJ Hoplock	6ebfbd2d54	chore!: adopt log/slog, remove go-kit/log For: #14355 This commit updates Prometheus to adopt stdlib's log/slog package in favor of go-kit/log. As part of converting to use slog, several other related changes are required to get prometheus working, including: - removed unused logging util func `RateLimit()` - forward ported the util/logging/Deduper logging by implementing a small custom slog.Handler that does the deduping before chaining log calls to the underlying real slog.Logger - move some of the json file logging functionality to use prom/common package functionality - refactored some of the new json file logging for scraping - changes to promql.QueryLogger interface to swap out logging methods for relevant slog sugar wrappers - updated lots of tests that used/replicated custom logging functionality, attempting to keep the logical goal of the tests consistent after the transition - added a healthy amount of `if logger == nil { $makeLogger }` type conditional checks amongst various functions where none were provided -- old code that used the go-kit/log.Logger interface had several places where there were nil references when trying to use functions like `With()` to add keyvals on the new *slog.Logger type Signed-off-by: TJ Hoplock <t.hoplock@gmail.com>	1 year ago
Matthieu MOREL	ab64966e9d	fix: use "ErrorContains" or "EqualError" instead of "Contains(t, err.Error()" and "Equal(t, err.Error()" (#15094 ) * fix: use "ErrorContains" or "EqualError" instead of "Contains(t, err.Error()" and "Equal(t, err.Error()" --------- Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com> Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com> Co-authored-by: Arve Knudsen <arve.knudsen@gmail.com>	1 year ago
Ayoub Mrini	105ab2e95a	fix(test): adjust defer invocations (#14996 ) Signed-off-by: machine424 <ayoubmrini424@gmail.com>	1 year ago
Arthur Silva Sens	6bd9b1a7cc	Histogram CT Zero ingestion Signed-off-by: Arthur Silva Sens <arthursens2005@gmail.com>	1 year ago
Callum Styan	005bd33fe2	support v2 proto for BenchmarkSampleSend (#14935 ) Signed-off-by: Callum Styan <callumstyan@gmail.com>	1 year ago
Callum Styan	c328d5fc88	fix rwv2 build write request benchmark, also change how the memory usage (#14925 ) is reported for these benchmarks to more accurately reflect what's actually allocated Signed-off-by: Callum Styan <callumstyan@gmail.com>	1 year ago
Antoine Pultier	d90d0976b5	fix(bstream/writeByte): ensure it appends only one byte (#14854 ) fix(bstream/writeByte): ensure it appends only one byte Signed-off-by: Antoine Pultier <antoine.pultier@sintef.no>	1 year ago
Nathan Baulch	50cd453c8f	chore: Fix typos (#14868 ) * Fix typos --------- Signed-off-by: Nathan Baulch <nathan.baulch@gmail.com>	1 year ago
Arve Knudsen	4fc562f9e7	OTLP: Support context cancellation/timeout during translation (#14612 ) * OTLP: Support context cancellation/timeout during translation --------- Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>	1 year ago
Arve Knudsen	bc6c2c5d35	OTLP Receiver: Add tests (#14764 ) Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>	1 year ago
Bryan Boreham	f90c7a11d1	[REFACTOR] OTLP translator: simplify time conversion We don't need multiple levels of abstraction to convert nanoseconds to milliseconds. We do benefit from tests, however. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>	1 year ago
Owen Williams	9da75328ea	fix(utf8): ensure correct validation when legacy mode turned on (#14736 ) fix(utf8): ensure correct validation when legacy mode turned on This depends on the included update of the prometheus/common dependency. --------- Signed-off-by: Owen Williams <owen.williams@grafana.com>	1 year ago
Justin Lei	3a82cd5a7e	Add streaming remote read to ReadClient (#11379 ) * Add streaming remote read to ReadClient Signed-off-by: Justin Lei <justin.lei@grafana.com> * Apply suggestions from code review Co-authored-by: Bartlomiej Plotka <bwplotka@gmail.com> Signed-off-by: Justin Lei <justin.lei@grafana.com> * Remote read instrumentation tweaks Signed-off-by: Justin Lei <lei.justin@gmail.com> * Minor cleanups Signed-off-by: Justin Lei <lei.justin@gmail.com> * In-line handleChunkedResponse Signed-off-by: Justin Lei <lei.justin@gmail.com> * Fix lints Signed-off-by: Justin Lei <lei.justin@gmail.com> * Explicitly call cancel() when needed Signed-off-by: Justin Lei <lei.justin@gmail.com> * Update chunkedSeries, chunkedSeriesIterator for new interfaces Signed-off-by: Justin Lei <lei.justin@gmail.com> * Adapt remote.chunkedSeries to use prompb.ChunkedSeries Signed-off-by: Justin Lei <lei.justin@gmail.com> * Fix lint Signed-off-by: Justin Lei <lei.justin@gmail.com> --------- Signed-off-by: Justin Lei <justin.lei@grafana.com> Signed-off-by: Justin Lei <lei.justin@gmail.com> Co-authored-by: Bartlomiej Plotka <bwplotka@gmail.com>	1 year ago
Devin Trejo	d4994e5bc4	fix: Remote-write-reciever returns 4xx when request contains a time series with duplicate labels. (#14716 ) Signed-off-by: Devin Trejo <dtrejo@palantir.com>	1 year ago
beorn7	0f760f63dd	lint: Revamp our linting rules, mostly around doc comments Several things done here: - Set `max-issues-per-linter` to 0 so that we actually see all linter warnings and not just 50 per linter. (As we also set `max-same-issues` to 0, I assume this was the intention from the beginning.) - Stop using the golangci-lint default excludes (by setting `exclude-use-default: false`. Those are too generous and don't match our style conventions. (I have re-added some of the excludes explicitly in this commit. See below.) - Re-add the `errcheck` exclusion we have used so far via the defaults. - Exclude the signature requirement `govet` has for `Seek` methods because we use non-standard `Seek` methods a lot. (But we keep other requirements, while the default excludes completely disabled the check for common method segnatures.) - Exclude warnings about missing doc comments on exported symbols. (We used to be pretty adamant about doc comments, but stopped that at some point in the past. By now, we have about 500 missing doc comments. We may consider reintroducing this check, but that's outside of the scope of this commit. The default excludes of golangci-lint essentially ignore doc comments completely.) - By stop using the default excludes, we now get warnings back on malformed doc comments. That's the most impactful change in this commit. It does not enforce doc comments (again), but _if_ there is a doc comment, it has to have the recommended form. (Most of the changes in this commit are fixing this form.) - Improve wording/spelling of some comments in .golangci.yml, and remove an outdated comment. - Leave `package-comments` inactive, but add a TODO asking if we should change that. - Add a new sub-linter `comment-spacings` (and fix corresponding comments), which avoids missing spaces after the leading `//`. Signed-off-by: beorn7 <beorn@grafana.com>	1 year ago
Arve Knudsen	b50c5d42fe	OTLP receiver: Warn when encountering invalid exponential histograms Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>	1 year ago
cuishuang	2110661121	fix: fix slice init length Signed-off-by: cuishuang <imcusg@gmail.com>	1 year ago
Arve Knudsen	3a78e76282	Upgrade golangci-lint to v1.60.1 Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>	1 year ago
Bryan Boreham	72d84f511f	Merge pull request #14515 from prometheus/revert-13777-remoteread2 (#14523 ) Revert "Chunked remote read: close the querier earlier" Signed-off-by: Bryan Boreham <bjboreham@gmail.com>	1 year ago
Callum Styan	1561815732	remote write: increase time threshold for resharding (#14450 ) Don't reshard if we haven't successfully sent a sample in the last shardUpdateDuration seconds. Signed-off-by: Callum Styan <callumstyan@gmail.com> Co-authored-by: kushagra Shukla <kushalshukla110@gmail.com>	1 year ago
Max Amin	84b819a69f	feat: add Google cloud roundtripper for remote write (#14346 ) * feat: Google Auth for remote write Signed-off-by: Max Amin <maxamin@google.com> --------- Signed-off-by: Max Amin <maxamin@google.com>	1 year ago
Bryan Boreham	03963b9ba0	Merge pull request #14515 from prometheus/revert-13777-remoteread2 (#14524 ) Revert "Chunked remote read: close the querier earlier" Signed-off-by: Bryan Boreham <bjboreham@gmail.com>	1 year ago

1 2 3 4 5 ...

601 Commits (bwplotka-patch-2)