prometheus

Commit Graph

Author	SHA1	Message	Date
Owen Williams	8d4bcd2c77	promql: Fix various UTF-8 bugs related to quoting Fixes UTF-8 aggregator label list items getting mutated with quote marks when String-ified. Fixes quoted metric names not supported in metric declarations. Fixes UTF-8 label names not being quoted when String-ified. Fixes https://github.com/prometheus/prometheus/issues/15470 Fixes https://github.com/prometheus/prometheus/issues/15528 Signed-off-by: Owen Williams <owen.williams@grafana.com> Co-authored-by: Bryan Boreham <bjboreham@gmail.com>	1 year ago
Bryan Boreham	54989ce6fd	PromQL: add short string method To be used in tracing or logging. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>	1 year ago
Owen Williams	9da75328ea	fix(utf8): ensure correct validation when legacy mode turned on (#14736 ) fix(utf8): ensure correct validation when legacy mode turned on This depends on the included update of the prometheus/common dependency. --------- Signed-off-by: Owen Williams <owen.williams@grafana.com>	1 year ago
Owen Williams	d90c5a71d7	support quoting in grouping label lists Signed-off-by: Owen Williams <owen.williams@grafana.com>	1 year ago
Oleg Zaytsev	4b7a44c7a0	Fix `parser.VectorSelector.String()` with empty name matcher (#14015 ) The check fell into "this matcher equals vector selector's name" case when vector selector doesn't have a name and the matcher is an explicit matcher for an empty __name__ label. To provide some context about why this is important: some downstream projects use the promql.Parse(expr.String()) to clone an expression's AST, and with this bug that matcher disappears in the cloning. Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>	2 years ago
beorn7	5b53aa1108	style: Replace `else if` cascades with `switch` Wiser coders than myself have come to the conclusion that a `switch` statement is almost always superior to a statement that includes any `else if`. The exceptions that I have found in our codebase are just these two: * The `if else` is followed by an additional statement before the next condition (separated by a `;`). * The whole thing is within a `for` loop and `break` statements are used. In this case, using `switch` would require tagging the `for` loop, which probably tips the balance. Why are `switch` statements more readable? For one, fewer curly braces. But more importantly, the conditions all have the same alignment, so the whole thing follows the natural flow of going down a list of conditions. With `else if`, in contrast, all conditions but the first are "hidden" behind `} else if `, harder to spot and (for no good reason) presented differently from the first condition. I'm sure the aforemention wise coders can list even more reasons. In any case, I like it so much that I have found myself recommending it in code reviews. I would like to make it a habit in our code base, without making it a hard requirement that we would test on the CI. But for that, there has to be a role model, so this commit eliminates all `if else` occurrences, unless it is autogenerated code or fits one of the exceptions above. Signed-off-by: beorn7 <beorn@grafana.com>	3 years ago
Matthieu MOREL	fb3eb21230	enable gocritic, unconvert and unused linters Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>	3 years ago
Julien Pivotto	d41e5a5582	Prettifier: Add spaces with non-callable keywords (#11005 ) * Prettifier: Add spaces with non-callable keywords I prefer to have a difference between, on one side: functions calls, end(), start(), and on the other side with, without, ignoring, by and group_rrigt, group_left. The reasoning is that the former ones are not calls, while other are functions. Additionally, it matches the examples in our documentation. Signed-off-by: Julien Pivotto <roidelapluie@o11y.eu> * Fix tests Signed-off-by: Julien Pivotto <roidelapluie@o11y.eu>	4 years ago
Harkishen Singh	44fcf876ca	Adds support for prettifying PromQL expression (#10544 ) * Implement Pretty() function for AST nodes. Signed-off-by: Harkishen-Singh <harkishensingh@hotmail.com> This commit adds .Pretty() for all nodes of PromQL AST. Each .Pretty() prettifies the node it belongs to, and under no circustance, the parent or child node is touch/prettified. Read more in the "Approach" part in `prettier.go` * Refactor functions between printer.go & prettier.go Signed-off-by: Harkishen-Singh <harkishensingh@hotmail.com> This commit removes redundancy between printer.go and prettier.go by taking out the common code into separate private functions. * Add more unit tests for Prettier. Signed-off-by: Harkishen-Singh <harkishensingh@hotmail.com> * Add support for spliting function calls with 1 arg & unary expressions. Signed-off-by: Harkishen-Singh <harkishensingh@hotmail.com> This commit does 2 things: 1. It adds support to split function calls that have 1 arg and exceeds the max_characters_per_line to multiple lines. 2. Splits Unary expressions that exceed the max_characters_per_line. This is done by formatting the child node and then removing the prefix indent, which is already applied before the unary operator.	4 years ago
beorn7	c954cd9d1d	Move packages out of deprecated pkg directory This creates a new `model` directory and moves all data-model related packages over there: exemplar labels relabel rulefmt textparse timestamp value All the others are more or less utilities and have been moved to `util`: gate logging modetimevfs pool runtime Signed-off-by: beorn7 <beorn@grafana.com>	4 years ago
Oleg Zaytsev	0a43e788af	Allow VectorSelector.String() without matchers (#9282 ) * Allow VectorSelector.String() without matchers Previously this method was panicking because it was trying to allocate a slice with capacity -1. There's nothing saying that VectorSelector should have matchers, and it's actually prepared to have zero matcher strings, so it's worth checking instead of panicking. Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>	4 years ago
schou	3bafe17870	add negative offset to printer Signed-off-by: schou <pschou@users.noreply.github.com>	5 years ago
Ganesh Vernekar	86c71856e8	Add start() and end() pre-processors for @ modifier (#8425 ) * Add start() and end() pre-processors for @ modifier Signed-off-by: Ganesh Vernekar <cs15btech11018@iith.ac.in> * Fix reviews Signed-off-by: Ganesh Vernekar <cs15btech11018@iith.ac.in> * Fix review comments Signed-off-by: Ganesh Vernekar <cs15btech11018@iith.ac.in> * Fix review comments Signed-off-by: Ganesh Vernekar <cs15btech11018@iith.ac.in>	5 years ago
Ganesh Vernekar	9199fcb8d1	'@ <timestamp>' modifier (#8121 ) This commit adds `@ <timestamp>` modifier as per this design doc: https://docs.google.com/document/d/1uSbD3T2beM-iX4-Hp7V074bzBRiRNlqUdcWP6JTDQSs/edit. An example query: ``` rate(process_cpu_seconds_total[1m]) and topk(7, rate(process_cpu_seconds_total[1h] @ 1234)) ``` which ranks based on last 1h rate and w.r.t. unix timestamp 1234 but actually plots the 1m rate. Signed-off-by: Ganesh Vernekar <cs15btech11018@iith.ac.in>	5 years ago
Julien Pivotto	4e5b1722b3	Move away from testutil, refactor imports (#8087 ) Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu>	5 years ago
Ben Kochie	269e7c8091	Fix golint issues. Signed-off-by: Ben Kochie <superq@gmail.com>	6 years ago
Tobias Guggenmos	1360f9ff12	Fix all build errors in promql package Signed-off-by: Tobias Guggenmos <tguggenm@redhat.com>	6 years ago
Tobias Guggenmos	65f5b9827d	Rename package Signed-off-by: Tobias Guggenmos <tguggenm@redhat.com>	6 years ago
Tobias Guggenmos	e7c2716f55	Move files Signed-off-by: Tobias Guggenmos <tguggenm@redhat.com>	6 years ago
Tobias Guggenmos	2aacd807b3	PromQL: Various small improvements in the parser (#6652 ) * Move check for empty VectorSelector to typeChecking * Move check for twice set metric name to typeChecking * Make child of MatrixSelector a general Node * rename checkType to checkAST * Rename fail to addParseErr * Remove trailing whitespace Signed-off-by: Tobias Guggenmos <tguggenm@redhat.com>	6 years ago
Tobias Guggenmos	64194f7d45	PromQL: AST: Make VectorSelector Children of MatrixSelector (#6590 ) Make Vector selectors children of Matrix Selectors Signed-off-by: Tobias Guggenmos <tguggenm@redhat.com>	6 years ago
Bartosz Jakubski	80ba03c67d	fix subquery with offset conversion to string (#6373 ) Signed-off-by: Bartosz Jakubski <b.jakubski@gmail.com>	6 years ago
Tobias Guggenmos	d0cff29749	PromQL: Reduce Code duplication in AST traversion (#6362 ) * promql: Add Children function for easier AST traversion Signed-off-by: Tobias Guggenmos <tguggenm@redhat.com>	6 years ago
Brian Brazil	36dbf042e3	Correctly handle {__name__="a"} (#5552 ) This can cause problems in alerts. Signed-off-by: Brian Brazil <brian.brazil@robustperception.io>	7 years ago
Simon Pasquier	f678e27eb6	: use latest release of staticcheck (#5057 ) : use latest release of staticcheck It also fixes a couple of things in the code flagged by the additional checks. Signed-off-by: Simon Pasquier <spasquie@redhat.com> Use official release of staticcheck Also run 'go list' before staticcheck to avoid failures when downloading packages. Signed-off-by: Simon Pasquier <spasquie@redhat.com>	7 years ago
Ganesh Vernekar	dbe55c1352	Subquery (#4831 ) Signed-off-by: Ganesh Vernekar <cs15btech11018@iith.ac.in>	7 years ago
Frederic Branczyk	b0b3e3dd74	promql: Remove old and unused alerting/reconding syntax Signed-off-by: Frederic Branczyk <fbranczyk@gmail.com>	7 years ago
Julius Volz	953af2c089	promql: Make printer formatting less vintage (#3721 ) - lower-case modifiers - reverse order of aggregation modifiers and aggregated expression - remove spacing before modifier parentheses	8 years ago
Julius Volz	1e943fc10a	promql: Fix printing of empty without() (#3719 ) * promql: Fix printing of empty without() Fixes https://github.com/prometheus/prometheus/issues/3704 * Test cleanup fixup	8 years ago
Brian Brazil	99905f82a6	Remove keep_common modifier. See #3060	8 years ago
Fabian Reinartz	71fe0c58a8	promql: misc fixes	9 years ago
Fabian Reinartz	fecf9532b9	*: fix misc compile errors	9 years ago
Fabian Reinartz	9ea10d5265	promql: use labels.Builder to modify labels	9 years ago
Fabian Reinartz	15a931dbdb	promql: migrate model types, use tsdb interfaces	9 years ago
Tristan Colgate	ab60bc3929	Fix export of grouping modifier	9 years ago
Brian Brazil	e1cfc994f7	Correctly handle on() in alerts. (#2096 ) Fixes #2082	9 years ago
Brian Brazil	c4b4a58e3a	Correctly handle on() in alerts. (#2096 ) Fixes #2082	9 years ago
Brian Brazil	3e5136e36d	Make topk/bottomk aggregators.	10 years ago
Matt Bostock	cc98e164d3	promql: Fix annotations conflated with labels When converting `AlertStmt` to a string, the alert rule labels were printed as `ANNOTATIONS` instead of the annotations themselves. Fix and add a test to catch future regressions.	10 years ago
Brian Brazil	246a817300	Flip vector matching to be ignoring by default. This is a noop semantically.	10 years ago
Fatih Arslan	362e44501a	promql: fix printing annotations of an AlertStmt Currently the printer doesn't print the annotations of an `AlertStmt` declaration. I've added a test case as well, which fails for the current master.	10 years ago
beorn7	5408666387	Correctly stringify GROUP_x modifiers without labels Since rule evaluations work via String(), this fixes evaluation of rules containing GROUP_x modifiers without labels. This change is the minimal bugfix (so that we can release a fixed version without risk). It does not intend to implement any additional features (like allowing `GROUP_LEFT()` or `ON()` or even `ON` - see discussion in https://github.com/prometheus/prometheus/issues/1597 ).	10 years ago
Ali Reza	e7eba75690	remove keeping_extra because it's replaced with keep_common change all keepExtra label into keepCommon, and move action into removed list change incorrect token list	10 years ago
Brian Brazil	7201c010c4	Rename On to MatchingLabels	10 years ago
Brian Brazil	1d08c4fef0	Add 'ignoring' as modifier for binops. Where 'on' uses the given labels to match, 'ignoring' uses all other labels to match. group_left/right is not supported yet.	10 years ago
Julius Volz	6ac39700ea	Fix missing printed keep_common without grouping.	10 years ago
Brian Brazil	9d0112d7cf	Add without aggregator modifier. This has the advantage that the user doesn't need to list all labels they want to keep (as with "by") but without having to worry about inconsistent labels as when there's only one time series (as with "keeping_common"). Almost all aggregation should use this rather than the existing two options as it's much less error prone and easier to maintain due to not having to always add in "job" plus whatever other common job-level labels you have like "region".	10 years ago
beorn7	a7408bfb47	Unify duration parsing It's actually happening in several places (and for flags, we use the standard Go time.Duration...). This at least reduces all our home-grown parsing to one place (in model).	10 years ago
Fabian Reinartz	a6935024e1	Remove old WITH clause in alert printing	10 years ago
Fabian Reinartz	af3a6661ed	Implement new alerting rule syntax	10 years ago

18 Commits (bwplotka-patch-3)