8 Commits (lbl-optimize)

Author	SHA1	Message	Date
Benoit Gagnon	6d931a2195	Fix Windows support for custom-sd adapter (#6217) ... * add test to custom-sd/adapter writeOutput() function Signed-off-by: Benoit Gagnon <benoit.gagnon@ubisoft.com> * fix Adapter.writeOutput() function to work on Windows On that platform, files cannot be moved while a process holds a handle to them. Added an explicit Close() before that move. With this change, the unit test succeeds. Signed-off-by: Benoit Gagnon <benoit.gagnon@ubisoft.com> * add missing dot to comment Signed-off-by: Benoit Gagnon <benoit.gagnon@ubisoft.com>	6 years ago
李国忠	d89e783217	[bugfix] custom SD: when ip out of order, reflect.deepEqual can not correctly identify whether there is a change (#5856) ... * [bugfix] custom SD: when ip out of order, reflect.deepEqual can not correctly identify whether there is a change Signed-off-by: fuling <fuling.lgz@alibaba-inc.com> * [format] makefile:Makefile.common:116: common-style Signed-off-by: fuling <fuling.lgz@alibaba-inc.com> * [bugfix] custom sd: simonpasquier comment,It would be simpler to sort the targets alphabetically and keep reflect.DeepEqual. Signed-off-by: fuling <fuling.lgz@alibaba-inc.com> * [bugfix]custom SD:fix sort Signed-off-by: fuling <fuling.lgz@alibaba-inc.com> * [bugfix] custom SD : adapter.go need an empty line after "sort" Signed-off-by: fuling <fuling.lgz@alibaba-inc.com> * [bugfix]custom SD:test sign-off Signed-off-by: fuling <fuling.lgz@alibaba-inc.com> * [bugfix]custom SD: fix adaper_test.go Signed-off-by: fuling <fuling.lgz@alibaba-inc.com>	6 years ago
Yaqiang Wang	8b85d876f2	fix file_sd never stop update 'custom_sd.json' file in adapter.go (#4567) ... Signed-off-by: wangyaqiang1 <wangyaqiang1@jd.com>	7 years ago
Augustin Husson	f60620ec0b	format comment ... Signed-off-by: Augustin Husson <husson.augustin@gmail.com>	7 years ago
Augustin Husson	3c0b130e5e	apply review ... Signed-off-by: Augustin Husson <husson.augustin@gmail.com>	7 years ago
Augustin Husson	e03869de76	add unit test and isolate the method that generate the target ... Signed-off-by: Augustin Husson <husson.augustin@gmail.com>	7 years ago
Augustin Husson	97950a3fae	remove group if the target is empty at adapter level ... Signed-off-by: Augustin Husson <husson.augustin@gmail.com>	7 years ago
Callum Styan	03578d5df8	add example usage of SD adapter for converting unsupported SD type to filesd (#3720) ... Signed-off-by: Callum Styan <callumstyan@gmail.com>	7 years ago