prometheus

Commit Graph

Author	SHA1	Message	Date
jub0bs	4bc8df0f54	util/httputil: Always add Vary header in SetCORS Closes #15406 Signed-off-by: jub0bs <jcretel-infosec+github@protonmail.com>	1 month ago
Ayoub Mrini	eb8d34c2ad	Merge pull request #16587 from prymitive/discoveryLocks discovery: Try fixing potential deadlocks in discovery	1 month ago
Ayoub Mrini	4b7321c8e8	Merge pull request #16607 from marcoderama/patch-3 docs: fix typo in operators.md	1 month ago
Bartlomiej Plotka	8e6b008608	feature: type-and-unit-labels (PROM-39 implementation) (#16228 ) * feature: type-and-unit-labels (extended MetricIdentity) Experimental implementation of https://github.com/prometheus/proposals/pull/39 Previous (unmerged) experiments: * https://github.com/prometheus/prometheus/compare/main...dashpole:prometheus:type_and_unit_labels * https://github.com/prometheus/prometheus/pull/16025 Signed-off-by: bwplotka <bwplotka@gmail.com> feature: type-and-unit-labels (extended MetricIdentity) Experimental implementation of https://github.com/prometheus/proposals/pull/39 Previous (unmerged) experiments: * https://github.com/prometheus/prometheus/compare/main...dashpole:prometheus:type_and_unit_labels * https://github.com/prometheus/prometheus/pull/16025 Signed-off-by: bwplotka <bwplotka@gmail.com> * Fix compilation errors Signed-off-by: Arthur Silva Sens <arthursens2005@gmail.com> Lint Signed-off-by: Arthur Silva Sens <arthursens2005@gmail.com> Revert change made to protobuf 'Accept' header Signed-off-by: Arthur Silva Sens <arthursens2005@gmail.com> Fix compilation errors for 'dedupelabels' tag Signed-off-by: Arthur Silva Sens <arthursens2005@gmail.com> * Rectored into schema.Metadata Signed-off-by: bwplotka <bwplotka@gmail.com> * texparse: Added tests for PromParse Signed-off-by: bwplotka <bwplotka@gmail.com> * add OM tests. Signed-off-by: bwplotka <bwplotka@gmail.com> * add proto tests Signed-off-by: bwplotka <bwplotka@gmail.com> * Addressed comments. Signed-off-by: bwplotka <bwplotka@gmail.com> * add schema label tests. Signed-off-by: bwplotka <bwplotka@gmail.com> * addressed comments. Signed-off-by: bwplotka <bwplotka@gmail.com> * fix tests. Signed-off-by: bwplotka <bwplotka@gmail.com> * add promql tests. Signed-off-by: bwplotka <bwplotka@gmail.com> * lint Signed-off-by: bwplotka <bwplotka@gmail.com> * Addressed comments. Signed-off-by: bwplotka <bwplotka@gmail.com> --------- Signed-off-by: bwplotka <bwplotka@gmail.com> Signed-off-by: Arthur Silva Sens <arthursens2005@gmail.com> Co-authored-by: Arthur Silva Sens <arthursens2005@gmail.com>	1 month ago
Arthur Silva Sens	5a98246f50	Fix flakiness in TestOTLPWriteHandler (#16608 )	1 month ago
Jan-Otto Kröpke	84a3acaf1b	Merge release-3.4 into main (#16609 ) Co-authored-by: Ayoub Mrini <ayoubmrini424@gmail.com>	1 month ago
Jan-Otto Kröpke	546b1d242e	Adjust release date in CHANGELOG.md Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>	1 month ago
Jan-Otto Kröpke	93f7c78211	Release 3.4.0 (#16600 )	1 month ago
marcoderama	778d49bbfb	docs: fix typo in operators.md Signed-off-by: marcoderama <marcoderamagit@gmail.com>	1 month ago
Julius Volz	69ed0a5794	Add health & text filtering on the /rules page Addresses part of https://github.com/prometheus/prometheus/issues/16515 For now, I'm adding very similar filtering to the /rules page as we have on the /alerts page, with the difference being: * The state filter filters by rule health (ok/warn/unknown) instead of alert state (firing/pending/inactive) * We don't collect & show detailed stats on the different state counts as we do on the /alerts page There is a lot of copied / very similar code between those two pages (and also some others) around filtering and pagination, so maybe there is an opportunity for more code sharing in the future here. Signed-off-by: Julius Volz <julius.volz@gmail.com>	1 month ago
Julius Volz	77224a6ef1	Merge pull request #16604 from prometheus/fix-dropped-target-counts SD UI: Better total target count display when using `keep_dropped_targets` option	1 month ago
Julius Volz	5f1c6226e2	SD UI: Better total target count display when using `keep_dropped_targets` option Fixes https://github.com/prometheus/prometheus/issues/16586 Signed-off-by: Julius Volz <julius.volz@gmail.com>	1 month ago
Ben Kochie	1eaf12e99b	Add golangci-lint fmt (#16602 ) With golangci-lint v2, it now has "formatters" that can be configured. Add `golangci-lint fmt` to the `make format` in Makefile.common. * Enable goimports formatter. Signed-off-by: SuperQ <superq@gmail.com>	1 month ago
Ben Kochie	3eb44003c6	Fixup make proto (#16603 ) Use `common-` prefix for `make proto` so downstream projects like client_golang can implement their own `make proto`. Signed-off-by: SuperQ <superq@gmail.com>	1 month ago
Lukasz Mierzwa	59761f631b	Move m.targetsMtx.Lock down into the loop Make sure the order of locks is always the same in all functions. In ApplyConfig() we have m.targetsMtx.Lock() after provider is locked, so replicate the same in allGroups(). Signed-off-by: Lukasz Mierzwa <l.mierzwa@gmail.com>	1 month ago
Ayoub Mrini	2690761582	Merge pull request #16558 from wbh1/fix/GOGC-ENV-VAR fix(config): respect GOGC environment variable if no "runtime" block exists	1 month ago
Julius Volz	df1b4da348	Merge pull request #16597 from prometheus/cleanup-docs-code-and-headers Clean up codeboxes and headings in docs	1 month ago
Julius Volz	1b818b03d5	Clean up codeboxes and headings in docs The new docs site will have syntax highlighting, so this adds language tags to code boxes that are currently missing them. I didn't add `promql` as a language yet since the highlighter doesn't support it yet, plus a lot of the PromQL codeboxes in our docs aren't strictly valid PromQL, they are more like multiple expressions listed in the same code box on multiple lines. So I'm leaving that for sometime later. In the HTTP API page, I moved the curl examples from the JSON codeboxes to their own ones above the JSON output. I considered putting an "Output:" text between the curl + JSON output, but I think the way it currently looks without it is probably fine. I also fixed a number of headings which were at the wrong level relative to their nesting in the document. I also removed `go` as a language from the Go template language examples, because the Go template language isn't Go at all. I also adjusted the indent on one codebox to be more reasonable (2 spaces instead of 8). And then finally, my editor made a bunch of whitespace changes automatically, like removing trailing spaces. Signed-off-by: Julius Volz <julius.volz@gmail.com> Signed-off-by: Julius Volz <julius.volz@gmail.com>	1 month ago
Will Hegedus	5d94ad9ae0	test(cmd): enable test cases for GOGC environment variable Signed-off-by: Will Hegedus <whegedus@akamai.com>	2 months ago
Will Hegedus	33578fedb3	fix(config): respect GOGC environment variable if no "runtime" block exists Fixes: https://github.com/prometheus/prometheus/issues/16334 Related to: - https://github.com/prometheus/prometheus/pull/15238 - https://github.com/prometheus/prometheus/pull/16052 Currently, when the GOGC environment variable is set -- and no `runtime` block is set in the Prometheus config file -- it is ignored and the default value of 75% is always used. However, if there is an empty runtime block (e.g. `runtime: {}`), _then_ the GOGC environment variable is checked. This PR changes this behavior to consistently check and use the GOGC environment variable when it is set (unless the `gogc` field is set in the `runtime` block of the loaded config file, in which case it still gives that precedence). Co-authored-by: Adam Rambo <arambo@protonmail.com> Signed-off-by: Will Hegedus <whegedus@akamai.com>	2 months ago
Julius Volz	dbf5d01a62	Fix full-page re-rendering when opening status nav menu (#16590 ) When opening the status pages menu while already viewing one of the status pages, the whole page would be re-rendered because the menu target's default action of following the current page's URL was not prevented. Also, we don't need to use a NavLink component for the menu target when we are not viewing a status page, because then the component won't need to be highlighted anyways. Discovered + fixed with the help of react-scan. Signed-off-by: Julius Volz <julius.volz@gmail.com>	2 months ago
Julius Volz	5c06804df8	Optimize memoization and search debouncing on /targets page (#16589 ) Moving the debouncing of the search field to the parent component and then memoizing the ScrapePoolsList component prevents a lot of superfluous re-renders of the entire scrape pools list that previously got triggered immediately when you typed in the search box or even just collapsed a pool. (While the computation of what data to show was already memoized in the ScrapePoolList component, the component itself still had to re-render a lot with the same data.) Discovered this problem + verified fix using react-scan. Signed-off-by: Julius Volz <julius.volz@gmail.com>	2 months ago
Lukasz Mierzwa	7d55ee8cc8	Try fixing potential deadlocks in discovery Manager.ApplyConfig() uses multiple locks: - Provider.mu - Manager.targetsMtx Manager.cleaner() uses the same locks but in the opposite order: - First it locks Manager.targetsMtx - The it locks Provider.mu I've seen a few strange cases of Prometheus hanging up on shutdown and never compliting that shutdown. From a few traces I was given it appears that while Prometheus is still running only discovery.Manager and notifier.Manager are running running. From that trace it also seems like they are stuck on a lock from two functions: - cleaner waits on a RLock() - ApplyConfig waits on a Lock() I cannot reproduce it but I suspect this is a race between locks. Imagine this scenario: - Manager.ApplyConfig() is called - Manager.ApplyConfig locks Provider.mu.Lock() - at the same time cleaner() is called on the same Provider instance and it calls Manager.targetsMtx.Lock() - Manager.ApplyConfig() now calls Manager.targetsMtx.Lock() but that lock is already held by cleaner() function so ApplyConfig() hangs there - at the same time cleaner() now wants to lock Provider.mu.Rlock() but that lock is already held by Manager.ApplyConfig() - we end up with both functions locking each other out without any way to break that lock Re-order lock calls to try to avoid this scenario. I tried writing a test case for it but couldn't hit this issue. Signed-off-by: Lukasz Mierzwa <l.mierzwa@gmail.com>	2 months ago
Neeraj Gartia	8b0d33e5b2	promql: support variable scalar parameter in aggregations in range queries (#16404 ) This fixes the regression introduced in https://github.com/prometheus/prometheus/issues/15971 while preserving the performance improvements. Signed-off-by: Neeraj Gartia <neerajgartia211002@gmail.com>	2 months ago
Neeraj Gartia	591242901a	promql: Refactor some functions to make them more DRY (#16532 ) Signed-off-by: Neeraj Gartia <neerajgartia211002@gmail.com>	2 months ago
hardlydearly	ba4b058b7a	refactor: use slices.Contains to simplify code Signed-off-by: hardlydearly <799511800@qq.com>	2 months ago
Julien	59874fd89c	Merge pull request #16478 from KofClubs/range-vector-1001ms promql: function selector sometimes misses a sample on dense samples	2 months ago
George Krajcsovits	f0471ff74b	Merge pull request #16552 from charleskorn/charleskorn/fix-16551 promql: don't emit a value from `histogram_fraction` or `histogram_quantile` if classic and native histograms are present at the same timestamp	2 months ago
Ryan Wu	a810e59990	UI: optimize pool searching in /target page Signed-off-by: Ryan Wu <rongjun0821@gmail.com>	2 months ago
György Krajcsovits	6c646657d5	perf(chunkenc): intern the custom values for native histograms The custom values are the "le" bucket boundaries of native histograms with custom buckets. They are never modified. It is ok to not copy them when iterating a chunk, just reference them. If we will ever have a function that modifies the custom values, like 'trim' for example. That function will have to make a copy on write. Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>	2 months ago
György Krajcsovits	6dc6785473	chore(engine): add simple NHCB benchmark Copy the benchmark for native histograms with exponential buckets and adopt to native histograms with custom buckets. Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>	2 months ago
Martin Danko	148968e399	docs: Fix `metric_name_escaping_scheme` config parameter This is a fix for documentation update done in https://github.com/prometheus/prometheus/pull/16066, setting correct name for a configuration value. Signed-off-by: Martin Danko <46035688+zepellin@users.noreply.github.com>	2 months ago
Lukasz Mierzwa	7f58b4f784	Fix position in TestPreprocessAndWrapWithStepInvariantExpr This is failing after `26088d01b9` and it seems that currently tested position is incorrect, fix it Signed-off-by: Lukasz Mierzwa <l.mierzwa@gmail.com>	2 months ago
György Krajcsovits	06d0b063ea	fix(parser): parenthesis around aggregate expression parsing The position range of nested aggregate expression was wrong, for the expression "(sum(foo))" the position of "sum(foo)" should be 1-9, but the parser could not decide the end of the expression on pos 9, instead it read ahead to pos 10 and then emitted the aggregate. But we only kept the last closing position (10) and wrote that into the aggregate. The reason for this is that the parser cannot know from "(sum(foo)" alone if the aggregate is finished. It could be finished as in "(sum(foo))" but equally it could continue with group modifier as "(sum(foo) by (bar))". The fix is to track ")" tokens in a stack in addition to the lastClosing position, which is overloaded with other things like offset number tracking. Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>	2 months ago
Lukasz Mierzwa	ba690a8c4c	Add a test for aggregation wrapped in ParenExpr Signed-off-by: Lukasz Mierzwa <l.mierzwa@gmail.com>	2 months ago
dongjiang	2bf6f4c9dc	update fix configuration.md Signed-off-by: dongjiang <dongjiang1989@126.com>	2 months ago
Andre Branchizio	b07b552139	[PERF] TSDB: Pass down label value limit into implementation (#16158 ) * allow limiting label values calls Signed-off-by: Andre Branchizio <andrejbranch@gmail.com>	2 months ago
machine424	ca70ed4fed	test(cmd): add test for GOGC setting As suggested in https://github.com/prometheus/prometheus/pull/14176#issuecomment-2150308054 Signed-off-by: machine424 <ayoubmrini424@gmail.com>	2 months ago
Dimitar Dimitrov	7e49b91d9a	tsdb/errors.MultiError: support errors.As (#16544 ) * tsdb/errors.MultiError: implement Unwrap the multierror was hiding some errors in Mimir. I also added unit tests because I had them handy from a similar change I and yuri did in XXX and some time ago --------- Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com> Co-authored-by: Arve Knudsen <arve.knudsen@gmail.com>	2 months ago
Björn Rabenstein	1d847f70c9	Merge pull request #16556 from NeerajGartia21/promql/promql-test-bug [FIX] Promql-test: Fix error message for new eval syntax when `expect` line does not match with regex	2 months ago
George Krajcsovits	2726a18ae3	Merge pull request #16452 from chardch/global-always-scrape-classic-hist Add global config option for always_scrape_classic_histograms	2 months ago
machine424	b59b76639f	chore(scripts/sync_repo_files): add link to source script Signed-off-by: machine424 <ayoubmrini424@gmail.com>	2 months ago
Neeraj Gartia	a177376d72	fix promql-test error message and readme Signed-off-by: Neeraj Gartia <neerajgartia211002@gmail.com>	2 months ago
chardch	a1c157aaef	Add global config option for always_scrape_classic_histograms Addresses https://github.com/prometheus/prometheus/issues/16371 This will help with migrating to native histograms with `convert_classic_histograms_to_nhcb` since users may still need to keep the classic histograms during a migration Signed-off-by: chardch <otwordsne@gmail.com>	2 months ago
Charles Korn	2c0f02a702	promql: don't emit a value from `histogram_fraction` or `histogram_quantile` if classic and native histograms are present at the same timestamp Signed-off-by: Charles Korn <charles.korn@grafana.com>	2 months ago
dependabot[bot]	c3ce1f1927	chore(deps): bump actions/setup-node from 4.3.0 to 4.4.0 (#16533 ) Bumps [actions/setup-node](https://github.com/actions/setup-node) from 4.3.0 to 4.4.0. - [Release notes](https://github.com/actions/setup-node/releases) - [Commits](`cdca7365b2...49933ea528`) --- updated-dependencies: - dependency-name: actions/setup-node dependency-version: 4.4.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>	2 months ago
github-actions[bot]	fc805c1cbd	Merge pull request #16539 from prometheus/dependabot/go_modules/google.golang.org/api-0.231.0 chore(deps): bump google.golang.org/api from 0.230.0 to 0.231.0	2 months ago
github-actions[bot]	504a130722	Merge pull request #16535 from prometheus/dependabot/github_actions/github/codeql-action-3.28.16 chore(deps): bump github/codeql-action from 3.28.13 to 3.28.16	2 months ago
github-actions[bot]	3be2820f8a	Merge pull request #16540 from prometheus/dependabot/go_modules/github.com/open-telemetry/opentelemetry-collector-contrib/processor/deltatocumulativeprocessor-0.125.0 chore(deps): bump github.com/open-telemetry/opentelemetry-collector-contrib/processor/deltatocumulativeprocessor from 0.124.1 to 0.125.0	2 months ago
github-actions[bot]	f75b08c82b	Merge pull request #16538 from prometheus/dependabot/go_modules/github.com/digitalocean/godo-1.145.0 chore(deps): bump github.com/digitalocean/godo from 1.144.0 to 1.145.0	2 months ago

1 2 3 4 5 ...

15768 Commits (main) All Branches Search

15768 Commits (main)

All Branches