14 Commits (release-3.5)

Author	SHA1	Message	Date
Charles Korn	2ca4d16236	storage: add `AtT` method to `MemoizedSeriesIterator` ... Signed-off-by: Charles Korn <charles.korn@grafana.com>	12 months ago
Filip Petkovski	583f3e587c	Optimize histogram iterators (#13340) ... Optimize histogram iterators Histogram iterators allocate new objects in the AtHistogram and AtFloatHistogram methods, which makes calculating rates over long ranges expensive. In #13215 we allowed an existing object to be reused when converting an integer histogram to a float histogram. This commit follows the same idea and allows injecting an existing object in the AtHistogram and AtFloatHistogram methods. When the injected value is nil, iterators allocate new histograms, otherwise they populate and return the injected object. The commit also adds a CopyTo method to Histogram and FloatHistogram which is used in the BufferedIterator to overwrite items in the ring instead of making new copies. Note that a specialized HPoint pool is needed for all of this to work (`matrixSelectorHPool`). --------- Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com> Co-authored-by: George Krajcsovits <krajorama@users.noreply.github.com>	1 year ago
Justin Lei	7bbf24b707	Make MemoizedSeriesIterator not implement chunkenc.Iterator ... Signed-off-by: Justin Lei <justin.lei@grafana.com>	2 years ago
Justin Lei	6985dcbe73	Optimize and test MemoizedSeriesIterator ... Signed-off-by: Justin Lei <justin.lei@grafana.com>	2 years ago
detailyang	3e482c905f	fix:storage:avoid panic when iterater exhauested (#9945) ... Signed-off-by: detailyang <detailyang@gmail.com>	4 years ago
Björn Rabenstein	4ce01e9770	storage: Rename ...Values methods to At... (#9889) ... This mirrors #9888 for the richer iterators we have with histograms in the game. Signed-off-by: beorn7 <beorn@grafana.com>	4 years ago
Björn Rabenstein	d677aa4b29	storage: Consolidate iterator method names (Values -> At) (#9888) ... `BufferedSeriesIterator` and `MemoizedSeriesIterator` use a method called `Values` for exactly the purpose for which all other iterators of the same kind use a method called `At`. That alone is confusing, but on top of that, the `Values` method only returns a single sample, not multiple values. I assume the naming has historical reasons. This commit makes it more consistent. It is now easier to read, and now `BufferedSeriesIterator` and `MemoizedSeriesIterator` implement `chunkenc.Iterator` like many other iterators, too. Signed-off-by: beorn7 <beorn@grafana.com>	4 years ago
Björn Rabenstein	7e42acd3b1	tsdb: Rework iterators (#9877) ... - Pick At... method via return value of Next/Seek. - Do not clobber returned buckets. - Add partial FloatHistogram suppert. Note that the promql package is now _only_ dealing with FloatHistograms, following the idea that PromQL only knows float values. As a byproduct, I have removed the histogramSeries metric. In my understanding, series can have both float and histogram samples, so that metric doesn't make sense anymore. As another byproduct, I have converged the sampleBuf and the histogramSampleBuf in memSeries into one. The sample type stored in the sampleBuf has been extended to also contain histograms even before this commit. Signed-off-by: beorn7 <beorn@grafana.com>	4 years ago
beorn7	73858d7f82	storage: histogram support in memoized_iterator ... Signed-off-by: beorn7 <beorn@grafana.com>	4 years ago
beorn7	9b30ca2598	promql: Support histogram in value string representation ... Signed-off-by: beorn7 <beorn@grafana.com>	4 years ago
Marco Pracucci	6f050f66c7	Update storage/memoized_iterator.go ... Signed-off-by: Marco Pracucci <marco@pracucci.com> Co-authored-by: Julien Pivotto <roidelapluie@gmail.com>	4 years ago
Marco Pracucci	b92c03023d	Optimized vector selector ... Signed-off-by: Marco Pracucci <marco@pracucci.com>	4 years ago