prometheus

Commit Graph

Author	SHA1	Message	Date
Brian Brazil	bef9d4e182	Don't include rendered expression in parse errors. (#8177 ) For a sufficiently complex expression, having to render thousands of nodes for every subquery type error can take a while - so don't do that. Signed-off-by: Brian Brazil <brian.brazil@robustperception.io>	5 years ago
Julien Pivotto	6c56a1faaa	Testify: move to require (#8122 ) * Testify: move to require Moving testify to require to fail tests early in case of errors. Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu> * More moves Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu>	5 years ago
Julien Pivotto	1282d1b39c	Refactor test assertions (#8110 ) * Refactor test assertions This pull request gets rid of assert.True where possible to use fine-grained assertions. Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu>	5 years ago
Julien Pivotto	4e5b1722b3	Move away from testutil, refactor imports (#8087 ) Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu>	5 years ago
Harkishen Singh	fc8e769d71	Use ASSIGN when using = inside braces (#7911 ) * Fix EQL when using = inside braces. Signed-off-by: Harkishen-Singh <harkishensingh@hotmail.com> * EQL => EQLC and ASSIGN => EQL Signed-off-by: Harkishen-Singh <harkishensingh@hotmail.com> * Aligned yacc code. Signed-off-by: Harkishen-Singh <harkishensingh@hotmail.com>	5 years ago
Julien Pivotto	d867491364	Human-friendly durations in PromQL (#7713 ) * Add support for user-friendly durations Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu>	5 years ago
Tobias Guggenmos	012161d90d	PromQL: Fix lexer error handling (#6958 ) * PromQL: Fix lexer error handling This fixes bugs in the handling of lexer errors that are only noticeable for users of the language server and caused https://github.com/prometheus-community/promql-langserver/issues/104 . Signed-off-by: Tobias Guggenmos <tobias.guggenmos@uni-ulm.de> * Add test for error position ranges Signed-off-by: Tobias Guggenmos <tobias.guggenmos@uni-ulm.de>	5 years ago
Julien Pivotto	5ddd1dcf0f	Fix panic when parsing varags (#6940 ) Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu>	5 years ago
Tobias Guggenmos	1dbd799354	PromQL: Fix regression tests (#6935 ) This PR fixes the regression tests for the issue fixed in #6931 . The reason for that is that all of the invalid queries that triggered the regression have become more or less valid syntax in #6933 (they might still fail typechecking). Signed-off-by: Tobias Guggenmos <tobias.guggenmos@uni-ulm.de>	5 years ago
Brian Brazil	44ad28dd5e	PromQL: Allow more keywords as metric names (#6933 ) * Allow more keywords as metric names * Add documentation about forbidden keywords Signed-off-by: Tobias Guggenmos <tobias.guggenmos@uni-ulm.de>	5 years ago
Brian Brazil	7164b58945	PromQL: Fix parser panic (#6931 ) Signed-off-by: Tobias Guggenmos <tobias.guggenmos@uni-ulm.de>	5 years ago
Tobias Guggenmos	6c00f2ffcb	Comment fixes Signed-off-by: Tobias Guggenmos <tguggenm@redhat.com>	5 years ago
Tobias Guggenmos	1360f9ff12	Fix all build errors in promql package Signed-off-by: Tobias Guggenmos <tguggenm@redhat.com>	5 years ago
Tobias Guggenmos	6b1b323558	Export sequenceValue Signed-off-by: Tobias Guggenmos <tguggenm@redhat.com>	5 years ago
Tobias Guggenmos	65f5b9827d	Rename package Signed-off-by: Tobias Guggenmos <tguggenm@redhat.com>	5 years ago
Tobias Guggenmos	e7c2716f55	Move files Signed-off-by: Tobias Guggenmos <tguggenm@redhat.com>	5 years ago
Julien Pivotto	cf42888e4d	Fix order of testutil.Equals (#6695 ) Equals takes the expected value as first parameter, and the actual value as second parameter. Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu>	5 years ago
Tobias Guggenmos	f5eed7ae0a	PromQL: Fix panic in parser (#6650 ) Fixes #6649. The crash is fixed here, was caused because some AST sanity checks were performed on the syntax tree while assembling it. In case of previous parsing errors this could lead to undefined behaviour. The fix is to move the checks to the typechecking phase, which runs only when a syntax tree was assembled without there being parsing errors. There are other places, where similiar checks are performed while assembling the syntax tree. It might be a good idea to move those to the typechecking phase, too. Should I do this in the same or a separate PR? Signed-off-by: Tobias Guggenmos <tguggenm@redhat.com>	6 years ago
Tobias Guggenmos	2ca25d1c96	PromQL: Don't panic on syntax errors (#6643 ) Signed-off-by: Tobias Guggenmos <tguggenm@redhat.com>	6 years ago
Tobias Guggenmos	d642570924	PromQL: Use PositionRange in parser errors (#6634 ) Signed-off-by: Tobias Guggenmos <tguggenm@redhat.com>	6 years ago
Tobias Guggenmos	0c8e9ef09e	PromQL: Add position metadata to the AST (#6615 ) Signed-off-by: Tobias Guggenmos <tguggenm@redhat.com> Co-authored-by: Julius Volz <julius.volz@gmail.com>	6 years ago
Tobias Guggenmos	64194f7d45	PromQL: AST: Make VectorSelector Children of MatrixSelector (#6590 ) Make Vector selectors children of Matrix Selectors Signed-off-by: Tobias Guggenmos <tguggenm@redhat.com>	6 years ago
Tobias Guggenmos	b18b6cb332	PromQL: Avoid lexer item copies and allocations (#6584 ) * PromQL: Avoid lexer item copies and allocations Signed-off-by: Tobias Guggenmos <tguggenm@redhat.com>	6 years ago
Tobias Guggenmos	d8bc24349c	PromQL: Fix unary operator precedence (#6579 ) * PromQL: Fix unary operator precedence Fixes #6575 Signed-off-by: Tobias Guggenmos <tguggenm@redhat.com>	6 years ago
Tobias Guggenmos	3d6cf1c289	PromQL: Make parser completely generated (#6548 ) Signed-off-by: Tobias Guggenmos <tguggenm@redhat.com>	6 years ago
Tobias Guggenmos	1e0cd28bf6	PromQL: Support trailing commas in grouping opts (#6480 ) * PromQL: Support trailing commas in grouping opts Fixes #6470 Signed-off-by: Tobias Guggenmos <tguggenm@redhat.com>	6 years ago
Tobias Guggenmos	db1258f2a5	PromQL: Refactor error message generation (#6481 ) * Add parser method to produce errors messages about unexpected items * PromQL: use parser.unexpected in generated parser Signed-off-by: Tobias Guggenmos <tguggenm@redhat.com>	6 years ago
Tobias Guggenmos	8cb4a48e2e	PromQL: Parse label sets using the generated parser (#6432 ) * Add grammar for label_sets * Parse label Sets using the generated parser * Allow trailing commas for label sets and selectors * Add test to trigger all possible error messages for label matchers Signed-off-by: Tobias Guggenmos <tguggenm@redhat.com>	6 years ago
Tobias Guggenmos	35c1f31721	PromQL: Use more standart format for error positions (#6433 ) The most common format (used by go, gcc and clang) for compiler error positions seems to be `filename:line:char:` or `line:char:` if the filename is unknown. This PR adapts the PromQL parser to use this convention. Signed-off-by: Tobias Guggenmos <tguggenm@redhat.com>	6 years ago
Tobias Guggenmos	3bb715031f	PromQL: Use generated parser to parse label matchers (#6410 ) Signed-off-by: Tobias Guggenmos <tguggenm@redhat.com>	6 years ago
Tobias Guggenmos	bbd92b85da	promql: Use capitalized names for item types (#6371 ) For yacc generated parsers there is the convention to capitalize the names of item types provided by the lexer, which makes it easy to distinct lexer tokens (capitalized) from nonterminal symbols (not capitalized) in language grammars. This convention is also followed by the (non generated) go compiler (see https://golang.org/pkg/go/token/#Token). Part of the parser rewrite described in #6256. Signed-off-by: Tobias Guggenmos <tguggenm@redhat.com>	6 years ago
Tobias Guggenmos	ac3932ea35	Improve PromQL parser performance by making it non-concurrent (#6356 ) Before this commit, the PromQL parser ran in two goroutines: * The lexer goroutine that splits the input into tokens and sent them over a channel to * the parser goroutine which produces the abstract syntax tree The Problem with this approach is that the parser spends more time on goroutine creation and syncronisation than on actual parsing. This commit removes that concurrency and replaces the channel by a slice based buffer. Benchmarks show that this makes the up to 7 times faster than before. Signed-off-by: Tobias Guggenmos <tguggenm@redhat.com>	6 years ago
Alex Dzyoba	e3882629ba	promql: Move tests to testutil (#6103 ) * promql: Move tests to testutil Signed-off-by: Alex Dzyoba <alex@dzyoba.com> * promql: Match error type via errors.As in tests Signed-off-by: Alex Dzyoba <alex@dzyoba.com> * promql: Remove unused `expectedList` func from lex_test.go Signed-off-by: Alex Dzyoba <alex@dzyoba.com>	6 years ago
Chris Marchbanks	529ccff07b	Remove all usages of stretchr/testify Signed-off-by: Chris Marchbanks <csmarchbanks@gmail.com>	6 years ago
Simon Pasquier	45506841e6	*: enable all default linters (#5504 ) Signed-off-by: Simon Pasquier <spasquie@redhat.com>	6 years ago
Tariq Ibrahim	8fdfa8abea	refine error handling in prometheus (#5388 ) i) Uses the more idiomatic Wrap and Wrapf methods for creating nested errors. ii) Fixes some incorrect usages of fmt.Errorf where the error messages don't have any formatting directives. iii) Does away with the use of fmt package for errors in favour of pkg/errors Signed-off-by: tariqibrahim <tariq181290@gmail.com>	6 years ago
Julius Volz	8155cc4992	Expose lexer item types (#5358 ) * Expose lexer item types We have generally agreed to expose AST types / values that are necessary to make sense of the AST outside of the promql package. Currently the `UnaryExpr`, `BinaryExpr`, and `AggregateExpr` AST nodes store the lexer item type to indicate the operator type, but since the individual item types aren't exposed, an external user of the package cannot determine the operator type. So this PR exposes them. Although not all item types are required to make sense of the AST (some are really only used in the lexer), I decided to expose them all here to be somewhat more consistent. Another option would be to not use lexer item types at all in AST nodes. The concrete motivation is my work on the PromQL->Flux transpiler, but this ought to be useful for other cases as well. Signed-off-by: Julius Volz <julius.volz@gmail.com> * Fix item type names in tests Signed-off-by: Julius Volz <julius.volz@gmail.com>	6 years ago
JoeWrightss	e158c53fa9	Fix some typos in comment (#5175 ) Signed-off-by: zhoulin xie <zhoulin.xie@daocloud.io>	6 years ago
Ganesh Vernekar	dbe55c1352	Subquery (#4831 ) Signed-off-by: Ganesh Vernekar <cs15btech11018@iith.ac.in>	7 years ago
Brian Brazil	8edaa8ad4d	Fix goroutine leak in lexer/parser. (#4858 ) When there was an error in the parser, the lexer goroutine was left running. Also make runtime panic test actually test things. Signed-off-by: Brian Brazil <brian.brazil@robustperception.io>	7 years ago
Ganesh Vernekar	73db8b8cea	[bugfix] Parse negative value in PromQL (#4564 ) * Parse negative value in PromQL * Enforce space between values Signed-off-by: Ganesh Vernekar <cs15btech11018@iith.ac.in>	7 years ago
Frederic Branczyk	b0b3e3dd74	promql: Remove old and unused alerting/reconding syntax Signed-off-by: Frederic Branczyk <fbranczyk@gmail.com>	7 years ago
Karsten Weiss	d79d573f71	Fix spelling mistakes found by codespell (#4065 ) Signed-off-by: Karsten Weiss <knweiss@gmail.com>	7 years ago
Warren Fernandes	d49a3df55b	Parser test cleanup (#3977 ) * parser test cleanup - Test against the exported package functions instead of the private functions. * Improves readability of TestParseSeries - Moves package function closer to parser function	7 years ago
Brian Brazil	99905f82a6	Remove keep_common modifier. See #3060	8 years ago
Brian Brazil	6f5d952132	Check for invalid utf-8 in lexer strings. This protects against invalid utf-8 sneaking in via label_replace.	8 years ago
Harsh Agarwal	16867c89a7	implement label_join issue 1147 (#2806 ) Replace OptionalArgs int with Variadic int.	8 years ago
Fabian Reinartz	71fe0c58a8	promql: misc fixes	9 years ago
Fabian Reinartz	fecf9532b9	*: fix misc compile errors	9 years ago
Fabian Reinartz	ac5d3bc05e	promql: scalar T/V and Point	9 years ago

1 2

71 Commits (8f75da3fd675dbde9a1caca82dc6643ae1d729d4)