prometheus

Commit Graph

Author	SHA1	Message	Date
Julius Volz	9f10c63cff	Fix remote read labelset corruption (#3456 ) The labelsets returned from remote read are mutated in higher levels (like seriesFilter.Labels()) and since the concreteSeriesSet didn't return a copy, the external mutation affected the labelset in the concreteSeries itself. This resulted in bizarre bugs where local and remote series would show with identical label sets in the UI, but not be deduplicated, since internally, a series might come to look like: {__name__="node_load5", instance="192.168.1.202:12090", job="node_exporter", node="odroid", node="odroid"} (note the repetition of the last label)	9 years ago
Tom Wilkie	2ae04d0e79	Add license header.	9 years ago
Tom Wilkie	ee011d906d	Port remote read server to 2.0.	9 years ago

Author

SHA1

Message

Date

Julius Volz

9f10c63cff

Fix remote read labelset corruption (#3456 )

The labelsets returned from remote read are mutated in higher levels
(like seriesFilter.Labels()) and since the concreteSeriesSet didn't
return a copy, the external mutation affected the labelset in the
concreteSeries itself. This resulted in bizarre bugs where local and
remote series would show with identical label sets in the UI, but not be
deduplicated, since internally, a series might come to look like:

{__name__="node_load5", instance="192.168.1.202:12090", job="node_exporter", node="odroid", node="odroid"}

(note the repetition of the last label)

9 years ago

Tom Wilkie

2ae04d0e79

Add license header.

9 years ago

Tom Wilkie

ee011d906d

Port remote read server to 2.0.

9 years ago

3 Commits (97a5fc8cbb28b8db98cbfa81eaebaff08c44cdc9)