92 Commits (97ba2fc39d332d0ff585ca3fbabd5dcdb3266daa)

Author	SHA1	Message	Date
György Krajcsovits	505ffd34ef	Fix lint error ... Some weird formatting issue in using comment suggestion Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>	2 years ago
George Krajcsovits	f45709e710	Update model/histogram/histogram_test.go ... Signed-off-by: George Krajcsovits <krajorama@users.noreply.github.com>	2 years ago
Jeanette Tan	5e4e93c316	fix lint ... Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>	2 years ago
Jeanette Tan	9adc1699c3	fix according to code review ... Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>	2 years ago
Oleksandr Redko	f10c3454e9	Enable perfsprint linter and fix up code ... Signed-off-by: Oleksandr Redko <oleksandr.red+github@gmail.com>	2 years ago
zenador	545a7e48f9	[nhcb branch] Enhance unit test framework for nhcb and warnings (#14009) ... * process custom values in histogram unit test framework * check for warnings when evaluating in unit test framework * add test cases for custom buckets in test framework Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>	2 years ago
zenador	81862aabd7	[nhcb branch] Add basic unit tests for native histograms with custom buckets converted from classic histograms (#13794) ... * modify unit test framework to automatically generate native histograms with custom buckets from classic histogram series * add very basic tests for classic histogram converted into native histogram with custom bounds * fix histogram_quantile for native histograms with custom buckets * make loading with nhcb explicit * evaluate native histograms with custom buckets on queries with explicit keyword * use regex replacer * use temp histogram struct for automatically loading converted nhcb Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com> Signed-off-by: George Krajcsovits <krajorama@users.noreply.github.com>	2 years ago
zenador	4acbb7dea6	Add custom buckets to native histogram chunks encoding (#13706) ... * add custom bounds to chunks encoding * change custom buckets schema number * rename custom bounds to custom values Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>	2 years ago
machine424	f477e0539a	Move from golang.org/x/exp/slices into slices now that we only support Go >= 1.21 ... Prevent adding back golang.org/x/exp/slices. Signed-off-by: machine424 <ayoubmrini424@gmail.com>	2 years ago
György Krajcsovits	5d0a0a7542	Add custom buckets to native histogram model (#13592) ... * add custom buckets to native histogram model * simple copy for custom bounds * return errors for unsupported add/sub operations * add test cases for string and update appendhistogram in scrape to account for new schema * check fields which are supposed to be unused but may affect results in equals * allow appending custom buckets histograms regardless of max schema Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>	2 years ago
tyltr	084420b837	chore:fix typo ... Signed-off-by: tyltr <tylitianrui@126.com>	2 years ago
Filip Petkovski	583f3e587c	Optimize histogram iterators (#13340) ... Optimize histogram iterators Histogram iterators allocate new objects in the AtHistogram and AtFloatHistogram methods, which makes calculating rates over long ranges expensive. In #13215 we allowed an existing object to be reused when converting an integer histogram to a float histogram. This commit follows the same idea and allows injecting an existing object in the AtHistogram and AtFloatHistogram methods. When the injected value is nil, iterators allocate new histograms, otherwise they populate and return the injected object. The commit also adds a CopyTo method to Histogram and FloatHistogram which is used in the BufferedIterator to overwrite items in the ring instead of making new copies. Note that a specialized HPoint pool is needed for all of this to work (`matrixSelectorHPool`). --------- Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com> Co-authored-by: George Krajcsovits <krajorama@users.noreply.github.com>	2 years ago
zenador	a3ddfbd1ee	Add warnings for histogramRate applied with isCounter not matching counter/gauge histogram (#13392) ... Add warnings for histogramRate applied with isCounter not matching counter/gauge histogram --------- Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>	2 years ago
tyltr	1fa131ee03	fix slice copy in 1.20 (#13389) ... The slices package is added to the standard library in Go 1.21; we need to import from the exp area to maintain compatibility with Go 1.20. Signed-off-by: tyltr <tylitianrui@126.com>	2 years ago
Filip Petkovski	9008271df5	Use cap to determine slice capacity ... Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com>	2 years ago
Filip Petkovski	10a82f87fd	Enable reusing memory when converting between histogram types ... The 'ToFloat' method on integer histograms currently allocates new memory each time it is called. This commit adds an optional *FloatHistogram parameter that can be used to reuse span and bucket slices. It is up to the caller to make sure the input float histogram is not used anymore after the call. Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com>	2 years ago
Linas Medziunas	bd895baefc	FloatHistogram.Add/Sub: handle any schema change ... Signed-off-by: Linas Medziunas <linas.medziunas@gmail.com>	2 years ago
Matthieu MOREL	9c4782f1cc	golangci-lint: enable testifylint linter (#13254) ... Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>	2 years ago
Arve Knudsen	237bfea46b	`chunks.Reader`: Fix typo in ChunkOrIterable doc string. ... Also fix comment typo in `FloatHistogram.Sub`. Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>	2 years ago
Oleksandr Redko	2a75604f8e	Enable default revive rules (#13068) ... Signed-off-by: Oleksandr Redko <Oleksandr_Redko@epam.com>	2 years ago
Linas Medziunas	048886ae8a	Histograms: optimize floatBucketIterator for common case ... Signed-off-by: Linas Medziunas <linas.medziunas@gmail.com>	2 years ago
Linas Medziunas	49613823f8	Reuse slices in [Float]Histogram.ReduceResolution ... Signed-off-by: Linas Medziunas <linas.medziunas@gmail.com>	2 years ago
Linas Medziunas	f99ecc376e	Fix FloatHistogram.Add/Sub mutating its argument ... Signed-off-by: Linas Medziunas <linas.medziunas@gmail.com>	2 years ago
Linas Medziunas	ea1862aab4	Explicit schema check in [Float]Histogram.ReduceResolution ... Signed-off-by: Linas Medziunas <linas.medziunas@gmail.com>	2 years ago
Ziqi Zhao	e250f09b5d	change origin schema in `ReduceResolution` method of histogram and float histogram (#13116) ... * change origin schema in ReduceResolution method of histogram and float histogram Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com> --------- Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com>	2 years ago
Ziqi Zhao	ab2a7bb74f	add generic shrink function (#13001) ... Add `ReduceResolution` method to `Histogram` and `FloatHistogram` This takes the original `mergeToSchema` function and turns it into a more generic `reduceResolution` function, which is the building block for the new methods. The methods will help with addressing #12864. --------- Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com>	2 years ago
Matthieu MOREL	05fba53e57	web : use Go standard package ... Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>	2 years ago
Linas Medziunas	ebed7d0612	Change Validate to be a method on histogram structs ... Signed-off-by: Linas Medziunas <linas.medziunas@gmail.com>	2 years ago
Linas Medziunas	1f8aea11d6	Move histogram validation code to model/histogram ... Signed-off-by: Linas Medziunas <linas.medziunas@gmail.com>	2 years ago
Oleksandr Redko	fa90ca46e5	ci(lint): enable godot; append dot at the end of comments ... Signed-off-by: Oleksandr Redko <Oleksandr_Redko@epam.com>	2 years ago
Marc Tuduri	1ce066e51c	More periods ... Signed-off-by: Marc Tuduri <marctc@protonmail.com>	2 years ago
Marc Tuduri	af7c31ee10	PR feedback ... Signed-off-by: Marc Tuduri <marctc@protonmail.com>	2 years ago
Marc Tuduri	8fededf6ad	promql(histograms): Change sample total calculation for histograms ... Signed-off-by: Marc Tuduri <marctc@protonmail.com>	2 years ago
Linas Medziunas	62bbb81e29	Mention bucket values in the comment ... Signed-off-by: Linas Medziunas <linas.medziunas@gmail.com>	2 years ago
Linas Medziunas	ec823d9daf	Update comments, bitwise comparison of float buckets ... Signed-off-by: Linas Medziunas <linas.medziunas@gmail.com>	2 years ago
Linas Medziunas	c5c5c569fa	Histogram performance: optimize floatBucketIterator ... Signed-off-by: Linas Medziunas <linas.medziunas@gmail.com>	2 years ago
Linas Medziunas	3c047a3518	Expand docs comments ... Signed-off-by: Linas Medziunas <linas.medziunas@gmail.com>	2 years ago
Linas Medziunas	dfb6292600	Compare FloatHistogram.[Zero]Count float values as binary ... Signed-off-by: Linas Medziunas <linas.medziunas@gmail.com>	2 years ago
Linas Medziunas	cbd01fc296	Fix NaN sum check in [Float]Histogram.Equals method ... Signed-off-by: Linas Medziunas <linas.medziunas@gmail.com>	2 years ago
Gregor Zeitlinger	f01718262a	Unit tests for native histograms (#12668) ... promql: Extend testing framework to support native histograms This includes both the internal testing framework as well as the rules unit test feature of promtool. This also adds a bunch of basic tests. Many of the code level tests can now be converted to tests within the framework, and more tests can be added easily. --------- Signed-off-by: Harold Dost <h.dost@criteo.com> Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com> Signed-off-by: Stephen Lang <stephen.lang@grafana.com> Co-authored-by: Harold Dost <h.dost@criteo.com> Co-authored-by: Stephen Lang <stephen.lang@grafana.com> Co-authored-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>	2 years ago
zenador	54aaa2bd7e	Add `histogram_stdvar` and `histogram_stddev` functions (#12614) ... * Add new function: histogram_stdvar and histogram_stddev Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>	2 years ago
Ziqi Zhao	de172049ab	fix lint error ... Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com>	2 years ago
Ziqi Zhao	d3633d4e76	Update model/histogram/float_histogram.go ... Co-authored-by: Björn Rabenstein <github@rabenste.in> Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com>	2 years ago
Ziqi Zhao	893f97556f	use switch instead of if-else to fix lint error ... Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com>	2 years ago
Ziqi Zhao	788061e509	remove unused addBucket function ... Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com>	2 years ago
Ziqi Zhao	eab3c93e80	make code ready for review ... Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com>	2 years ago
Ziqi Zhao	4787c879bc	add more elaborate benchmark test ... Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com>	2 years ago
Ziqi Zhao	bf880a6e77	enhance floathistogram add and sub method ... Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com>	2 years ago
Ziqi Zhao	ed1b307bca	enhance FloatHistogram CopyToSchema method (#12596) ... histogram: Improve performance of FloatHistogram.CopyToSchema Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com> --------- Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com> Co-authored-by: Björn Rabenstein <github@rabenste.in>	2 years ago
beorn7	9aadd54786	histogram: Fix bounds of buckets returned by floatBucketIterator ... The bounds weren't really used so far, so no actual bug in the code so far. But it's obviously confusing if the bounds returned by a floatBucketIterator with a target schema different from the original schema are wrong. Signed-off-by: beorn7 <beorn@grafana.com>	3 years ago