prometheus

Commit Graph

Author	SHA1	Message	Date
Matthieu MOREL	9c4782f1cc	golangci-lint: enable testifylint linter (#13254 ) Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>	2 years ago
Linas Medziunas	49613823f8	Reuse slices in [Float]Histogram.ReduceResolution Signed-off-by: Linas Medziunas <linas.medziunas@gmail.com>	2 years ago
Linas Medziunas	f99ecc376e	Fix FloatHistogram.Add/Sub mutating its argument Signed-off-by: Linas Medziunas <linas.medziunas@gmail.com>	2 years ago
Ziqi Zhao	e250f09b5d	change origin schema in `ReduceResolution` method of histogram and float histogram (#13116 ) * change origin schema in ReduceResolution method of histogram and float histogram Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com> --------- Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com>	2 years ago
Marc Tuduri	1ce066e51c	More periods Signed-off-by: Marc Tuduri <marctc@protonmail.com>	2 years ago
Marc Tuduri	af7c31ee10	PR feedback Signed-off-by: Marc Tuduri <marctc@protonmail.com>	2 years ago
Marc Tuduri	8fededf6ad	promql(histograms): Change sample total calculation for histograms Signed-off-by: Marc Tuduri <marctc@protonmail.com>	2 years ago
Linas Medziunas	ec823d9daf	Update comments, bitwise comparison of float buckets Signed-off-by: Linas Medziunas <linas.medziunas@gmail.com>	2 years ago
Linas Medziunas	c5c5c569fa	Histogram performance: optimize floatBucketIterator Signed-off-by: Linas Medziunas <linas.medziunas@gmail.com>	2 years ago
Linas Medziunas	dfb6292600	Compare FloatHistogram.[Zero]Count float values as binary Signed-off-by: Linas Medziunas <linas.medziunas@gmail.com>	2 years ago
Gregor Zeitlinger	f01718262a	Unit tests for native histograms (#12668 ) promql: Extend testing framework to support native histograms This includes both the internal testing framework as well as the rules unit test feature of promtool. This also adds a bunch of basic tests. Many of the code level tests can now be converted to tests within the framework, and more tests can be added easily. --------- Signed-off-by: Harold Dost <h.dost@criteo.com> Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com> Signed-off-by: Stephen Lang <stephen.lang@grafana.com> Co-authored-by: Harold Dost <h.dost@criteo.com> Co-authored-by: Stephen Lang <stephen.lang@grafana.com> Co-authored-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>	2 years ago
Ziqi Zhao	eab3c93e80	make code ready for review Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com>	2 years ago
Ziqi Zhao	4787c879bc	add more elaborate benchmark test Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com>	2 years ago
Ziqi Zhao	bf880a6e77	enhance floathistogram add and sub method Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com>	2 years ago
beorn7	9aadd54786	histogram: Fix bounds of buckets returned by floatBucketIterator The bounds weren't really used so far, so no actual bug in the code so far. But it's obviously confusing if the bounds returned by a floatBucketIterator with a target schema different from the original schema are wrong. Signed-off-by: beorn7 <beorn@grafana.com>	2 years ago
Carrie Edwards	a462f7fa21	Add function for iterating through all buckets in reverse to find max bucket Signed-off-by: Carrie Edwards <edwrdscarrie@gmail.com>	2 years ago
zenador	191bf9055b	Handle more arithmetic operators for native histograms (#12262 ) Handle more arithmetic operators and aggregators for native histograms This includes operators for multiplication (formerly known as scaling), division, and subtraction. Plus aggregations for average and the avg_over_time function. Stdvar and stddev will (for now) ignore histograms properly (rather than counting them but adding a 0 for them). Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>	3 years ago
Björn Rabenstein	dccfb9db4e	histogram: Remove code replication via generics (#11361 ) * histogram: Simplify iterators We don't really need currLower and currUpper and can calculate it when needed (as already done for the floatBucketIterator). The calculation is cheap, while keeping those extra variables around costs RAM (potentially a lot with many iterators). * histogram: Convert Bucket/FloatBucket to one generic type * histogram: Move some bucket iterator code into generic base iterator * histogram: Remove cumulative iterator for FloatHistogram We added it in the past for completeness (Histogram has one), but it has never been used. Plus, even the cumulative iterator for Histogram is only there for test reasons. We can always add it back, and then maybe even using generics. Signed-off-by: beorn7 <beorn@grafana.com>	3 years ago
beorn7	a7c519930e	histograms: Add Compact method to the normal integer Histogram And use the new method to call to compact Histograms during parsing. This happens for both `Histogram` and `FloatHistogram`. In this way, if targets decide to optimize the exposition size by merging spans with empty buckets in between, we still get a normalized results. It will also normalize away any valid but weird representations like empty spans, spans with offset zero, and empty buckets at the start or end of a span. The implementation seemed easy at first as it just turns the `compactBuckets` helper into a generic function (which now got its own file). However, the integer Histograms have delta buckets instead of absolute buckets, which had to be treated specially in the generic `compactBuckets` function. To make sure it works, I have added plenty of explicit tests for `Histogram` in addition to the `FloatHistogram` tests. I have also updated the doc comment for the `Compact` method. Based on the insights now expressed in the doc comment, compacting with a maxEmptyBuckets > 0 is rarely useful. Therefore, this commit also sets the value to 0 in the two cases we were using 3 so far. We might still want to reconsider, so I don't want to remove the maxEmptyBuckets parameter right now. Signed-off-by: beorn7 <beorn@grafana.com>	3 years ago
beorn7	2d233cf95e	Histogram: Fix allFloatBucketIterator If the zero threshold overlaps with the highest negative bucket and/or the lowest positive bucket, its upper or lower boundary, respectively, has to be adjusted. In valid histograms, only ever the highest negative bucket and/or the lowest positive bucket may overlap with the zero bucket. This is assumed in this code to simplify the checks. Signed-off-by: beorn7 <beorn@grafana.com>	4 years ago
beorn7	56db51c826	Histgram: Fix Compact for spans of only empty buckets Signed-off-by: beorn7 <beorn@grafana.com>	4 years ago
beorn7	15583af9bb	Histogram: Fix crash when compacting only empty buckets Signed-off-by: beorn7 <beorn@grafana.com>	4 years ago
beorn7	9fbcf14e5c	histogram: Handle changes of the ZeroThreshold and the Schema Signed-off-by: beorn7 <beorn@grafana.com>	4 years ago
beorn7	3b4d6c3fdb	model: Implement FloatHistogram.Compact Signed-off-by: beorn7 <beorn@grafana.com>	4 years ago
beorn7	e7592fe353	sparsehistogram: Address two TODOs Signed-off-by: beorn7 <beorn@grafana.com>	4 years ago
beorn7	a6acdfe346	histograms: Doc comment and naming improvements Signed-off-by: beorn7 <beorn@grafana.com>	4 years ago
Ganesh Vernekar	4a43349aca	`histogram_quantile` for sparse histograms (#9935 ) * MergeFloatBucketIterator for []FloatBucketIterator Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com> * histogram_quantile for histograms Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com> * Fix histogram_quantile Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com> * Unit test and enhancements Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com> * Iterators to iterate buckets in reverse and all buckets together including zero bucket Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com> * Consider all buckets for histogram_quantile and fix the implementation Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com> * Remove unneeded code Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com> * Fix lint Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>	4 years ago
Björn Rabenstein	0e1b9dd308	Promql: Initial rate implementation for sparse histograms (#9926 ) Signed-off-by: beorn7 <beorn@grafana.com>	4 years ago

27 Commits (9c4782f1cc34f85f07daaaed14af2e7ad1ff56a0)