prometheus

Commit Graph

Author	SHA1	Message	Date
co63oc	0e4e5a71bd	Fix typos (#16076 ) Signed-off-by: co63oc <co63oc@users.noreply.github.com>	1 year ago
Charles Korn	8356990709	promql: fix double quoting in invalid label name error from `count_values` (#16054 ) promql: fix double quoting in invalid label name error from `count_values` --------- Signed-off-by: Charles Korn <charles.korn@grafana.com> Signed-off-by: Charles Korn <charleskorn@users.noreply.github.com> Co-authored-by: Björn Rabenstein <github@rabenste.in>	1 year ago
Matthieu MOREL	c7d4b53ec1	chore: enable unused-parameter from revive Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>	1 year ago
Charles Korn	0964b6e584	promql: emit correct annotation in `quantile_over_time` when run over a range with histograms and floats Signed-off-by: Charles Korn <charles.korn@grafana.com>	1 year ago
beorn7	14bb63c467	promql: Fix counter reset detection in subqueries with histograms Signed-off-by: beorn7 <beorn@grafana.com>	1 year ago
beorn7	6518941d73	promql: Expose problem with histogram counter resets in subquery Signed-off-by: beorn7 <beorn@grafana.com>	1 year ago
Matthieu MOREL	b472ce7010	chore: enable early-return from revive Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>	1 year ago
Neeraj Gartia	20371118b6	[FIX] PromQL: Ignore histograms in `scalar`, `sort` and `sort_desc` functions (#15964 ) PromQL: Ignore histograms in scalar, sort and sort_desc functions --------- Signed-off-by: Neeraj Gartia <neerajgartia211002@gmail.com>	1 year ago
Joshua Hesketh	5a5fdea7ad	Fix duplicate output vector if delayed name removal is disabled (#15975 ) Fix duplicate output vector if delayed name removal is disabled This error is emitted in cleanupMetricLabels, but is skipped if enableDelayedNameRemoval is false. This makes it consistent with label_replace Signed-off-by: Joshua Hesketh <josh@nitrotech.org> --------- Signed-off-by: Joshua Hesketh <josh@nitrotech.org> Signed-off-by: Björn Rabenstein <github@rabenste.in> Co-authored-by: Björn Rabenstein <github@rabenste.in>	1 year ago
Joshua Hesketh	5be3197701	Update the test to invalid utf-8 "invalid-label-name" is valid in utf-8 mode Signed-off-by: Joshua Hesketh <josh@nitrotech.org>	1 year ago
Joshua Hesketh	e4037b3ec3	Allow UTF-8 labels in label_replace This makes it consistent with label_join. Signed-off-by: Joshua Hesketh <josh@nitrotech.org>	1 year ago
Charles Korn	69ce0c24db	Fix issue Signed-off-by: Charles Korn <charles.korn@grafana.com>	1 year ago
Charles Korn	2fc6ba1c94	Expand `TestInstantQueryWithRangeVectorSelector` to include histograms Signed-off-by: Charles Korn <charles.korn@grafana.com>	1 year ago
Charles Korn	026d0198d5	Add unit tests Signed-off-by: Charles Korn <charles.korn@grafana.com>	1 year ago
Neeraj Gartia	8be416a67c	[FIX] PromQL: Updates annotation for bin op between incompatible histograms (#15895 ) PromQL: Updates annotation for bin op between incompatible histograms --------- Signed-off-by: Neeraj Gartia <neerajgartia211002@gmail.com>	1 year ago
Neeraj Gartia	130cd024e0	[FEATURE] PromQL: Implements `idelta` and `irate` with histograms (#15853 ) Add native histogram support to idelta and irate functions --------- Signed-off-by: Neeraj Gartia <neerajgartia211002@gmail.com>	1 year ago
beorn7	9f6c1d9cd3	promqltest: Small formatting improvement for native histograms A `HistogramTestExpression` was missed in one case, which made the formatting weird in case a histogram got unexpectedly returned. Signed-off-by: beorn7 <beorn@grafana.com>	1 year ago
beorn7	2581c7d057	promql: fix rate calculation with a counter reset after the 1st histogram If a rate (or increase) is calculated on native histograms, and there is a counter reset between the 1st and 2nd histogram, we never have to touch the 1st histogram, so it doesn't even matter if it has an incompatible bucket layout. So we should not error out in that case. This simply nulls out the 1st histogram in that case. Signed-off-by: beorn7 <beorn@grafana.com>	1 year ago
Neeraj Gartia	b9fcc81695	adds tests for timestamp() Signed-off-by: Neeraj Gartia <neerajgartia211002@gmail.com>	1 year ago
Neeraj Gartia	21afc0beb4	adds tests for sum_over_time and avg_over_time Signed-off-by: Neeraj Gartia <neerajgartia211002@gmail.com>	1 year ago
György Krajcsovits	9097f8f4e7	test(promql): some functions silently ignore native histograms Functions that silently ignore native histograms, not covered by existing tests: abs(), ceil(), clamp(), clamp_min(), clamp_max(), floor(), round(). Ref: https://github.com/prometheus/prometheus/pull/15845 Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>	1 year ago
Linas Medziunas	940016e002	promql: use histogram stats decoder for histogram_avg Signed-off-by: Linas Medziunas <linas.medziunas@gmail.com>	1 year ago
Joshua Hesketh	665d1ba0cc	Ensure metric name is present on histogram_quantile annotations (#15828 ) Ensure metric name is present on histogram_quantile annotations Previously the series __name__ label was dropped before the annotation was emitted causing the annotation message to have a blank value. This fix also allows delayed name removal for classic histograms. This also adds a test for malformed le label This annotation could be split into two to be clearer for the user (one for missing, and one for malformed). This is outside of the scope of this change. Fixes: #15411 --------- Signed-off-by: Joshua Hesketh <josh@nitrotech.org> Signed-off-by: Björn Rabenstein <github@rabenste.in> Co-authored-by: Björn Rabenstein <github@rabenste.in>	1 year ago
Mikel Olasagasti Uranga	9258e40589	parser: fix non-constant format string call (#15835 ) Go 1.24 enhanced vet's printf analyzer to report calls of the form fmt.Printf(s), where s is a non-constant format string, with no other arguments. This change makes parser tests to fail. Signed-off-by: Mikel Olasagasti Uranga <mikel@olasagasti.info>	1 year ago
Fiona Liao	f46b984dd1	Add additional incompatible nhcb schemas tests for functions and comparison operators (#15813 ) promql: Add additional incompatible nhcb schemas tests for functions and comparison operators * Add agg_over_time tests for nhcb with incompatible schemas * Add more function and comparison operator tests --------- Signed-off-by: Fiona Liao <fiona.liao@grafana.com>	1 year ago
Owen Williams	47563d942e	parser: fix misleading error message in grouping processing Signed-off-by: Owen Williams <owen.williams@grafana.com>	1 year ago
Arve Knudsen	f030894c2c	Fix issues raised by staticcheck (#15722 ) Fix issues raised by staticcheck We are not enabling staticcheck explicitly, though, because it has too many false positives. --------- Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>	1 year ago
Neeraj Gartia	b3e30d52ce	[BUGFIX] PromQL: Fix `<aggr_over_time>` functions with histograms (#15711 ) fix aggr_over_time with histograms Signed-off-by: Neeraj Gartia <neerajgartia211002@gmail.com> --------- Signed-off-by: Neeraj Gartia <neerajgartia211002@gmail.com>	1 year ago
Fiona Liao	9d6f88cb73	Add additional tests for operators over incompatible nhcb (#15787 ) * Add additional tests for operators over incompatible nhcb Signed-off-by: Fiona Liao <fiona.liao@grafana.com>	1 year ago
beorn7	d9a80a91e3	docs: Document eval_warn and eval_info This also improves the documentation in the following ways: - Clarifies that `eval` requires no annotations. - Clarifies that `eval_ordered` ignores annotations. - Clarifies that `eval_ordered` does not work with matrix returns (which could very well be created by instant queries). - Clarifies that there are more `eval` commands than just `eval`. - Improves wording for `eval_ordered`. - Replaces `...` by the typographical correct `…`. - Fixes a numerical error in an example. Signed-off-by: beorn7 <beorn@grafana.com>	1 year ago
beorn7	7687661453	promqltest: make eval_ordered ignore annotations Besides making eval_ordered ignore annotations, this does the following: - Adds a test to verify that eval_ordered indeed ignores an info annotations now, while eval complains about it, eval_info recognizes it and, eval_warn flags the missing of the warn annotation. - Refactors the annotation check into its own method. - Moves closing of the query to the appropriate place where it wasn't so far. Signed-off-by: beorn7 <beorn@grafana.com>	1 year ago
machine424	9823a93c42	fix(main.go): avoid closing the query engine until it is guaranteed to no longer be in use. partially reverts https://github.com/prometheus/prometheus/pull/14064 fixes https://github.com/prometheus/prometheus/issues/15232 supersedes https://github.com/prometheus/prometheus/pull/15533 reusing Engine.Close() outside of tests will require more consideration. Signed-off-by: machine424 <ayoubmrini424@gmail.com>	1 year ago
beorn7	f7373a1f91	PromQL: improve some test comments This amends #15686. Signed-off-by: beorn7 <beorn@grafana.com>	1 year ago
Neeraj Gartia	8d5236f927	PromQL: Adds tests for `delta` with histograms (#15674 ) PromQL: Adds tests for delta with histograms Signed-off-by: Neeraj Gartia <neerajgartia211002@gmail.com> -------- Signed-off-by: Neeraj Gartia <neerajgartia211002@gmail.com>	1 year ago
Neeraj Gartia	0e99ca3e8c	[BUGFIX] PromQL: Fix `deriv`, `predict_linear` and `double_exponential_smoothing` with histograms (#15686 ) PromQL: Fix deriv, predict_linear and double_exponential_smoothing with histograms Signed-off-by: Neeraj Gartia <neerajgartia211002@gmail.com> --------- Signed-off-by: Neeraj Gartia <neerajgartia211002@gmail.com>	1 year ago
Joel Beckmeyer	41dabfb464	fix topk/bottomk with numbers greater than int maxsize on 32-bit Signed-off-by: Joel Beckmeyer <joel@beckmeyer.us>	1 year ago
Neeraj Gartia	9009724c5b	[BUGFIX] PromQL: Adds test for `absent`, `absent_over_time` and `deriv` func with histograms (#15667 ) Add test for `absent`, `absent_over_time` and `deriv` func with histograms Signed-off-by: Neeraj Gartia <neerajgartia211002@gmail.com> --------- Signed-off-by: Neeraj Gartia <neerajgartia211002@gmail.com>	1 year ago
beorn7	ebfa1dd822	promql: Purge Holt-Winters from a doc comment `funcDoubleExponentialSmoothing` did not get its doc comment updated when we renamed it from the confusing `funcHoltWinters`. Signed-off-by: beorn7 <beorn@grafana.com>	2 years ago
Achille Roussel	b0e7de154e	promqltest: allow running tests with custom storage implementation Signed-off-by: Achille Roussel <achille.roussel@gmail.com>	2 years ago
Owen Williams	8d4bcd2c77	promql: Fix various UTF-8 bugs related to quoting Fixes UTF-8 aggregator label list items getting mutated with quote marks when String-ified. Fixes quoted metric names not supported in metric declarations. Fixes UTF-8 label names not being quoted when String-ified. Fixes https://github.com/prometheus/prometheus/issues/15470 Fixes https://github.com/prometheus/prometheus/issues/15528 Signed-off-by: Owen Williams <owen.williams@grafana.com> Co-authored-by: Bryan Boreham <bjboreham@gmail.com>	2 years ago
Neeraj Gartia	7fd3b13bd2	[TEST] PromQL: Adds tests with histograms for simple functions (#15488 ) adds tests with histograms for simple functions Signed-off-by: Neeraj Gartia <neerajgartia211002@gmail.com> --------- Signed-off-by: Neeraj Gartia <neerajgartia211002@gmail.com>	2 years ago
Neeraj Gartia	4aeed2c4b1	fix resets function for histograms Signed-off-by: Neeraj Gartia <neerajgartia211002@gmail.com>	2 years ago
TJ Hoplock	53eb1fe71f	test: make promql engine_test use files to exercise query logger Signed-off-by: TJ Hoplock <t.hoplock@gmail.com>	2 years ago
TJ Hoplock	4d54c304f8	ref: make query logger more efficient by building list of attrs Addresses PR feedback to make query logger more efficient. Signed-off-by: TJ Hoplock <t.hoplock@gmail.com>	2 years ago
TJ Hoplock	e0104a6b7e	ref: JSONFileLogger slog handler, add scrape.FailureLogger interface Improves upon #15434, better resolves #15433. This commit introduces a few changes to ensure safer handling of the JSONFileLogger: - the JSONFileLogger struct now implements the slog.Handler interface, so it can directly be used to create slog Loggers. This pattern more closely aligns with upstream slog usage (which is generally based around handlers), as well as making it clear that devs are creating a whole new logger when interacting with it (vs silently modifying internal configs like it did previously). - updates the `promql.QueryLogger` interface to be a union of the methods of both the `io.Closer` interface and the `slog.Handler` interface. This allows for plugging in/using slog-compatible loggers other than the JSONFileLogger, if desired (ie, for downstream projects). - introduces new `scrape.FailureLogger` interface; just like `promql.QueryLogger`, it is a union of `io.Closer` and `slog.Handler` interfaces. Similar logic applies to reasoning. - updates tests where needed; have the `FakeQueryLogger` from promql's engine_test implement the `slog.Handler`, improve JSONFileLogger test suite, etc. Signed-off-by: TJ Hoplock <t.hoplock@gmail.com>	2 years ago
Neeraj Gartia	0de340c1b4	ignore histogram in dateWrapper Signed-off-by: Neeraj Gartia <neerajgartia211002@gmail.com>	2 years ago
Neeraj Gartia	36e0897f0f	[BUGFIX] PromQL: Fix behaviour of `changes()` for mix of histograms and floats (#15469 ) PromQL: Fix behaviour of changes() for mix of histograms and floats --------- Signed-off-by: Neeraj Gartia <neerajgartia211002@gmail.com>	2 years ago
Joshua Hesketh	8e3301eb44	Export quantile functions (#15190 ) Export quantile functions For use in Mimir's query engine, it would be helpful if these functions were exported. Co-authored-by: Björn Rabenstein <github@rabenste.in> Signed-off-by: Joshua Hesketh <josh@hesketh.net.au> --------- Signed-off-by: Joshua Hesketh <josh@nitrotech.org> Signed-off-by: Joshua Hesketh <josh@hesketh.net.au> Co-authored-by: Björn Rabenstein <github@rabenste.in>	2 years ago
beorn7	a44c449155	promql: Add NaN tests for avg and avg_over_time Signed-off-by: beorn7 <beorn@grafana.com>	2 years ago
Neeraj Gartia	38bb6ece25	[BUGFIX] PromQL: Fix behaviour of some aggregations with histograms (#15432 ) promql: fix some aggregations for histograms This PR fixes the behaviour of `topk`,`bottomk`, `limitk` and `limit_ratio` with histograms. The fixed behaviour are as follows: - For `topk` and `bottomk` histograms are ignored and add info annotations added. - For `limitk` and `limit_ratio` histograms are included in the results(if applicable). Signed-off-by: Neeraj Gartia <neerajgartia211002@gmail.com>	2 years ago

1 2 3 4 5 ...

1233 Commits (aee78bdb319fb8c99d294bfe1ddec00bac99b511)