6 Commits (df94ecebab21a58107938d35d67cc624486c1f83)

Author	SHA1	Message	Date
György Krajcsovits	df94ecebab	fix(promql): histogram_count inconsistent ... The problem is in the counter reset detection. The code that loads the samples is matrixIterSlice which uses the typed Buffer iterator, which will preload the integer histogram samples, however the last sample is always(!) loaded as a float histogram sample in matrixIterSlice and the optimized iterator fails to detect counter resets in that case. Also the iterator does not reset lastH, lastFH properly. Ref: https://github.com/prometheus/prometheus/issues/16681 Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>	4 weeks ago
Matthieu MOREL	c7d4b53ec1	chore: enable unused-parameter from revive ... Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>	4 months ago
Arve Knudsen	89bbb885e5	Upgrade to golangci-lint v1.62.0 (#15424) ... Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>	7 months ago
Filip Petkovski	02d9d874a2	Add more test cases ... Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com>	11 months ago
Filip Petkovski	6100e756a8	Ignore stale histograms for counter reset detection ... The histogram stats decoder keeps track of the last seen histogram sample in order to properly detect counter resets. We are seeing an issue where a histogram with UnknownResetHint gets treated as a counter reset when it follows a stale histogram sample. I believe that this is incorrect since stale samples should be completely ignored in PromQL. As a result, they should not be stored in the histogram stats iterator and the counter reset detection needs to be done against the last non-stale sample. Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com>	11 months ago
Filip Petkovski	2cd97c61e0	Add more test cases ... Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com>	11 months ago
Filip Petkovski	be7a4c9b83	Ignore stale histograms for counter reset detection ... The histogram stats decoder keeps track of the last seen histogram sample in order to properly detect counter resets. We are seeing an issue where a histogram with UnknownResetHint gets treated as a counter reset when it follows a stale histogram sample. I believe that this is incorrect since stale samples should be completely ignored in PromQL. As a result, they should not be stored in the histogram stats iterator and the counter reset detection needs to be done against the last non-stale sample. Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com>	11 months ago
Filip Petkovski	6e68046c25	Implement histogram statistics decoder (#14097) ... Implement histogram statistics decoder This commit speeds up histogram_count and histogram_sum functions on native histograms. The idea is to have separate decoders which can be used by the engine to only read count/sum values from histogram objects. This should help with reducing allocations when decoding histograms, as well as with speeding up aggregations like sum since they will be done on floats and not on histogram objects. Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com> --------- Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com> Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>	1 year ago