The Prometheus monitoring system and time series database.

prometheushacktoberfestmetricsmonitoringalertinggraphingtime-series

You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Björn Rabenstein b8d19543b8 Add histogram validation in remote-read and during reducing resolution (#17561) ... ReduceResolution is currently called before validation during ingestion. This will cause a panic if there are not enough buckets in the histogram. If there are too many buckets, the spurious buckets are ignored, and therefore the error in the input histogram is masked. Furthermore, invalid negative offsets might cause problems, too. Therefore, we need to do some minimal validation in reduceResolution. Fortunately, it is easy and shouldn't slow things down. Sadly, it requires to return errors, which triggers a bunch of code changes. Even here is a bright side, we can get rud of a few panics. (Remember: Don't panic!) In different news, we haven't done a full validation of histograms read via remote-read. This is not so much a security concern (as you can throw off Prometheus easily by feeding it bogus data via remote-read) but more that remote-read sources might be makeshift and could accidentally create invalid histograms. We really don't want to panic in that case. So this commit does not only add a check of the spans and buckets as needed for resolution reduction but also a full validation during remote-read. Signed-off-by: beorn7 <beorn@grafana.com>		2 months ago
..
convert.go	fix(histogram): handling +Inf bucket count and metric label	2 months ago
convert_test.go	fix(histogram): handling +Inf bucket count and metric label	2 months ago
float_histogram.go	Add histogram validation in remote-read and during reducing resolution (#17561)	2 months ago
float_histogram_test.go	Add histogram validation in remote-read and during reducing resolution (#17561)	2 months ago
generic.go	Add histogram validation in remote-read and during reducing resolution (#17561)	2 months ago
generic_test.go	Add histogram validation in remote-read and during reducing resolution (#17561)	2 months ago
histogram.go	Add histogram validation in remote-read and during reducing resolution (#17561)	2 months ago
histogram_test.go	Add histogram validation in remote-read and during reducing resolution (#17561)	2 months ago
test_utils.go	Apply analyzer "modernize" to the whole codebase	5 months ago