Kim Alvefur
b0a1bf8626
mod_csi_simple,mod_carbons,mod_mam: Update comment about XEP-0353
...
It went back to Deferred
5 years ago
Kim Alvefur
56aaa63f96
mod_csi_simple: Consider XEP-0353: Jingle Message Initiation important
...
Improves experience with VoIP calls initiated via JMI
Closes #1548
6 years ago
Kim Alvefur
f66524ac88
mod_csi_simple: Consider XEP-0353: Jingle Message Initiation important
...
Improves experience with VoIP calls initiated via JMI
Closes #1548
6 years ago
Kim Alvefur
3e5bae8965
mod_csi_simple: Consider XEP-0353: Jingle Message Initiation important
...
Improves experience with VoIP calls initiated via JMI
Closes #1548
6 years ago
Kim Alvefur
05e276504d
mod_csi_simple: Report whatever's not a stirng and not a stanza
...
This is either dead code or actually a type error, but catching that
should be the responsibility of the session.send function. This type
check is left since everything after it assumes a stanza object.
These last few commits aren't meant to change any behavior and it did
mark things not stanzas as important, but those would have been mostly
raw strings which are now specially handled.
6 years ago
Kim Alvefur
d51e32b8d3
mod_csi_simple: Report whitespace keepalives
...
Single space character is sent by mod_c2s when a session has been
silent for some time. This should account for the vast majority of raw
strings passing through here. If this is not the case then having stats
to say otherwise will be interesting.
6 years ago
Kim Alvefur
aba0d80e94
mod_csi_simple: Identify raw string data in logging and stats
6 years ago
Kim Alvefur
3e50ef4da6
mod_csi_simple: Collect stats on flush reasons
6 years ago
Kim Alvefur
931adcf40c
mod_csi_simple: Record stats of how long buffers are held
...
Telnet command `stats:show("buffer_hold"):histogram()` looks nice!
6 years ago
Kim Alvefur
de96139b6c
mod_csi_simple: Change debug message of client-triggered flush for coherence
...
It now matches other the other source of flush reason logging.
6 years ago
Kim Alvefur
926003db59
mod_csi_simple: Reset queue counter to zero when enabling
...
For symmetry.
6 years ago
Kim Alvefur
efcd07cf8b
mod_csi_simple: Forget queue counter when disabling optimizations
...
Otherwise it might not start from zero when enabled again.
6 years ago
Kim Alvefur
6f60cb0639
mod_csi_simple: Fix flushing when client sent something
...
Forgot to unset the flag afterwards, so it would only work once.
The flag is not even needed, it works as intended without it.
6 years ago
Kim Alvefur
d182923d72
mod_csi_simple: Fix treating presence errors as presence updates
...
Autocomplete fail probably.
6 years ago
Kim Alvefur
35c44c74ab
mod_csi_simple: Add comment highlighting that XEP-0353 is experimental
...
To make it easier to find implemented Experimental XEPs later. Also at
the time of this commit it has been Proposed as mentinoed in the
comment but hopefully that will be resolved soon.
6 years ago
Kim Alvefur
dfee86b338
mod_csi_simple: Fix unintentional order of rules from merge
6 years ago
Kim Alvefur
593c693e22
mod_csi_simple: Log reasons for not flushing
6 years ago
Kim Alvefur
b9684574db
mod_csi_simple: Add short reasons to report
...
Should improve quality of debug logs
6 years ago
Kim Alvefur
5593dc204f
mod_csi_simple: Refactor to allow logging reason for buffer flush
...
Same style as mod_mam and mod_carbons allows easy comparison.
BC: Log format changes
6 years ago
Kim Alvefur
405ba6df12
mod_csi_simple: Don't consider presence errors as important
...
A large share of `<presence type=error>` appears to be noise from large
public channels and failed presence probes. The later at least should
count as presence updates, which are currently considered unimportant.
See also 8cecb85e4bc4 which is partly reverted here. The intent there
was probably mostly about message (delivery) errors, which should be
considered important.
6 years ago
Kim Alvefur
99d495680b
mod_csi_simple: Explicitly mention iq stanzas
...
Should be more obvious that all iq stanzas are considered important.
Changes behavior for invalid things in the default namespace.
6 years ago
Kim Alvefur
4fe295898a
mod_csi_simple: Clarify what might not be stanzas here
6 years ago
Kim Alvefur
ba0fe2779a
mod_csi_simple: Consider nonzas important
...
This case was previously handled by fall-trough at the end of the
function.
6 years ago
Kim Alvefur
785473050a
mod_csi_simple: Explicitly consider errors important
...
This was already the case for presence and iq stanzas but not messages.
6 years ago
Kim Alvefur
87b22c2165
mod_csi_simple: Consider MUC invites important
...
Both mediated invites defined by XEP-0045: Multi-User Chat and direct
invites defined by XEP-0249: Direct MUC Invitations
6 years ago
Kim Alvefur
61dfe526dc
mod_csi_simple: Allow configuring extra tags indicating importance
6 years ago
Kim Alvefur
c20412ca92
mod_csi_simple: Make sure to disable optimizations before mod_smacks (thanks pep.)
6 years ago
Kim Alvefur
a183273abe
mod_csi_simple: Always remove session filters when disabling CSI
...
Only guard the actual pausing of outgoing data on the method existing.
This prevents the filters from lingering in case something happened to
the connection. Removing already removed filters should be a safe noop.
6 years ago
Kim Alvefur
120baded86
mod_csi_simple: Try not to flush buffer while already flushing it
...
Reduces log noice
6 years ago
Kim Alvefur
8369b96e16
mod_csi_simple: Remove duplicated check for connection
6 years ago
Kim Alvefur
2dbd1528bb
mod_csi_simple: Disable optimizations on disconnect ( fixes #1358 )
...
The connection becomes invalid here, regardless of 3rd party modules
that might keep the session alive.
7 years ago
Kim Alvefur
3b8d96984a
mod_csi_simple: Consider messages encrypted payload as important (fixes part of #1250 )
7 years ago
Kim Alvefur
7c10b606cd
mod_csi_simple: Consider messages with subject (eg MUC joins) (fixes part of #1250 )
7 years ago
Kim Alvefur
14787cf7ec
mod_csi_simple: Unpack Carbons-forwarded messages (fixes part of #1250 )
7 years ago
Kim Alvefur
6b0baf8932
mod_csi_simple: Consider messages forwarded from another of the users clients as important (fixes part of #1250 )
7 years ago
Kim Alvefur
3d53bcd72a
mod_csi_simple: Tweak check for <body>
...
There were code that checked the body for mentions but isn't included.
7 years ago
Kim Alvefur
3d30bbe912
mod_csi: Set session.state to simplify CSI modules
...
Moved here from mod_csi_simple
7 years ago
Kim Alvefur
105b5fed06
mod_csi_simple: Fix autocompletion mistake
7 years ago
Kim Alvefur
e525ef5a65
mod_csi_simple: Bypass importance event in active mode ( fixes #1249 )
7 years ago
Kim Alvefur
e3b4fe22a7
mod_csi_simple: Don't set <delay> stamps on <iq> stanzas ( fixes #1248 )
7 years ago
Kim Alvefur
0e49129a8b
mod_csi_simple: Use the same event name when firing as when hooking ( fixes #1245 )
7 years ago
Kim Alvefur
320392f1d1
mod_csi_simple: Consider non-stanza objects important
...
Most cases are for keepalive or stream closing, where it needs to be
flushed anyways.
7 years ago
Kim Alvefur
301cad9b16
mod_csi_simple: Skip delay tags on objects other than stanzas (thanks quest)
...
This may be triggered by sending strings, eg as done by mod_c2s for
keepalives, stream errors, "</stream>".
7 years ago
Kim Alvefur
9386bcbd2a
mod_csi_simple: Import modified version of mod_csi_pump from prosody-modules
7 years ago
Kim Alvefur
65f01dec0d
mod_csi_simple: Include queue size in debug messages
7 years ago
Matthew Wild
3179518b6a
mod_csi_simple: Fix type in function name
7 years ago
Kim Alvefur
ee00373447
mod_csi_simple: Improve debug logs by mentioing why the buffer gets flushed
7 years ago
Kim Alvefur
dd0258ff77
mod_csi_simple: Add some debug logging
7 years ago
Kim Alvefur
0c520e8a39
mod_csi_simple: Disable optimizations on unload and re-enable on load
7 years ago
Kim Alvefur
8ad3c66121
mod_csi_simple: Separate out functions to enable/disable optimizations
...
This allows reusing this logic outside the events. Letting the functions
be module globals makes it easier to access from eg the telnet console.
7 years ago