4240 Commits (0ec577b5dfed46586ff329e531bcc18a4cd5ec00)

Author	SHA1	Message	Date
Kim Alvefur	0ec577b5df	mod_saslauth: Collect SASL EXTERNAL failures into an util.error object ... Will be easier than that concatenated string to extract info out of for use elsewhere.	7 years ago
Kim Alvefur	ee33732c5f	mod_s2s: Invert condition to return early and reduce indentation	7 years ago
Kim Alvefur	129b463d81	mod_s2s: Fix mistake in 28755107c2f4	7 years ago
Kim Alvefur	947c10c689	mod_saslauth: Advertise correct set of mechanisms ... Mistakenly iterates over the set of all supported mechanisms instead of the one without insecure mechanisms if the connection is insecure. Not a problem if c2s_require_encryption is true Introduced in 56a0f68b7797	7 years ago
Kim Alvefur	190a2a2cab	mod_s2s: Refactor stream error handling on close ... Deduplicates the 3 log calls that log the same thing but subtly differently. The first one would say "Disconnecting localhost" and the last one didn't log the IP.	7 years ago
Kim Alvefur	a5d6f3717a	mod_s2s: Use stanza type check instead of duck typing	7 years ago
Kim Alvefur	ae49a4500f	mod_net_multiplex: Remove debug message ... This was something I added during development and set to info level for visibility.	7 years ago
Kim Alvefur	7f02081af2	mod_s2s: Improve TLS handshake error messages ... This should make it clearer that it's about the TLS handshake. Otherwise it's something like "unsupported protocol" or "no shared ciphers" that might not be that obvious.	7 years ago
Kim Alvefur	78a340ccf7	mod_s2s: Log from session logger ... Helps locating all messages related to a specific session	7 years ago
Kim Alvefur	6494446456	mod_s2s: Improve log message about forbidding insecure connections ... This new wording generator is nice.	7 years ago
Kim Alvefur	07645554cc	mod_admin_telnet: Sort hosts ... Groups by domain in DNS hierarchy order or something. Why not split on '.' you ask? Well becasue that's not what I typed here. Also "[^.]" is longer than "%P".	7 years ago
Kim Alvefur	5aee95c57c	mod_carbons: Improve performance by delaying creation of carbon payload ... If there are no other sessions which also enabled carbons then the carbons wrapper is not used and the potentially expensive clone operation was a waste of cycles.	7 years ago
Kim Alvefur	a577a981ee	mod_net_multiplex: Tweak debug logging for ALPN case	7 years ago
Kim Alvefur	349ac37e3c	mod_net_multiplex: Add support for using ALPN ... Potentially a bit more efficient since it can jump to the selected protocol on connect instead of waiting for some data to look at. Adds a 'protocol' field to net providers for this purpose.	7 years ago
Kim Alvefur	2d7eada577	mod_admin_telnet: Display ALPN in show_tls() if supported and available	7 years ago
Kim Alvefur	83f9904a48	mod_http: Log served URLs at 'info' level ... These are similar to the "activated service" messages from portmanager and similarily useful for the service admin to know even if they're not debugging anything.	7 years ago
Kim Alvefur	36483b12ca	mod_s2s: Prevent unhandled stanza handler from complaining about stream features on aborted connections ... I have no idea why I wrote return false in e5945fb5b71f	7 years ago
Kim Alvefur	2de1ed7ca2	mod_s2s_bidi: Ignore unencrypted connections if s2s_require_encryption is set ... Prevents some weirdness in cases where no authentication is done	7 years ago
Kim Alvefur	ebfbcab1a9	mod_s2s: Abort outgoing connections earlier when TLS requirement isn't satisfied ... This ensures the closure reason is accurate and not reported as an authentication or other problem	7 years ago
Kim Alvefur	4560212e9b	mod_s2s: Send stream errors for cert problems on outgoing connections ... Rationale in comment.	7 years ago
Kim Alvefur	07e3b93181	mod_s2s: Improve error in bounces due to cert validation problems	7 years ago
Kim Alvefur	838f903396	mod_s2s_auth_certs: Save chain validation errors for later use	7 years ago
Kim Alvefur	7801141c08	MUC: Add missing reference to room (thanks buildbot) [luacheck]	7 years ago
Kim Alvefur	d7d2b03003	MUC: Indicate the component as origin of various errors where there's no room ... A room that doesn't exist can't return an error, can it?	7 years ago
Kim Alvefur	5a37794485	MUC: Indicate that the room is the origin of various errors where 'from' is an occupant JID	7 years ago
Kim Alvefur	caa5b2ca77	MUC: Indicate origin of registration related errors	7 years ago
Kim Alvefur	97b1139a7c	MUC: Indicate origin of password related errors	7 years ago
Kim Alvefur	17e77058d6	MUC: Keep role across nickname change (fixes #1466)	7 years ago
Kim Alvefur	1421714628	mod_http_errors: Show a friendly page instead of 404 on top level	7 years ago
Kim Alvefur	33e92de387	mod_csi: Cache CSI module availability to improve readabilty	7 years ago
Kim Alvefur	0e3cb510ad	mod_csi: Set module status based on whether a CSI handler module appears to be loaded	7 years ago
Kim Alvefur	5ce52878ab	mod_csi: Only advertise CSI to clients if something is handling CSI events	7 years ago
Kim Alvefur	5047e42a4d	mod_s2s: Add error text for error replies on some s2s failures (#770)	7 years ago
Kim Alvefur	4a9bb8c321	s2s: Allow passing a custom error for bouncing queued stanzas (#770) ... Since stream errors and stanza errors are different	7 years ago
Kim Alvefur	b1d048f117	mod_admin_telnet: Show SNI name in show_tls() if available	7 years ago
Kim Alvefur	80a58e551b	mod_s2s: Wait for remote to close any connection allowing incoming stanzas ... Ie both s2sin and bidi-enabled s2sout.	7 years ago
Kim Alvefur	86b23ae5f7	MUC: Don't advertise registration feature on host JID (fixes #1451) ... There is currently no mention in XEP-0045 of how or where to advertise support for registration. Advertising on the host JID may be confusable with service-wide registration, as implemented in ejabberd. A common and sensible pattern in XMPP is that a feature is advertised on the JID where the service is available.	7 years ago
Kim Alvefur	90ac1b2711	mod_muc_mam: Copy debug log improvements from mod_mam	7 years ago
Kim Alvefur	c20412ca92	mod_csi_simple: Make sure to disable optimizations before mod_smacks (thanks pep.)	7 years ago
Kim Alvefur	70a81b5ffd	mod_http: Soften dependency on mod_http_errors ... This allows disabling mod_http_errors by adding it to moduless_disabled and ensures mod_http loads even if the error pages aren't as pretty.	7 years ago
Kim Alvefur	36edc39c5b	mod_s2s: Allow passing bounce reason as an util.error object (see #770) ... This argument is currently unused in s2smanager.	7 years ago
Kim Alvefur	b10435f306	mod_ping: Remove ad-hoc command ... 17:27:40 <Ge0rG> Zash: the Ping thing is absolutely worthless 17:27:55 <Zash> The command provided by mod_ping? 17:27:59 <pep.> To own server? 17:28:14 <Ge0rG> the Ping command in mod_admin_web, whatever it maps to 17:28:29 <Ge0rG> > Pong > 2019-11-07T16:28:16Z What am I supposed to do with that result? 17:28:29 <Zash> Yeah, mod_ping provides that 17:28:41 <Ge0rG> Is it a ping to my own server? Where's the RTT? 17:28:48 <Zash> Dunno if it's useful for more than verifying that the adhoc command system works 17:29:02 <Ge0rG> (it lags, but there is no indication of how much) 17:29:14 <Zash> It can't really test that itself 17:29:52 <Zash> Anyone opposed to deleting it? 17:30:42 <Zash> Half the module 17:42:47 <MattJ> Zash, I'm fine with removing it	7 years ago
Kim Alvefur	86779fa195	mod_admin_adhoc: Add some flags to s2s listing command ... These are present in mod_admin_telnet and relevant to s2s	7 years ago
Kim Alvefur	2a10ceae09	mod_admin_telnet: Show s2s authentication method (probably) used	7 years ago
Kim Alvefur	bf12db8122	mod_user_account_management: Apply username normalization later ... Prevents traceback from nodeprep(nil)	7 years ago
Kim Alvefur	1d46ca36e6	mod_s2s: Only nameprep stream to/from addresses if they are present ... Prevents traceback from nameprep(nil)	7 years ago
Kim Alvefur	5123cae2ff	mod_dialback: Fix potential traceback in case of missing addressing ... Not tested. Assuming nothing good comes from continuing the program flow after this. The connection should get closed and the event gets aborted by a traceback anyways.	7 years ago
Kim Alvefur	34c79b915e	mod_c2s: Validate that a 'to' attribute exists at all ... Prevents traceback from nameprep(nil)	7 years ago
Kim Alvefur	fc5957ca42	mod_bosh: Abort early if request is missing hostname ... Prevents traceback from passing nil to nameprep()	7 years ago
Kim Alvefur	cffb8bea9a	mod_dialback: Abort early if request is missing addressing attributes ... Prevents traceback from passing nil to nameprep()	7 years ago