Matthew Wild
ac77dc3db2
prosodyctl check config: add recommendation to switch from admin_telnet to shell
1 year ago
Matthew Wild
775a4d3cf6
prosodyctl check config: List modules which Prosody cannot successfully load
1 year ago
Matthew Wild
3acd17a59e
prosodyctl check certs: Use correct hostname in warning message about HTTPS
1 year ago
Matthew Wild
f0042849ba
mod_admin_shell, prosodyctl shell: Report command failure when no password entered ( fixes #1907 )
1 year ago
Matthew Wild
3d74ce8584
prosodyctl check: Be more robust against invalid disco_items, and show warning
1 year ago
Matthew Wild
57d168dd5e
prosodyctl shell: More reliable detection of REPL/interactive mode ( fixes #1895 )
1 year ago
Matthew Wild
04bd8258ef
prosodyctl check features: Report size limit for HTTP upload
...
This also adds a generic "meta" mechanism where checks can return annotations.
1 year ago
Matthew Wild
9f50add34e
prosodyctl check features: Add descriptions to features
...
Also shuffles mod_pep check to multi-device sync, as I think that's a better
fit.
1 year ago
Matthew Wild
783c8fcc81
prosodyctl: check features: stop searching after finding a matching component
1 year ago
Matthew Wild
79381510cf
mod_admin_shell, util.prosodyctl.shell: Process command-line args on server-side, with argparse support
...
This allow a shell-command to provide a 'flags' field, which will automatically
cause the parameters to be fed through argparse.
The rationale is to make it easier for more complex commands to be invoked
from the command line (`prosodyctl shell foo bar ...`). Until now they were
limited to accepting a list of strings, and any complex argument processing
was non-standard and awkward to implement.
1 year ago
Matthew Wild
2c0af0666b
prosodyctl: check features: Fix traceback for components with no recommended modules (thanks Menel, riau)
1 year ago
Matthew Wild
3ba87d07a9
util.prosodyctl.check: Recognise http_upload_external as a file upload service
1 year ago
Matthew Wild
f7f794c5c6
util.prosodyctl.check: Fix typo in informational message
1 year ago
Matthew Wild
8edde6a299
prosodyctl: check features: check for mod_muc_mam on MUC components
1 year ago
Matthew Wild
c7554fdba8
prosodyctl: check: Fix variable name (thanks luacheck)
1 year ago
Matthew Wild
500d0df0a4
prosodyctl: check: Skip DNS checks for known invalid domains (fixes traceback)
1 year ago
Matthew Wild
f585db3acf
prosodyctl: check features: Check for recommended feature availability
...
Inspired by mod_compliance_*, this command will help people (especially those
with older configs, upgrading from previous releases) learn what features
their Prosody configuration may be missing.
1 year ago
Matthew Wild
fb733fb549
util.prosodyctl.check: Sort hosts in iterator for more stable output
1 year ago
Matthew Wild
35e48b2bac
prosodyctl: check: Fix indentation in warning message
1 year ago
Matthew Wild
ed5dfc1a62
prosodyctl: check: Warn about deprecated mod_posix
1 year ago
Matthew Wild
1377333751
util.prosodyctl.shell: Export function to check for availability of admin socket
1 year ago
Kim Alvefur
4569e951af
util.prosodyctl.shell: Remove non-existent export [luacheck]
1 year ago
Matthew Wild
91776f57ef
util.prosodyctl.shell: Support for requesting special inputs, e.g. passwords
...
This lets the server signal to the client that a special input is requested.
Currently we support the "password" type only.
1 year ago
Matthew Wild
bca60e609d
util.prosodyctl.check: Improve error handling of UDP socket setup (for #1803 )
...
Not necessarily a fix, but may give us more information about failure cases.
1 year ago
Kim Alvefur
f7d0caa5ac
util.prosodyctl.cert: Ensure old cert is moved out of the way
...
This should make it visible if the move fails
2 years ago
Matthew Wild
272e700f50
prosodyctl shell: Fix invocation with 3+ command arguments
...
The code correctly inserted the ',' when there was already a "%q" in the
format string, but then the next argument would fail to match because it
inserted ", %q" instead of "%q". The code now matches both, ensuring the
generated code will not produce a syntax error with multiple arguments.
2 years ago
Matthew Wild
655c972a7d
prosodyctl check: Warn about invalid domain names in the config file
...
This ensures that domain names of virtual hosts and components are valid in
XMPP, and that they are encoded correctly.
2 years ago
Kim Alvefur
da3d755a15
util.prosodyctl.check: Correct modern replacement for 'disallow_s2s'
...
The code would have suggested adding to modules_enabled instead of
modules_disabled
3 years ago
Kim Alvefur
683b90f871
util.prosodyctl.check: Hint about the 'external_addresses' config option
3 years ago
Kim Alvefur
43c39930c3
util.prosodyctl.check: Validate format of module list options
...
Should detect things like misplaced settings inside modules_enabled
3 years ago
Kim Alvefur
3f81654a66
util.prosodyctl.check: Get some config options via minimal moduleapi #896
...
The module API has certain coercion features that are useful.
Fixes traceback reported in #1812 and other duplicates
3 years ago
Kim Alvefur
e4d5c15396
util.prosodyctl.check: Fix error where hostname can't be turned into A label
...
Where gethostname or tohostname returns an invalid name, e.g. containing
underscores or something, to_ascii would reject this and return nil,
which triggers an error in the dns lookup.
Reported by prova2 in the chat, for whom tohostname returned a long name
containing underscores.
3 years ago
Kim Alvefur
9c49ca70fd
util.prosodyctl.check: Suggest 'http_cors_override' instead of older CORS settings
...
The cross_domain_* settings were added here prior to http_cors_override
being added back in 17d87fb2312a, so for a time there was no
replacement, but now there is.
3 years ago
Kim Alvefur
7c302e9c4c
util.prosodyctl.shell: Close state on exit to fix saving shell history
...
This ensures a last round of garbage collection and finalizers, which
should include flushing the readline history file.
Test procedure:
```
$ ./prosodyctl shell
prosody> s2s:show() -- any command that is not the last in history
... output
prosody> bye
$ ./prosodyctl shell
prosody> ^P
```
After this, the shell prompt should contain the last command from before
the "bye". Before this patch, recent history is gone most of the time.
3 years ago
Kim Alvefur
c9fb0c2cab
prosodyctl check dns: Check for Direct TLS SRV records even if not configured ( fix #1793 )
...
Existing such records may cause timeouts or errors in clients and
servers trying to connect, despite prosodyctl check saying all is well
3 years ago
Kim Alvefur
d545540ae0
util.prosodyctl.check: Remove now redundant unbound config tweak
...
This is now done in net.unbound itself
Turning it back on in the config may still cause the problem of entries
there masking the DNS values.
4 years ago
Kim Alvefur
f0fc620d2a
util.prosodyctl.check: turn: Report lack of TURN services as a problem #1749
...
Rationale: It seems unlikely that someone who has not configured any
TURN service runs 'prosodyctl check turn' expecting this to be okay.
4 years ago
Matthew Wild
89934124b8
util.prosodyctl: check turn: ensure a result is always returned from a check (thanks eTaurus)
4 years ago
Matthew Wild
fdd5f22b8a
prosodyctl: check config: Report paths of loaded configuration files ( fixed #1729 )
4 years ago
Matthew Wild
afbef6406b
prosodyctl: check turn: Fail with error if our own address is supplied for the ping test
4 years ago
Matthew Wild
d0bd1e71d9
prosodyctl: check config: Skip bare JID components in orphan check
4 years ago
Matthew Wild
681ac46aae
prosodyctl: check turn: warn about external port mismatches behind NAT
...
Some NATs don't preserve port numbers, which can cause the TURN server's
reported relay address to be incorrect (the TURN server has no way to predict
what the external port is, so it can't be corrected in config like an IP
mismatch can).
4 years ago
Kim Alvefur
43351d2b54
Spelling: Fix various spelling mistakes (thanks timeless)
...
Words, sometimes I wonder how they even work
Maybe I missed something.
4 years ago
Matthew Wild
9a86373fd1
prosodyctl: check turn: compare correct addresses for relay mismatch detection (thanks Zash)
4 years ago
Matthew Wild
046b4085cb
prosodyctl: check turn: Add check for private IP returned from STUN.
4 years ago
Matthew Wild
f7adea5040
prosodyctl: check turn: improve warning text to suggest issues
4 years ago
Matthew Wild
750f3a78d5
prosodyctl: check turn: fix traceback when server does not provide realm/nonce
...
As coturn when installed out of the box on Debian (because auth isn't enabled?)
4 years ago
Matthew Wild
08777eb3d6
prosodyctl: check turn: fix formatting of multiple warnings
4 years ago
Matthew Wild
c2af455ac0
prosodyctl: check turn: always show debug info even if test fails
4 years ago
Matthew Wild
2320d07021
prosodyctl: check turn: Clearer error when unable to resolve external service host
4 years ago