From 889aa6d65208db2f3f364cc37a29be9325fa186a Mon Sep 17 00:00:00 2001 From: Benjamin Tissoires Date: Fri, 9 Nov 2018 16:00:21 +0100 Subject: [PATCH] Revert "models: boards: add PUT members entry point" This reverts commit f61942e5cb672d3e0fd4df6c5ff9b3f15f7cb778. Adding a member is actually already handled by POST', '/api/boards/:boardId/members/:userId/add' So this function is purely duplicated. Not to mention that the '/add' one allows to set permissions so this one in this commit is less interesting. --- models/boards.js | 32 -------------------------------- 1 file changed, 32 deletions(-) diff --git a/models/boards.js b/models/boards.js index 57f3a1f1f..db3b11496 100644 --- a/models/boards.js +++ b/models/boards.js @@ -278,10 +278,6 @@ Boards.helpers({ return Users.find({ _id: { $in: _.pluck(this.members, 'userId') } }); }, - getMember(id) { - return _.findWhere(this.members, { userId: id }); - }, - getLabel(name, color) { return _.findWhere(this.labels, { name, color }); }, @@ -847,34 +843,6 @@ if (Meteor.isServer) { } }); - JsonRoutes.add('PUT', '/api/boards/:boardId/members', function (req, res) { - Authentication.checkUserId(req.userId); - try { - const boardId = req.params.boardId; - const board = Boards.findOne({ _id: boardId }); - const userId = req.body.userId; - const user = Users.findOne({ _id: userId }); - - if (!board.getMember(userId)) { - user.addInvite(boardId); - board.addMember(userId); - JsonRoutes.sendResult(res, { - code: 200, - data: id, - }); - } else { - JsonRoutes.sendResult(res, { - code: 200, - }); - } - } - catch (error) { - JsonRoutes.sendResult(res, { - data: error, - }); - } - }); - JsonRoutes.add('POST', '/api/boards', function (req, res) { try { Authentication.checkUserId(req.userId);