From 062f9a8ca5fc42d7aff47a5e8fd7a7839cfda28e Mon Sep 17 00:00:00 2001 From: Julio Montoya Date: Mon, 30 Jul 2012 12:44:16 +0200 Subject: [PATCH] Should fix bug when showing the question reporting (first table) see #5257 --- main/exercice/exercise.lib.php | 4 ++-- main/exercice/stats.php | 15 ++++++--------- 2 files changed, 8 insertions(+), 11 deletions(-) diff --git a/main/exercice/exercise.lib.php b/main/exercice/exercise.lib.php index 14a3a9b8ed..dd3f4ba612 100644 --- a/main/exercice/exercise.lib.php +++ b/main/exercice/exercise.lib.php @@ -1639,11 +1639,11 @@ function get_number_students_question_with_answer_count($question_id, $exercise_ a.course_code = '$course_code' AND e.session_id = $session_id AND question_id = $question_id AND - answer <> 0 AND + answer <> '0' AND cu.status = ".STUDENT." AND relation_type <> 2 AND e.status = ''"; - + var_dump($sql); $result = Database::query($sql); $return = 0; if ($result) { diff --git a/main/exercice/stats.php b/main/exercice/stats.php index 6fda52b8c3..f8e5095f9d 100644 --- a/main/exercice/stats.php +++ b/main/exercice/stats.php @@ -44,9 +44,9 @@ $headers = array( if (!empty($question_list)) { foreach ($question_list as $question_id) { - $question_obj = Question::read($question_id); - $exercise_stats = get_student_stats_by_question($question_id, $exercise_id, api_get_course_id(), api_get_session_id()); - $count_users = get_number_students_question_with_answer_count($question_id, $exercise_id, api_get_course_id(), api_get_session_id()); + $question_obj = Question::read($question_id); + $exercise_stats = get_student_stats_by_question($question_id, $exercise_id, api_get_course_id(), api_get_session_id()); + $count_users = get_number_students_question_with_answer_count($question_id, $exercise_id, api_get_course_id(), api_get_session_id()); $data[$question_id]['name'] = cut($question_obj->question, 100); $data[$question_id]['type'] = $question_obj->get_question_type_name(); @@ -111,7 +111,7 @@ if (!empty($question_list)) { //$data[$id]['name'] .=$answer_count; //Overwriting values depending of the question - switch($question_obj->type) { + switch ($question_obj->type) { case FILL_IN_BLANKS : $answer_info_db = $answer_info; $answer_info = substr($answer_info, 0, strpos($answer_info, '::')); @@ -122,9 +122,7 @@ if (!empty($question_list)) { if ($counter == 0) { $data[$id]['name'] = cut($question_obj->question, 100); } else { - $data[$id]['name'] = '-'; - - + $data[$id]['name'] = '-'; } $data[$id]['answer'] = $answer_item; @@ -148,8 +146,7 @@ if (!empty($question_list)) { $data[$id]['name'] = cut($question_obj->question, 100); } else { $data[$id]['name'] = '-'; - } - + } $correct = ''; for ($i = 1; $i <= $answer_count; $i++) { $is_correct_i = $answer->isCorrect($i);