diff --git a/main/gradebook/gradebook_add_eval.php b/main/gradebook/gradebook_add_eval.php index c3dd2395d6..781068a008 100755 --- a/main/gradebook/gradebook_add_eval.php +++ b/main/gradebook/gradebook_add_eval.php @@ -12,11 +12,11 @@ api_protect_course_script(true); api_block_anonymous_users(); GradebookUtils::block_students(); -$select_cat = isset($_GET['selectcat']) ? Security::remove_XSS($_GET['selectcat']) : ''; +$select_cat = isset($_GET['selectcat']) ? (int) $_GET['selectcat'] : 0; $is_allowedToEdit = $is_courseAdmin; $evaladd = new Evaluation(); $evaladd->set_user_id($_user['user_id']); -if (isset($_GET['selectcat']) && (!empty($_GET['selectcat']))) { +if (!empty($select_cat)) { $evaladd->set_category_id($_GET['selectcat']); $cat = Category :: load($_GET['selectcat']); $evaladd->set_course_code($cat[0]->get_course_code()); diff --git a/main/gradebook/gradebook_add_link.php b/main/gradebook/gradebook_add_link.php index 1d06ba3db2..d1e66962e6 100755 --- a/main/gradebook/gradebook_add_link.php +++ b/main/gradebook/gradebook_add_link.php @@ -14,8 +14,9 @@ api_block_anonymous_users(); GradebookUtils::block_students(); $courseCode = isset($_GET['course_code']) ? Security::remove_XSS($_GET['course_code']) : null; -$course_info = api_get_course_info($courseCode); +$selectCat = isset($_GET['selectcat']) ? (int) $_GET['selectcat'] : 0; +$course_info = api_get_course_info($courseCode); $tbl_forum_thread = Database :: get_course_table(TABLE_FORUM_THREAD); $tbl_link = Database::get_main_table(TABLE_MAIN_GRADEBOOK_LINK); @@ -34,8 +35,8 @@ if ($session_id == 0) { } else { $all_categories = Category::load_session_categories(null, $session_id); } -$category = Category :: load($_GET['selectcat']); -$url = api_get_self().'?selectcat='.Security::remove_XSS($_GET['selectcat']).'&newtypeselected='.$typeSelected.'&course_code='.api_get_course_id().'&'.api_get_cidreq(); +$category = Category :: load($selectCat); +$url = api_get_self().'?selectcat='.$selectCat.'&newtypeselected='.$typeSelected.'&course_code='.api_get_course_id().'&'.api_get_cidreq(); $typeform = new LinkForm( LinkForm :: TYPE_CREATE, $category[0], @@ -49,7 +50,7 @@ $typeform = new LinkForm( // if user selected a link type if ($typeform->validate() && isset($_GET['newtypeselected'])) { // reload page, this time with a parameter indicating the selected type - header('Location: '.api_get_self().'?selectcat='.Security::remove_XSS($_GET['selectcat']) + header('Location: '.api_get_self().'?selectcat='.$selectCat .'&typeselected='.$typeform->exportValue('select_link') .'&course_code='.Security::remove_XSS($_GET['course_code']).'&'.api_get_cidreq() ); @@ -58,7 +59,7 @@ if ($typeform->validate() && isset($_GET['newtypeselected'])) { // link type selected, show 2nd form to retrieve the link data if (isset($typeSelected) && $typeSelected != '0') { - $url = api_get_self().'?selectcat='.Security::remove_XSS($_GET['selectcat']).'&typeselected='.$typeSelected.'&course_code='.$courseCode.'&'.api_get_cidreq(); + $url = api_get_self().'?selectcat='.$selectCat.'&typeselected='.$typeSelected.'&course_code='.$courseCode.'&'.api_get_cidreq(); $addform = new LinkAddEditForm( LinkAddEditForm :: TYPE_ADD, @@ -127,14 +128,14 @@ if (isset($typeSelected) && $typeSelected != '0') { header('Location: gradebook_add_result.php?selecteval='.$link->get_ref_id().'&'.api_get_cidreq()); exit; } else { - header('Location: '.Security::remove_XSS($_SESSION['gradebook_dest']).'?linkadded=&selectcat='.Security::remove_XSS($_GET['selectcat']).'&'.api_get_cidreq()); + header('Location: '.Security::remove_XSS($_SESSION['gradebook_dest']).'?linkadded=&selectcat='.$selectCat.'&'.api_get_cidreq()); exit; } } } $interbreadcrumb[] = array( - 'url' => $_SESSION['gradebook_dest'].'?selectcat='.Security::remove_XSS($_GET['selectcat']).'&'.api_get_cidreq(), + 'url' => $_SESSION['gradebook_dest'].'?selectcat='.$selectCat.'&'.api_get_cidreq(), 'name' => get_lang('Gradebook') ); $this_section = SECTION_COURSES; diff --git a/main/gradebook/gradebook_add_link_select_course.php b/main/gradebook/gradebook_add_link_select_course.php index 2f9a16ead9..ade2717065 100755 --- a/main/gradebook/gradebook_add_link_select_course.php +++ b/main/gradebook/gradebook_add_link_select_course.php @@ -13,16 +13,18 @@ api_protect_course_script(true); api_block_anonymous_users(); GradebookUtils::block_students(); +$selectCat = isset($_GET['selectcat']) ? (int) $_GET['selectcat'] : 0; + $catadd = new Category(); $catadd->set_user_id(api_get_user_id()); -$catadd->set_parent_id($_GET['selectcat']); -$catcourse = Category :: load ($_GET['selectcat']); +$catadd->set_parent_id($selectCat); +$catcourse = Category :: load ($selectCat); $form = new CatForm( CatForm :: TYPE_SELECT_COURSE, $catadd, 'add_cat_form', null, - api_get_self() . '?selectcat=' . Security::remove_XSS($_GET['selectcat']).'&'.api_get_cidreq() + api_get_self() . '?selectcat=' . $selectCat.'&'.api_get_cidreq() ); if ($form->validate()) { @@ -30,12 +32,12 @@ if ($form->validate()) { $cat = new Category(); $cat->set_course_code($values['select_course']); $cat->set_name($values['name']); - header('location: gradebook_add_link.php?selectcat=' .Security::remove_XSS($_GET['selectcat']).'&course_code='.Security::remove_XSS($values['select_course']).'&'.api_get_cidreq()); + header('location: gradebook_add_link.php?selectcat=' .$selectCat.'&course_code='.Security::remove_XSS($values['select_course']).'&'.api_get_cidreq()); exit; } $interbreadcrumb[] = array ( - 'url' => Security::remove_XSS($_SESSION['gradebook_dest']).'?selectcat='.Security::remove_XSS($_GET['selectcat']).'&'.api_get_cidreq(), + 'url' => Security::remove_XSS($_SESSION['gradebook_dest']).'?selectcat='.$selectCat.'&'.api_get_cidreq(), 'name' => get_lang('Gradebook') ); Display :: display_header(get_lang('NewCategory')); diff --git a/main/gradebook/gradebook_edit_cat.php b/main/gradebook/gradebook_edit_cat.php index 48569c88d3..697d1d38fe 100755 --- a/main/gradebook/gradebook_edit_cat.php +++ b/main/gradebook/gradebook_edit_cat.php @@ -84,7 +84,7 @@ if ($form->validate()) { header('Location: '.Security::remove_XSS($_SESSION['gradebook_dest']).'?editcat=&selectcat=' . $cat->get_parent_id().'&'.api_get_cidreq()); exit; } -$selectcat = isset($_GET['selectcat']) ? Security::remove_XSS($_GET['selectcat']) : ''; +$selectcat = isset($_GET['selectcat']) ? (int) $_GET['selectcat'] : ''; $interbreadcrumb[] = array( 'url' => Security::remove_XSS($_SESSION['gradebook_dest']) . '?selectcat=' . $selectcat . '&' . api_get_cidreq(), 'name' => get_lang('Gradebook') diff --git a/main/gradebook/gradebook_edit_eval.php b/main/gradebook/gradebook_edit_eval.php index 0f557296d0..c7f728483c 100755 --- a/main/gradebook/gradebook_edit_eval.php +++ b/main/gradebook/gradebook_edit_eval.php @@ -48,13 +48,13 @@ if ($form->validate()) { header('Location: '.$_SESSION['gradebook_dest'].'?editeval=&selectcat=' . $eval->get_category_id()); exit; } -$selectcat_inter=isset($_GET['selectcat'])?Security::remove_XSS($_GET['selectcat']):''; -$interbreadcrumb[] = array ( +$selectcat_inter=isset($_GET['selectcat']) ? (int) $_GET['selectcat'] : 0; +$interbreadcrumb[] = array( 'url' => $_SESSION['gradebook_dest'].'?selectcat='.$selectcat_inter, 'name' => get_lang('Gradebook' - )); +)); -$htmlHeadXtra[] = '