diff --git a/main/survey/reporting.php b/main/survey/reporting.php index 6d9e9fe1da..e40e58eb4d 100644 --- a/main/survey/reporting.php +++ b/main/survey/reporting.php @@ -18,6 +18,7 @@ require_once '../inc/global.inc.php'; require_once 'survey.lib.php'; $this_section = SECTION_COURSES; $survey_id = intval($_GET['survey_id']); +$survey_data = survey_manager::get_survey($survey_id); // Export /** @@ -26,17 +27,13 @@ $survey_id = intval($_GET['survey_id']); if (isset($_POST['export_report']) && $_POST['export_report']) { switch ($_POST['export_format']) { case 'xls': - $survey_data = survey_manager::get_survey($survey_id); $filename = 'survey_results_'.$survey_id.'.xls'; $data = SurveyUtil::export_complete_report_xls($survey_data, $filename, $_GET['user_id']); exit; break; case 'csv': default: - $survey_data = survey_manager::get_survey($survey_id); $data = SurveyUtil::export_complete_report($survey_data, $_GET['user_id']); - - //$filename = 'fileexport.csv'; $filename = 'survey_results_'.$survey_id.'.csv'; header('Content-type: application/octet-stream'); @@ -73,7 +70,6 @@ $people_filled = survey_manager::get_people_who_filled_survey( // Checking the parameters SurveyUtil::check_parameters($people_filled); - /** @todo this has to be moved to a more appropriate place (after the display_header of the code)*/ if (!api_is_allowed_to_edit(false, true)) { Display :: display_header(get_lang('ToolSurvey')); @@ -104,7 +100,7 @@ if (api_strlen(strip_tags($survey_data['title'])) > 40) { // Breadcrumbs $interbreadcrumb[] = array('url' => api_get_path(WEB_CODE_PATH).'survey/survey_list.php', 'name' => get_lang('SurveyList')); $interbreadcrumb[] = array('url' => api_get_path(WEB_CODE_PATH).'survey/survey.php?survey_id='.$survey_id, 'name' => $urlname); -if (!$_GET['action'] OR $_GET['action'] == 'overview') { +if (!isset($_GET['action']) || isset($_GET['action']) && $_GET['action'] == 'overview') { $tool_name = get_lang('Reporting'); } else { $interbreadcrumb[] = array( @@ -131,7 +127,7 @@ if (!$_GET['action'] OR $_GET['action'] == 'overview') { Display::display_header($tool_name, 'Survey'); // Action handling -SurveyUtil::handle_reporting_actions($people_filled); +SurveyUtil::handle_reporting_actions($survey_data, $people_filled); // Actions bar echo '