From 133c5e23c854907cc98c6587f4b02594ca1fc995 Mon Sep 17 00:00:00 2001 From: Julio Montoya Date: Mon, 7 Nov 2011 16:43:11 +0100 Subject: [PATCH] Fixing php notices --- main/group/group.php | 12 ++++++------ main/group/group_space.php | 2 +- main/inc/introductionSection.inc.php | 5 +++-- 3 files changed, 10 insertions(+), 9 deletions(-) diff --git a/main/group/group.php b/main/group/group.php index a6bc19e92b..24b4447eb7 100644 --- a/main/group/group.php +++ b/main/group/group.php @@ -73,12 +73,12 @@ Display::display_introduction_section(TOOL_GROUP); /* * Self-registration and unregistration */ - $my_group_id = Security::remove_XSS($_GET['group_id']); - $my_msg = Security::remove_XSS($_GET['msg']); - $my_group = $_POST['group']; - $my_get_id1 = Security::remove_XSS($_GET['id1']); - $my_get_id2 = Security::remove_XSS($_GET['id2']); - $my_get_id = Security::remove_XSS($_GET['id']); + $my_group_id = isset($_GET['group_id']) ? intval($_GET['group_id']) : null; + $my_msg = isset($_GET['msg']) ? Security::remove_XSS($_GET['msg']) : null; + $my_group = isset($_GET['group']) ? Security::remove_XSS($_POST['group']) : null; + $my_get_id1 = isset($_GET['id1']) ? Security::remove_XSS($_GET['id1']) : null; + $my_get_id2 = isset($_GET['id2']) ? Security::remove_XSS($_GET['id2']) : null; + $my_get_id = isset($_GET['id']) ? Security::remove_XSS($_GET['id']) : null; if (isset($_GET['action'])) { switch ($_GET['action']) { diff --git a/main/group/group_space.php b/main/group/group_space.php index b2dc3cdba9..5d6d56b1f3 100644 --- a/main/group/group_space.php +++ b/main/group/group_space.php @@ -59,7 +59,7 @@ Display::display_header($nameTools.' '.stripslashes($current_group['name']), 'Gr /* Introduction section (editable by course admin) */ -Display::display_introduction_section(group_space_.$_SESSION['_gid']); +Display::display_introduction_section(TOOL_GROUP); /* Actions and Action links */ diff --git a/main/inc/introductionSection.inc.php b/main/inc/introductionSection.inc.php index 747c4b38e1..1a5cd53ecb 100644 --- a/main/inc/introductionSection.inc.php +++ b/main/inc/introductionSection.inc.php @@ -105,7 +105,7 @@ if ($intro_editAllowed) { /* Delete Command */ if ($intro_cmdDel) { - Database::query("DELETE FROM $TBL_INTRODUCTION WHERE id='".$moduleId."' AND session_id='".intval($session_id)."'"); + Database::query("DELETE FROM $TBL_INTRODUCTION WHERE c_id = $course_id AND id='".$moduleId."' AND session_id='".intval($session_id)."'"); Display::display_confirmation_message(get_lang('IntroductionTextDeleted')); } } @@ -115,7 +115,8 @@ if ($intro_editAllowed) { /* Retrieves the module introduction text, if exist */ -$sql = "SELECT intro_text FROM $TBL_INTRODUCTION WHERE id='".Database::escape_string($moduleId)."' AND session_id='".intval($session_id)."'"; +$sql = "SELECT intro_text FROM $TBL_INTRODUCTION + WHERE c_id = $course_id AND id='".Database::escape_string($moduleId)."' AND session_id='".intval($session_id)."'"; $intro_dbQuery = Database::query($sql); if (Database::num_rows($intro_dbQuery) > 0) { $intro_dbResult = Database::fetch_array($intro_dbQuery);