diff --git a/public/main/course_progress/index.php b/public/main/course_progress/index.php index 8a865dfc6e..4a82bb4afa 100644 --- a/public/main/course_progress/index.php +++ b/public/main/course_progress/index.php @@ -17,6 +17,7 @@ $current_course_tool = TOOL_COURSE_PROGRESS; // protect a course script api_protect_course_script(true); $courseId = api_get_course_int_id(); +$description_type = null; // get actions $actions = [ @@ -132,7 +133,6 @@ $interbreadcrumb[] = [ ]; $actionLeft = ''; - // instance thematic object for using like library here $thematicManager = new Thematic(); @@ -724,10 +724,10 @@ switch ($action) { } else { $header_form = $default_thematic_plan_title[$description_type]; } - if (!$error) { + /*if (!$error) { $token = md5(uniqid(rand(), true)); Session::write('thematic_plan_token', $token); - } + }*/ // display form $form = new FormValidator( @@ -779,7 +779,7 @@ switch ($action) { } // error messages - if ($error) { + /*if ($error) { Display::addFlash( Display::return_message( get_lang('The form contains incorrect or incomplete data. Please check your input.'), @@ -787,7 +787,7 @@ switch ($action) { false ) ); - } + }*/ $content = $form->returnForm(); break; case 'thematic_plan_delete': diff --git a/public/main/exercise/admin.php b/public/main/exercise/admin.php index 229e62fa2b..f9e575eabb 100644 --- a/public/main/exercise/admin.php +++ b/public/main/exercise/admin.php @@ -106,12 +106,12 @@ if (isset($_REQUEST['convertAnswer'])) { $objAnswer = Session::read('objAnswer'); $_course = api_get_course_info(); -// tables used in the exercise tool -if (!empty($_GET['action']) && 'exportqti2' == $_GET['action'] && !empty($_GET['questionId'])) { +// tables used in the exercise tool. +if (!empty($_GET['action']) && 'exportqti2' === $_GET['action'] && !empty($_GET['questionId'])) { require_once 'export/qti2/qti2_export.php'; $export = export_question_qti($_GET['questionId'], true); $qid = (int) $_GET['questionId']; - + $name = 'qti2_export_'.$qid.'.zip'; $zip = api_create_zip($name); $zip->addFile("qti2export_$qid.xml", $export); $zip->finish(); diff --git a/public/main/exercise/aiken.php b/public/main/exercise/aiken.php index a63b2347c0..44294b2f6c 100644 --- a/public/main/exercise/aiken.php +++ b/public/main/exercise/aiken.php @@ -12,12 +12,8 @@ require_once __DIR__.'/../inc/global.inc.php'; api_protect_course_script(true); -$lib_path = api_get_path(LIBRARY_PATH); -$main_path = api_get_path(SYS_CODE_PATH); - -// including additional libraries -require_once $main_path.'exercise/export/aiken/aiken_import.inc.php'; -require_once $main_path.'exercise/export/aiken/aiken_classes.php'; +require_once __DIR__.'/export/aiken/aiken_import.inc.php'; +require_once __DIR__.'/export/aiken/aiken_classes.php'; // section (for the tabs) $this_section = SECTION_COURSES; @@ -44,11 +40,6 @@ if (api_is_allowed_to_edit(null, true)) { } } -// display header Display::display_header(get_lang('Import Aiken quiz'), 'Exercises'); - -// display Aiken form aiken_display_form(); - -// display the footer Display::display_footer(); diff --git a/public/main/exercise/exercise.php b/public/main/exercise/exercise.php index 6aef80049e..0eacb3eb26 100644 --- a/public/main/exercise/exercise.php +++ b/public/main/exercise/exercise.php @@ -231,7 +231,7 @@ if ($is_allowedToEdit && !empty($action)) { if ($limitTeacherAccess && !api_is_platform_admin()) { api_not_allowed(true); } - require_once api_get_path(SYS_CODE_PATH).'exercise/export/qti2/qti2_export.php'; + require_once __DIR__.'/export/qti2/qti2_export.php'; $export = export_exercise_to_qti($exerciseId, true); $xmlReader = new XMLReader(); diff --git a/public/main/exercise/exercise_report.php b/public/main/exercise/exercise_report.php index 29d51037f5..02789bed3d 100644 --- a/public/main/exercise/exercise_report.php +++ b/public/main/exercise/exercise_report.php @@ -203,7 +203,11 @@ if (isset($_REQUEST['comments']) && } // From the database. - $marksFromDatabase = $questionListData[$questionId]['marks']; + $marksFromDatabase = 0; + if (isset($questionListData[$questionId])) { + $marksFromDatabase = $questionListData[$questionId]['marks']; + } + if (in_array($question->type, [FREE_ANSWER, ORAL_EXPRESSION, ANNOTATION])) { // From the form. $params['marks'] = $marks; @@ -232,11 +236,11 @@ if (isset($_REQUEST['comments']) && $recording = new TrackEAttemptRecording(); $recording ->setExeId($id) - ->setQuestionId($my_questionid) + ->setQuestionId($questionId) ->setAuthor(api_get_user_id()) ->setTeacherComment($my_comments) ->setExeId($id) - ->setMarks($my_marks) + ->setMarks($marks) ->setSessionId(api_get_session_id()) ; diff --git a/public/main/exercise/exercise_show.php b/public/main/exercise/exercise_show.php index 376cfd33de..1382c949b2 100644 --- a/public/main/exercise/exercise_show.php +++ b/public/main/exercise/exercise_show.php @@ -570,7 +570,7 @@ foreach ($questionList as $questionId) {