Commenting code that blocks LP items to be saved see BT#8572

main/newscorm/lp_ajax_save_item.php

@@ -44,8 +44,23 @@ require_once 'aiccItem.class.php';
  * @param   array   Interactions array
  * @param   string  Core exit SCORM string
  */
-function save_item($lp_id, $user_id, $view_id, $item_id, $score = -1, $max = -1, $min = -1, $status = '', $time = 0, $suspend = '', $location = '', $interactions = array(), $core_exit = 'none', $sessionId = null, $courseId = null)
-{
+function save_item(
+    $lp_id,
+    $user_id,
+    $view_id,
+    $item_id,
+    $score = -1,
+    $max = -1,
+    $min = -1,
+    $status = '',
+    $time = 0,
+    $suspend = '',
+    $location = '',
+    $interactions = array(),
+    $core_exit = 'none',
+    $sessionId = null,
+    $courseId = null
+) {
     global $debug;
     $return = null;
 
@@ -58,9 +73,10 @@ function save_item($lp_id, $user_id, $view_id, $item_id, $score = -1, $max = -1,
 
     $mylp = null;
     $lpobject = Session::read('lpobject');
-    if (!is_object($lpobject) && isset($sessionId) && isset($courseId)) {
+    /*if (!is_object($lpobject) && isset($sessionId) && isset($courseId)) {
         $lpobject = new learnpathItem($lp_id, $user_id, $courseId);
-    }
+    }*/
+
     if (isset($lpobject)) {
         if (is_object($lpobject)) {
             $mylp = $lpobject;
@@ -87,6 +103,7 @@ function save_item($lp_id, $user_id, $view_id, $item_id, $score = -1, $max = -1,
         if ($debug) {
             error_log("mylp variable is not an learnpath object");
         }
+
         return null;
     }
 
@@ -99,6 +116,7 @@ function save_item($lp_id, $user_id, $view_id, $item_id, $score = -1, $max = -1,
         if ($debug > 0) {
             error_log("item #$item_id not found in the items array: ".print_r($mylp->items, 1));
         }
+
         return false;
     }
 
@@ -113,6 +131,7 @@ function save_item($lp_id, $user_id, $view_id, $item_id, $score = -1, $max = -1,
         }
 
         return $return;
+
     } else {
         if ($debug > 1) { error_log('Prerequisites are OK'); }
 
@@ -235,8 +254,6 @@ function save_item($lp_id, $user_id, $view_id, $item_id, $score = -1, $max = -1,
     if ($debug > 1) { error_log("myprogress_mode: $myprogress_mode", 0); }
     if ($debug > 1) { error_log("progress: $mycomplete / $mytotal", 0); }
 
-    //$_SESSION['lpobject'] = serialize($mylp);
-
     if ($mylpi->get_type() != 'sco') {
         // If this object's JS status has not been updated by the SCORM API, update now.
         $return .= "olms.lesson_status='".$mystatus."';";
@@ -245,7 +262,9 @@ function save_item($lp_id, $user_id, $view_id, $item_id, $score = -1, $max = -1,
     $update_list = $mylp->get_update_queue();
 
     foreach ($update_list as $my_upd_id => $my_upd_status)  {
-        if ($my_upd_id != $item_id) { // Only update the status from other items (i.e. parents and brothers), do not update current as we just did it already.
+        if ($my_upd_id != $item_id) {
+            /* Only update the status from other items (i.e. parents and brothers),
+            do not update current as we just did it already. */
             $return .= "update_toc('".$my_upd_status."','".$my_upd_id."');";
         }
     }
@@ -259,18 +278,20 @@ function save_item($lp_id, $user_id, $view_id, $item_id, $score = -1, $max = -1,
         // If $_SESSION['login_as'] is set, then the user is an admin logged as the user.
         $tbl_track_login = Database :: get_statistic_table(TABLE_STATISTIC_TRACK_E_LOGIN);
 
-        $sql_last_connection = "SELECT login_id, login_date
+        $sql = "SELECT login_id, login_date
             FROM $tbl_track_login
             WHERE login_user_id='".api_get_user_id()."'
             ORDER BY login_date DESC LIMIT 0,1";
 
-        $q_last_connection = Database::query($sql_last_connection);
+        $q_last_connection = Database::query($sql);
         if (Database::num_rows($q_last_connection) > 0) {
             $current_time = api_get_utc_datetime();
             $row = Database::fetch_array($q_last_connection);
             $i_id_last_connection = $row['login_id'];
-            $s_sql_update_logout_date = "UPDATE $tbl_track_login SET logout_date='".$current_time."' WHERE login_id='$i_id_last_connection'";
-            Database::query($s_sql_update_logout_date);
+            $sql = "UPDATE $tbl_track_login
+                    SET logout_date='".$current_time."'
+                    WHERE login_id='$i_id_last_connection'";
+            Database::query($sql);
         }
     }
 
@@ -278,7 +299,7 @@ function save_item($lp_id, $user_id, $view_id, $item_id, $score = -1, $max = -1,
          $return .= "update_stats();";
     }
 
-    //To be sure progress is updated
+    // To be sure progress is updated.
     $mylp->save_last();
 
     Session::write('lpobject', serialize($mylp));