Fixes URL redirection see BT#9277

main/mySpace/myStudents.php

@@ -33,7 +33,6 @@ require_once api_get_path(SYS_CODE_PATH).'survey/survey.lib.php';
 
 api_block_anonymous_users();
 
-
 if (!api_is_allowed_to_create_course() && !api_is_session_admin() && !api_is_drh()) {
     // Check if the user is tutor of the course
     $user_course_status = CourseManager::get_tutor_in_course_status(
@@ -304,8 +303,6 @@ $isDrhOfCourse = CourseManager::isUserSubscribedInCourseAsDrh(
     api_get_course_info()
 );
 
-
-
 if (api_is_drh() && !api_is_platform_admin()) {
     if (!empty($student_id)) {
         if (api_drh_can_access_all_session_content()) {
@@ -352,8 +349,7 @@ if (!empty($student_id)) {
     }
     echo $send_mail;
     if (!empty($student_id) && !empty($_GET['course'])) {
-        //only show link to connection details if course and student were defined in the URL
-
+        // Only show link to connection details if course and student were defined in the URL
         echo '<a href="access_details.php?student=' . $student_id . '&course=' . Security :: remove_XSS($_GET['course']) . '&amp;origin=' . Security :: remove_XSS($_GET['origin']) . '&amp;cidReq='.Security::remove_XSS($_GET['course']).'&amp;id_session='.$session_id.'">'.
             Display :: return_icon('statistics.png', get_lang('AccessDetails'),'',ICON_SIZE_MEDIUM).'</a>';
     }
@@ -418,7 +414,7 @@ if (!empty($student_id)) {
         $last_connection_date = get_lang('NoConnexion');
     }
 
-    // cvs informations
+    // cvs information
     $csv_content[] = array(
         get_lang('Informations', '')
     );
@@ -614,7 +610,6 @@ if (!empty($student_id)) {
     </td>
     </tr>
     </table>
-
     <?php
 
     $table_title = '';
@@ -722,7 +717,7 @@ if (!empty($student_id)) {
                         $progress = empty($progress) ? '0%' : $progress.'%';
                         $score = empty($score) ? '0%' : $score.'%';
 
-                        $csv_content[] = array (
+                        $csv_content[] = array(
                             $session_name,
                             $course_info['title'],
                             $time_spent_on_course,
@@ -733,12 +728,12 @@ if (!empty($student_id)) {
                         );
 
                         echo '<tr>
-    				<td >'.$course_info['title'].'</td>
-    				<td >'.$time_spent_on_course .'</td>
-    				<td >'.$progress.'</td>
-    				<td >'.$score.'</td>
-    				<td >'.$attendances_faults_avg.'</td>
-                    <td >'.$scoretotal_display.'</td>';
+                        <td >'.$course_info['title'].'</td>
+                        <td >'.$time_spent_on_course .'</td>
+                        <td >'.$progress.'</td>
+                        <td >'.$score.'</td>
+                        <td >'.$attendances_faults_avg.'</td>
+                        <td >'.$scoretotal_display.'</td>';
 
                         if (isset ($_GET['id_coach']) && intval($_GET['id_coach']) != 0) {
                             echo '<td width="10"><a href="'.api_get_self().'?student='.$user_info['user_id'].'&details=true&course='.$course_info['code'].'&id_coach='.Security::remove_XSS($_GET['id_coach']).'&origin='.Security::remove_XSS($_GET['origin']).'&id_session='.$session_id.'#infosStudent"><img src="'.api_get_path(WEB_IMG_PATH).'2rightarrow.gif" border="0" /></a></td>';
@@ -827,7 +822,10 @@ if (!empty($student_id)) {
                     array($lp_id),
                     $session_id
                 );
-                if (!empty($total_time)) $any_result = true;
+
+                if (!empty($total_time)) {
+                    $any_result = true;
+                }
 
                 // Get last connection time in lp
                 $start_time = Tracking::get_last_connection_time_in_lp(
@@ -913,14 +911,17 @@ if (!empty($student_id)) {
                     if ($from_myspace) {
                         $from ='&from=myspace';
                     }
-                    $link = Display::url('<img src="../img/2rightarrow.gif" border="0" />','lp_tracking.php?course='.Security::remove_XSS($_GET['course']).$from.'&origin='.Security::remove_XSS($_GET['origin']).'&lp_id='.$learnpath['id'].'&student_id='.$user_info['user_id'].'&id_session='.$session_id);
+                    $link = Display::url(
+                        '<img src="../img/2rightarrow.gif" border="0" />',
+                        'lp_tracking.php?cidReq='.Security::remove_XSS($_GET['course']).'&course='.Security::remove_XSS($_GET['course']).$from.'&origin='.Security::remove_XSS($_GET['origin']).'&lp_id='.$learnpath['id'].'&student_id='.$user_info['user_id'].'&id_session='.$session_id
+                    );
                     echo Display::tag('td', $link);
                 }
 
                 if (api_is_allowed_to_edit()) {
                     echo '<td>';
                     if ($any_result === true) {
-                        echo '<a href="myStudents.php?action=reset_lp&sec_token='.$token.'&course='.Security::remove_XSS($_GET['course']).'&details='.Security::remove_XSS($_GET['details']).'&origin='.Security::remove_XSS($_GET['origin']).'&lp_id='.$learnpath['id'].'&student='.$user_info['user_id'].'&details=true&id_session='.Security::remove_XSS($_GET['id_session']).'">';
+                        echo '<a href="myStudents.php?action=reset_lp&sec_token='.$token.'&cidReq='.Security::remove_XSS($_GET['course']).'&course='.Security::remove_XSS($_GET['course']).'&details='.Security::remove_XSS($_GET['details']).'&origin='.Security::remove_XSS($_GET['origin']).'&lp_id='.$learnpath['id'].'&student='.$user_info['user_id'].'&details=true&id_session='.Security::remove_XSS($_GET['id_session']).'">';
                         echo Display::return_icon('clean.png',get_lang('Clean'),'',ICON_SIZE_SMALL).'</a>';
                         echo '</a>';
                     }