From 248b56202d1cb4eca7bdead771aac5a841e2df4e Mon Sep 17 00:00:00 2001
From: Yannick Warnier <ywarnier@beeznest.org>
Date: Mon, 28 Sep 2020 08:56:53 +0200
Subject: [PATCH] Minor: Scripts: Add exit; statement at the beginning of each
 script

---
 tests/scripts/copy_user_id_to_extra_field.php     | 1 +
 tests/scripts/delete_old_tasks.php                | 2 +-
 tests/scripts/edit_course_html_files.php          | 1 +
 tests/scripts/fix_collations_utf8.php             | 2 +-
 tests/scripts/fix_course_index.php                | 1 +
 tests/scripts/fix_duplicate_settings.php          | 2 +-
 tests/scripts/fix_group_items_with_old_db.php     | 3 ++-
 tests/scripts/fix_lp_calendar.php                 | 2 ++
 tests/scripts/fix_lp_id_to_iid.php                | 1 +
 tests/scripts/fix_lp_id_to_iid_v2.php             | 1 +
 tests/scripts/fix_lp_items_not_found.php          | 1 +
 tests/scripts/fix_lp_missing_documents.php        | 1 +
 tests/scripts/fix_migrations_1.9.x_1.10.0.php     | 2 ++
 tests/scripts/fix_mimetex.php                     | 1 +
 tests/scripts/fix_moodle_migration.php            | 2 ++
 tests/scripts/fix_restored_learnpaths.php         | 1 +
 tests/scripts/fix_student_publication_id.php      | 3 ++-
 tests/scripts/fix_user_id.php                     | 3 +++
 tests/scripts/hide_lp_by_name.php                 | 3 ++-
 tests/scripts/img/list_unused_img.php             | 6 +++++-
 tests/scripts/img/list_used_img.php               | 6 +++++-
 tests/scripts/insert_session_fields.php           | 5 ++++-
 tests/scripts/insert_sessions_categories.php      | 3 +++
 tests/scripts/kill_all_queries.php                | 3 +++
 tests/scripts/login_as_admin.php                  | 1 +
 tests/scripts/move_users.php                      | 4 +++-
 tests/scripts/multi_url_conversion.php            | 6 ++++--
 tests/scripts/packaging/gitlog.php                | 7 +++++++
 tests/scripts/restore_deleted_documents.php       | 4 ++--
 tests/scripts/settings2csv.php                    | 2 ++
 tests/scripts/synchronize_user_base_from_ldap.php | 4 +++-
 tests/scripts/update_lti_chidren_tools.php        | 3 ++-
 tests/scripts/update_user_extra_field.php         | 1 +
 tests/scripts/userfields_to_groups.php            | 4 ++++
 tests/scripts/users_no_course.php                 | 1 +
 35 files changed, 77 insertions(+), 16 deletions(-)

diff --git a/tests/scripts/copy_user_id_to_extra_field.php b/tests/scripts/copy_user_id_to_extra_field.php
index bacaa7815e..c2299a288f 100644
--- a/tests/scripts/copy_user_id_to_extra_field.php
+++ b/tests/scripts/copy_user_id_to_extra_field.php
@@ -3,6 +3,7 @@
 /*
  * Copy user.user_id to extra field ScormStudentId
 */
+exit;
 $extraFieldName = 'ScormStudentId';
 
 use Chamilo\CoreBundle\Entity\ExtraFieldValues;
diff --git a/tests/scripts/delete_old_tasks.php b/tests/scripts/delete_old_tasks.php
index e41cd962b8..f9598ccb0a 100644
--- a/tests/scripts/delete_old_tasks.php
+++ b/tests/scripts/delete_old_tasks.php
@@ -11,7 +11,7 @@
  * @author Percy Santiago <psantiago@icpna.edu.pe>
  * @author Yannick Warnier <yannick.warnier@beeznest.com>
  */
-exit(); //remove this line to execute from the command line
+exit; //remove this line to execute from the command line
 if (PHP_SAPI !== 'cli') {
     die('This script can only be executed from the command line');
 }
diff --git a/tests/scripts/edit_course_html_files.php b/tests/scripts/edit_course_html_files.php
index 6aa3c15642..2465569532 100755
--- a/tests/scripts/edit_course_html_files.php
+++ b/tests/scripts/edit_course_html_files.php
@@ -11,6 +11,7 @@
  * need to move it to an executable folder and change the first require.
  * @author Yannick Warnier <yannick.warnier@beeznest.com>
  */
+ exit;
 require __DIR__.'/../../main/inc/global.inc.php';
 api_protect_admin_script();
 
diff --git a/tests/scripts/fix_collations_utf8.php b/tests/scripts/fix_collations_utf8.php
index adc412e5fb..5127ce844a 100644
--- a/tests/scripts/fix_collations_utf8.php
+++ b/tests/scripts/fix_collations_utf8.php
@@ -11,7 +11,7 @@
  * @author Yannick Warnier <yannick.warnier@beeznest.com>
  */
 // To launch, remove the following line
-die();
+exit;
 require __DIR__.'/../../main/inc/global.inc.php';
 $sql = "SELECT table_name, table_collation FROM information_schema.tables where TABLE_SCHEMA='".$_configuration['main_database']."'";
 $res = Database::query($sql);
diff --git a/tests/scripts/fix_course_index.php b/tests/scripts/fix_course_index.php
index 1cd21c48ab..27283e35da 100644
--- a/tests/scripts/fix_course_index.php
+++ b/tests/scripts/fix_course_index.php
@@ -11,6 +11,7 @@
  * - Check the results in one index.php file
  * - Delete this file
  */
+exit;
 if (PHP_SAPI != 'cli') {
     die('This script can only be launched from the command line');
 }
diff --git a/tests/scripts/fix_duplicate_settings.php b/tests/scripts/fix_duplicate_settings.php
index edeeedb13f..eaac3b75cb 100644
--- a/tests/scripts/fix_duplicate_settings.php
+++ b/tests/scripts/fix_duplicate_settings.php
@@ -4,7 +4,7 @@
  * Remove the current_settings duplicates from migration 1.9.x to 1.10.x
  */
 
-//exit;
+exit;
 
 require_once __DIR__.'/../../main/inc/global.inc.php';
 
diff --git a/tests/scripts/fix_group_items_with_old_db.php b/tests/scripts/fix_group_items_with_old_db.php
index a4e63be259..f2d1a7ee31 100644
--- a/tests/scripts/fix_group_items_with_old_db.php
+++ b/tests/scripts/fix_group_items_with_old_db.php
@@ -21,6 +21,7 @@
 /**
  * Context initialization
  */
+exit;
 if (PHP_SAPI != 'cli') {
     die('This script can only be executed from the command line');
 }
@@ -173,4 +174,4 @@ function getOldGroupsByCourse() {
         }
     }
     return $courses;
-}
\ No newline at end of file
+}
diff --git a/tests/scripts/fix_lp_calendar.php b/tests/scripts/fix_lp_calendar.php
index d954f1a056..a3028e608c 100644
--- a/tests/scripts/fix_lp_calendar.php
+++ b/tests/scripts/fix_lp_calendar.php
@@ -1,6 +1,8 @@
 <?php
+
 /* For licensing terms, see /license.txt */
 
+exit;
 require __DIR__ . '/../../main/inc/global.inc.php';
 
 $extraField = new ExtraField('lp_item');
diff --git a/tests/scripts/fix_lp_id_to_iid.php b/tests/scripts/fix_lp_id_to_iid.php
index 2fb933acd8..1f71a0d817 100644
--- a/tests/scripts/fix_lp_id_to_iid.php
+++ b/tests/scripts/fix_lp_id_to_iid.php
@@ -1,4 +1,5 @@
 <?php
+
 /* For licensing terms, see /license.txt */
 
 /**
diff --git a/tests/scripts/fix_lp_id_to_iid_v2.php b/tests/scripts/fix_lp_id_to_iid_v2.php
index feea3a7ab1..d2334ef101 100644
--- a/tests/scripts/fix_lp_id_to_iid_v2.php
+++ b/tests/scripts/fix_lp_id_to_iid_v2.php
@@ -1,4 +1,5 @@
 <?php
+
 /* For licensing terms, see /license.txt */
 
 /**
diff --git a/tests/scripts/fix_lp_items_not_found.php b/tests/scripts/fix_lp_items_not_found.php
index 38270abba0..05454b3049 100644
--- a/tests/scripts/fix_lp_items_not_found.php
+++ b/tests/scripts/fix_lp_items_not_found.php
@@ -1,4 +1,5 @@
 <?php
+
 /* For licensing terms, see /license.txt */
 
 /**
diff --git a/tests/scripts/fix_lp_missing_documents.php b/tests/scripts/fix_lp_missing_documents.php
index befe08bebe..31d78776fa 100644
--- a/tests/scripts/fix_lp_missing_documents.php
+++ b/tests/scripts/fix_lp_missing_documents.php
@@ -5,6 +5,7 @@
 /**
  * Set id = iid in c_document for a c_lp
  */
+
 exit;
 require_once '../../main/inc/global.inc.php';
 
diff --git a/tests/scripts/fix_migrations_1.9.x_1.10.0.php b/tests/scripts/fix_migrations_1.9.x_1.10.0.php
index 9b70d72fee..a87476b033 100755
--- a/tests/scripts/fix_migrations_1.9.x_1.10.0.php
+++ b/tests/scripts/fix_migrations_1.9.x_1.10.0.php
@@ -1,5 +1,7 @@
 <?php
+
 /* For license terms, see /license.txt */
+
 /**
  * Fix failed migration 1.9.x to 1.10.0
  * Note: You need execute the ./fix_duplicate_settings.php to remove duplicated settings from failed migration
diff --git a/tests/scripts/fix_mimetex.php b/tests/scripts/fix_mimetex.php
index 5d742d77db..b81201dfff 100644
--- a/tests/scripts/fix_mimetex.php
+++ b/tests/scripts/fix_mimetex.php
@@ -1,4 +1,5 @@
 <?php
+
 /* For licensing terms, see /license.txt */
 
 exit;
diff --git a/tests/scripts/fix_moodle_migration.php b/tests/scripts/fix_moodle_migration.php
index ddc4e272db..806c365cbe 100644
--- a/tests/scripts/fix_moodle_migration.php
+++ b/tests/scripts/fix_moodle_migration.php
@@ -1,5 +1,7 @@
 <?php
+
 /* For licensing terms, see /license.txt */
+
 /**
  * This script is a specific script to finetune a complex migration from a
  * Moodle environment, where the usernames and session names need to come
diff --git a/tests/scripts/fix_restored_learnpaths.php b/tests/scripts/fix_restored_learnpaths.php
index 117e95d474..9ac4e3c022 100644
--- a/tests/scripts/fix_restored_learnpaths.php
+++ b/tests/scripts/fix_restored_learnpaths.php
@@ -1,4 +1,5 @@
 <?php
+
 /* For licensing terms, see /license.txt */
 
 exit;
diff --git a/tests/scripts/fix_student_publication_id.php b/tests/scripts/fix_student_publication_id.php
index fd31b433f1..ef870b1905 100644
--- a/tests/scripts/fix_student_publication_id.php
+++ b/tests/scripts/fix_student_publication_id.php
@@ -1,7 +1,8 @@
 <?php
 
+/* For licensing terms, see /license.txt */
+
 exit;
-/* For license terms, see /license.txt */
 if (PHP_SAPI != 'cli') {
     die('This script can only be launched from the command line');
 }
diff --git a/tests/scripts/fix_user_id.php b/tests/scripts/fix_user_id.php
index a5919e7688..849b30ab73 100644
--- a/tests/scripts/fix_user_id.php
+++ b/tests/scripts/fix_user_id.php
@@ -1,8 +1,11 @@
 <?php
+
 /* For licensing terms, see /license.txt */
+
 /**
  * Temporary fix to set user.user_id to the same as user.id
  */
+exit;
 if (PHP_SAPI != 'cli') {
     die('This script can only be executed from the command line');
 }
diff --git a/tests/scripts/hide_lp_by_name.php b/tests/scripts/hide_lp_by_name.php
index 96e1e9eab5..44dee9c191 100644
--- a/tests/scripts/hide_lp_by_name.php
+++ b/tests/scripts/hide_lp_by_name.php
@@ -1,15 +1,16 @@
 <?php
+
 /* For licensing terms, see /license.txt */
 
 /**
  * Batch to hide all LPs with the $nameToSearch name.
  */
 
+exit;
 if (PHP_SAPI != 'cli') {
     die('This script can only be executed from the command line');
 }
 
-exit;
 
 require_once __DIR__.'/../../main/inc/global.inc.php';
 
diff --git a/tests/scripts/img/list_unused_img.php b/tests/scripts/img/list_unused_img.php
index b37a556123..8fc4236ce3 100644
--- a/tests/scripts/img/list_unused_img.php
+++ b/tests/scripts/img/list_unused_img.php
@@ -1,4 +1,7 @@
-<?php /* For licensing terms, see /license.txt */
+<?php
+
+/* For licensing terms, see /license.txt */
+
 /**
  * Cron script to list unused images
  * @package chamilo.cron
@@ -6,6 +9,7 @@
 /**
  * Includes and declarations
  */
+exit;
 if (PHP_SAPI!='cli') {
     die('Run this script through the command line or comment this line in the code');
 }
diff --git a/tests/scripts/img/list_used_img.php b/tests/scripts/img/list_used_img.php
index 664b9b55a7..a451237f90 100644
--- a/tests/scripts/img/list_used_img.php
+++ b/tests/scripts/img/list_used_img.php
@@ -1,4 +1,7 @@
-<?php /* For licensing terms, see /license.txt */
+<?php
+
+/* For licensing terms, see /license.txt */
+
 /**
  * Cron script to list used, but undefined, language variables
  * @package chamilo.cron
@@ -6,6 +9,7 @@
 /**
  * Includes and declarations
  */
+exit;
 if (PHP_SAPI!='cli') { die('Run this script through the command line or comment this line in the code'); }
 require_once __DIR__.'/../../../main/inc/global.inc.php';
 $path = api_get_path(SYS_CODE_PATH).'img/';
diff --git a/tests/scripts/insert_session_fields.php b/tests/scripts/insert_session_fields.php
index 8bd006d90d..f26dbcd326 100644
--- a/tests/scripts/insert_session_fields.php
+++ b/tests/scripts/insert_session_fields.php
@@ -1,9 +1,12 @@
 <?php
+
+/* For licensing terms, see /license.txt */
+
 /*
  * This script insert session extra fields
  */
 
-//exit;
+exit;
 
 require_once '../../main/inc/global.inc.php';
 
diff --git a/tests/scripts/insert_sessions_categories.php b/tests/scripts/insert_sessions_categories.php
index ce52008222..999ae7ad12 100644
--- a/tests/scripts/insert_sessions_categories.php
+++ b/tests/scripts/insert_sessions_categories.php
@@ -1,8 +1,11 @@
 <?php
+
 /* For licensing terms, see /license.txt */
+
 /**
  * This script generates four session categories.
  */
+exit;
 require_once '../../main/inc/global.inc.php';
 api_protect_admin_script();
 
diff --git a/tests/scripts/kill_all_queries.php b/tests/scripts/kill_all_queries.php
index 2bc0076f9e..a26811dacc 100644
--- a/tests/scripts/kill_all_queries.php
+++ b/tests/scripts/kill_all_queries.php
@@ -1,4 +1,7 @@
 <?php
+
+/* For licensing terms, see /license.txt */
+
 /**
  * This script kills all queries to which the Chamilo database user has access
  * through processlist.
diff --git a/tests/scripts/login_as_admin.php b/tests/scripts/login_as_admin.php
index a43d6b8be8..00aa1ab224 100644
--- a/tests/scripts/login_as_admin.php
+++ b/tests/scripts/login_as_admin.php
@@ -1,4 +1,5 @@
 <?php
+
 /* For licensing terms, see /license.txt */
 
 exit;
diff --git a/tests/scripts/move_users.php b/tests/scripts/move_users.php
index cbafbdd296..4a44a8e3d9 100644
--- a/tests/scripts/move_users.php
+++ b/tests/scripts/move_users.php
@@ -1,5 +1,7 @@
 <?php
+
 /* For licensing terms, see /license.txt */
+
 /**
  * Script to move users from one course to another if they haven't taken the
  * test in the first course.
@@ -10,7 +12,7 @@
 /**
  * Init
  */
-die('Remove the "die()" line to execute this script'.PHP_EOL);
+exit;
 require __DIR__.'/../../main/inc/global.inc.php';
 // Define origin and destination courses' code
 $originCourse = 'XYZ2014';
diff --git a/tests/scripts/multi_url_conversion.php b/tests/scripts/multi_url_conversion.php
index 975e9e4fe7..2543ed87fa 100644
--- a/tests/scripts/multi_url_conversion.php
+++ b/tests/scripts/multi_url_conversion.php
@@ -1,12 +1,14 @@
 <?php
-// For licensing terms, see /license.txt
+
+/* For licensing terms, see /license.txt */
+
 /**
  * This script takes a single-URL portal and changes the database so the
  * original portal becomes a secondary URL (not the main admin URL).
  * This means creating a new URL of ID 1 and moving all previous records
  * referencing ID 1 to ID 2.
  */
-die();
+exit;
 require __DIR__.'/../../main/inc/global.inc.php';
 
 $tableAccessUrl = Database::get_main_table(TABLE_MAIN_ACCESS_URL);
diff --git a/tests/scripts/packaging/gitlog.php b/tests/scripts/packaging/gitlog.php
index 2071d12347..9ba7caeaa4 100644
--- a/tests/scripts/packaging/gitlog.php
+++ b/tests/scripts/packaging/gitlog.php
@@ -1,4 +1,7 @@
 <?php
+
+/* For licensing terms, see /license.txt */
+
 /**
  * This script pre-generates a list of commits to generate a changelog in the
  * form (branch, then commits in HTML form, then a final feedback):
@@ -17,6 +20,10 @@
  * @usage php gitlog.php [-t|some-commit|-max20171001]
  * @see https://github.com/ywarnier/git
  */
+exit;
+if (PHP_SAPI != 'cli') {
+    die('This script can only be launched from the command line');
+}
 require 'php-git/src/Git.php';
 $repository = __DIR__.'/../..';
 $number = 2000; //the number of commits to check (including minor)
diff --git a/tests/scripts/restore_deleted_documents.php b/tests/scripts/restore_deleted_documents.php
index 89ed92bf97..5a4d0c0222 100644
--- a/tests/scripts/restore_deleted_documents.php
+++ b/tests/scripts/restore_deleted_documents.php
@@ -1,15 +1,15 @@
 <?php
+
 /* For licensing terms, see /license.txt */
 
 /**
  * Script to restore some deleted documents
  */
 
+exit;
 use Chamilo\CourseBundle\Entity\CDocument;
 use Chamilo\CourseBundle\Entity\CItemProperty;
 
-exit;
-
 require __DIR__.'/../../main/inc/global.inc.php';
 
 api_protect_admin_script();
diff --git a/tests/scripts/settings2csv.php b/tests/scripts/settings2csv.php
index 3591c17963..e2678953b9 100644
--- a/tests/scripts/settings2csv.php
+++ b/tests/scripts/settings2csv.php
@@ -1,5 +1,7 @@
 <?php
+
 /* For licensing terms, see /license.txt */
+
 /**
  * This script generates a CSV file of all settings in the order they appear
  * in the platform settings section, in the given language.
diff --git a/tests/scripts/synchronize_user_base_from_ldap.php b/tests/scripts/synchronize_user_base_from_ldap.php
index 9411a51baa..6c9df26e04 100644
--- a/tests/scripts/synchronize_user_base_from_ldap.php
+++ b/tests/scripts/synchronize_user_base_from_ldap.php
@@ -1,5 +1,7 @@
 <?php
+
 /* For licensing terms, see /license.txt */
+
 /*
 User account synchronisation from LDAP
 
@@ -20,7 +22,7 @@ defined in app/config/auth.conf.php.
 username field is used to identify and match LDAP and Chamilo accounts together.
 ($extldap_user_correspondance['username'])
 */
-
+exit;
 // Change this to the absolute path to chamilo root folder if you move the script out of tests/scripts
 $chamiloRoot = __DIR__.'/../..';
 
diff --git a/tests/scripts/update_lti_chidren_tools.php b/tests/scripts/update_lti_chidren_tools.php
index e6ee21a873..df53baf11d 100644
--- a/tests/scripts/update_lti_chidren_tools.php
+++ b/tests/scripts/update_lti_chidren_tools.php
@@ -1,15 +1,16 @@
 <?php
+
 /* For licensing terms, see /license.txt */
 
 /**
  * Update all children tools created by a LTI tool in courses.
  */
 
+exit;
 use Chamilo\PluginBundle\Entity\ImsLti\ImsLtiTool;
 
 require __DIR__.'/../../main/inc/global.inc.php';
 
-exit;
 
 // Arguments
 $parentLtiToolId = 1;
diff --git a/tests/scripts/update_user_extra_field.php b/tests/scripts/update_user_extra_field.php
index 9c26504ae6..6b3715f485 100644
--- a/tests/scripts/update_user_extra_field.php
+++ b/tests/scripts/update_user_extra_field.php
@@ -1,4 +1,5 @@
 <?php
+
 /* For licensing terms, see /license.txt */
 
 /**
diff --git a/tests/scripts/userfields_to_groups.php b/tests/scripts/userfields_to_groups.php
index 7766ca5cac..3cc1c864c8 100644
--- a/tests/scripts/userfields_to_groups.php
+++ b/tests/scripts/userfields_to_groups.php
@@ -1,8 +1,12 @@
 <?php
+
+/* For licensing terms, see /license.txt */
+
 /**
  * Move user fields "ruc" and "razon_social" to (social) groups (create groups)
  * and assign the related users to those groups.
  */
+exit;
 if (PHP_SAPI != 'cli') {
     die('This script can only be launched from the command line');
 }
diff --git a/tests/scripts/users_no_course.php b/tests/scripts/users_no_course.php
index 85a8f1b4af..f3340eb79e 100644
--- a/tests/scripts/users_no_course.php
+++ b/tests/scripts/users_no_course.php
@@ -1,4 +1,5 @@
 <?php
+
 /* For licensing terms, see /license.txt */
 
 /**