From 25ba3aade52cf303d7cc7f0363a2f6860da4d199 Mon Sep 17 00:00:00 2001 From: Yannick Warnier Date: Thu, 26 Nov 2020 14:02:34 +0100 Subject: [PATCH] Plugin: Positioning: Fix final test calculation in blockFinalExercise() - refs #3644 --- plugin/positioning/src/Positioning.php | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/plugin/positioning/src/Positioning.php b/plugin/positioning/src/Positioning.php index 014e9dc565..c4cf5c204e 100644 --- a/plugin/positioning/src/Positioning.php +++ b/plugin/positioning/src/Positioning.php @@ -128,14 +128,19 @@ class Positioning extends Plugin return true; } - $averageToUnlock = (int) $this->get('average_percentage_to_unlock_final_exercise'); + $averageToUnlock = (float) $this->get('average_percentage_to_unlock_final_exercise'); if (empty($averageToUnlock)) { return false; } // Check average $courseInfo = api_get_course_info_by_id($courseId); - $userAverage = (int) Tracking::getAverageStudentScore($userId, $courseInfo['code'], [], $sessionId); + $userAverage = (float) Tracking::get_avg_student_progress( + $userId, + $courseInfo['code'], + [], + $sessionId + ); if ($userAverage >= $averageToUnlock) { return false;