Making Mkdirs deprecated

skala
Julio Montoya 15 years ago
parent 0385710c80
commit 2eab1d1d09
  1. 47
      main/inc/lib/fileManage.lib.php
  2. 8
      main/inc/lib/groupmanager.lib.php
  3. 1
      tests/main/inc/lib/fileManage.lib.test.php
  4. 1
      tests/main/inc/lib/fileManager.lib.test.php

@ -579,33 +579,38 @@ class FileManager
Database::query($query);
}
/**
* Like in Java, creates the directory named by this abstract pathname,
* including any necessary but nonexistent parent directories.
*
* @author Hugues Peeters <peeters@ipm.ucl.ac.be>
* @author Christophe Gesche <gesche@ipm.ucl.ac.be>
*
* @param string $path - path to create
* @param string $mode - directory permission (default is '770')
*
* @return boolean TRUE if succeeds FALSE otherwise
*/
function mkdirs($path, $mode = '0770') {
if (file_exists($path)) {
return false;
} else {
FileManager :: mkdirs(dirname($path), $mode);
//mkdir($path, $mode);
return true;
}
}
} //end class FileManager
/* DEPRECATED FUNCTIONS */
/**
* Like in Java, creates the directory named by this abstract pathname,
* including any necessary but nonexistent parent directories.
*
* @author Hugues Peeters <peeters@ipm.ucl.ac.be>
* @author Christophe Gesche <gesche@ipm.ucl.ac.be>
*
* @param string $path - path to create
* @param string $mode - directory permission (default is '770')
*
* @return boolean TRUE if succeeds FALSE otherwise
*/
function mkdirs($path, $mode = '0770') {
if (file_exists($path)) {
return false;
} else {
FileManager :: mkdirs(dirname($path), $mode);
//mkdir($path, $mode);
return true;
}
}
/**
* @deprecated 06-FEB-2010. The function mkdir() is able to create directories recursively.
* @link http://php.net/manual/en/function.mkdir.php

@ -209,13 +209,7 @@ class GroupManager {
calendar_state = '".$category['calendar_state']."', work_state = '".$category['work_state']."', announcements_state = '".$category['announcements_state']."', forum_state = '".$category['forum_state']."', wiki_state = '".$category['wiki_state']."', chat_state = '".$category['chat_state']."', self_registration_allowed = '".$category['self_reg_allowed']."', self_unregistration_allowed = '".$category['self_unreg_allowed']."', session_id='".Database::escape_string($my_id_session)."'";
Database::query($sql);
$lastId = Database::insert_id();
/*$secret_directory = uniqid("")."_team_".$lastId;
while (is_dir(api_get_path(SYS_COURSE_PATH).$currentCourseRepository."/group/$secret_directory"))
{
$secret_directory = uniqid("")."_team_".$lastId;
}
FileManager :: mkdirs(api_get_path(SYS_COURSE_PATH).$currentCourseRepository."/group/".$secret_directory, api_get_permissions_for_new_directories());
*/
$desired_dir_name= '/'.replace_dangerous_char($name,'strict').'_groupdocs';
$my_path = api_get_path(SYS_COURSE_PATH).$currentCourseRepository.'/document';

@ -196,6 +196,7 @@ class TestFileManager extends UnitTestCase {
}
public function testMkdirs(){
//This function is deprecated
$path=api_get_path(SYS_COURSE_PATH).'document';
$res = $this->fmanager->mkdirs($path);
$this->assertFalse($res);

@ -191,6 +191,7 @@ class TestFileManager extends UnitTestCase {
}
public function testMkdirs(){
//This function is deprecated
$path='/var/www/path/ruta';
$res = $this->fmanager->mkdirs($path);
$this->assertFalse($res);

Loading…
Cancel
Save