Move allow_session_admin_login_as_teacher to settings bundle - refs BT#15095

main/admin/user_list.php

@@ -580,8 +580,8 @@ function modify_filter($user_id, $url_params, $row)
     //only allow platform admins to login_as, or session admins only for students (not teachers nor other admins)
     $loginAsStatusForSessionAdmins = [$statusname[STUDENT]];
 
-    //except when allow_session_admin_login_as_teacher is enabled, then can login_as teachers also
-    if (api_get_configuration_value('allow_session_admin_login_as_teacher')) {
+    //except when session.allow_session_admin_login_as_teacher is enabled, then can login_as teachers also
+    if (api_get_configuration_value('session.allow_session_admin_login_as_teacher')) {
         $loginAsStatusForSessionAdmins[] = $statusname[COURSEMANAGER];
     }
 

main/inc/lib/api.lib.php

@@ -8263,7 +8263,7 @@ function api_can_login_as($loginAsUserId, $userId = null)
 
     $loginAsStatusForSessionAdmins = [STUDENT];
 
-    if (api_get_configuration_value('allow_session_admin_login_as_teacher')) {
+    if (api_get_setting('session.allow_session_admin_login_as_teacher')) {
         $loginAsStatusForSessionAdmins[] = COURSEMANAGER;
     }
 

main/install/configuration.dist.php

@@ -915,9 +915,6 @@ VALUES (2, 13, 'session_courses_read_only_mode', 'Lock Course In Session', 1, 1,
 // Create a new session extra field called "collapsed" (checkbox yes/no - option)
 // $_configuration['allow_user_session_collapsable'] = false;
 
-// Allow to session admins login as teachers
-//$_configuration['allow_session_admin_login_as_teacher'] = false;
-
 // ------ Custom DB changes (keep this at the end)
 // Add user activation by confirmation email
 // This option prevents the new user to login in the platform if your account is not confirmed via email

src/CoreBundle/Settings/SessionSettingsSchema.php

@@ -48,6 +48,7 @@ class SessionSettingsSchema extends AbstractSettingsSchema
                     'remove_session_url' => 'false',
                     'hide_tab_list' => '',
                     'session_admins_edit_courses_content' => 'false',
+                    'allow_session_admin_login_as_teacher' => 'false',
                 ]
             )
         ;
@@ -102,6 +103,7 @@ class SessionSettingsSchema extends AbstractSettingsSchema
             ->add('remove_session_url', YesNoType::class)
             ->add('hide_tab_list')
             ->add('session_admins_edit_courses_content', YesNoType::class)
+            ->add('allow_session_admin_login_as_teacher', YesNoType::class)
         ;
     }
 }