From 2fc355cfbb40c9a25989bb60c8de79e36f575822 Mon Sep 17 00:00:00 2001
From: Julio Montoya <gugli100@gmail.com>
Date: Fri, 28 Dec 2012 17:12:39 +0100
Subject: [PATCH] Adding test for notaDetalles, adding error logs using key
 "name" as score see BT#5622

---
 tests/migrate/migration.class.php        |  3 ++-
 tests/migrate/migration.custom.class.php | 19 +++++++++++--------
 2 files changed, 13 insertions(+), 9 deletions(-)

diff --git a/tests/migrate/migration.class.php b/tests/migrate/migration.class.php
index db408408c1..117d612e32 100644
--- a/tests/migrate/migration.class.php
+++ b/tests/migrate/migration.class.php
@@ -785,6 +785,8 @@ class Migration {
         $result = self::soap_call($web_service_params,'transacciones', array('ultimo' => 354911, 'cantidad' => 2));
         */
 
+        $result = self::soap_call($web_service_params, 'notaDetalles',  array('uididpersona' => 'FC30EE0F-5C6F-4934-884B-BE7B68F96164', 'uididprograma' => 'bc0bdf04-cc08-4817-97c7-72840ca1171c', 'intIdSede' => 3));
+
         if (empty($branch_id)) {
             $branches = self::get_branches();
         } else {
@@ -976,7 +978,6 @@ class Migration {
                     }
                 } else {
                     $message .= Display::return_message("Transaction NOT added to Chamilo. {$transaction_result['message']}", 'warning');
-                    //$transaction_chamilo_info = MigrationCustom::process_transaction($result, false);
                 }
 
                 if (!empty($transaction_chamilo_info)) {
diff --git a/tests/migrate/migration.custom.class.php b/tests/migrate/migration.custom.class.php
index 3f8cd2f649..e89c6fa7bd 100644
--- a/tests/migrate/migration.custom.class.php
+++ b/tests/migrate/migration.custom.class.php
@@ -1558,7 +1558,7 @@ error_log('Editing extra field: '.print_r($extra_field_option_info,1));
         if ($data['error'] == false) {
             $uidIdPrograma = $original_data['orig_id'];
             $uidIdPersona  = $original_data['item_id'];
-            $score          = $data['infoextra'];
+            $score         = $data['name'];
 
             $session_id = self::get_session_id_by_programa_id($uidIdPrograma);
             $user_id = self::get_user_id_by_persona_id($uidIdPersona);
@@ -1592,13 +1592,13 @@ error_log('Editing extra field: '.print_r($extra_field_option_info,1));
 
                         //Try to create a gradebook evaluation
                         if (empty($evals_found)) {
+                            error_log("Trying to create a new evaluation in course code:  {$course_data['code']} - session_id: $session_id");
                             $params = array(
                                 'session_id' => $session_id,
                                 'gradebook_description' =>  'Evaluación General',
                                 'gradebook_evaluation_type_id' => 0
                             );
                             self::create_gradebook_evaluation($params);
-                            error_log("Trying to create a new evaluation in course code:  {$course_data['code']} - session_id: $session_id");
                             $evals_found = $eval->load(null, null, null, $gradebook['id'], null, null);
                         }
 
@@ -1659,7 +1659,8 @@ error_log('Editing extra field: '.print_r($extra_field_option_info,1));
         $data = Migration::soap_call($web_service_details, 'notaDetalles', array(
             'uididpersona' => $original_data['item_id'],
             'uididprograma'=> $original_data['orig_id'],
-            'intIdSede'    => $original_data['branch_id']));
+            'intIdSede'    => $original_data['branch_id']
+        ));
 
         if ($data['error'] == false) {
             $uidIdPrograma = $original_data['orig_id'];
@@ -1709,7 +1710,6 @@ error_log('Editing extra field: '.print_r($extra_field_option_info,1));
                                 $res->delete();
 
                                 $eval_result = Result :: load (null, $user_id, $eval_id);
-
                                 return array(
                                     'entity' => 'gradebook_evaluation_result',
                                     'before' => $check_result,
@@ -1748,12 +1748,13 @@ error_log('Editing extra field: '.print_r($extra_field_option_info,1));
         $data = Migration::soap_call($web_service_details, 'notaDetalles', array(
             'uididpersona' => $original_data['item_id'],
             'uididprograma'=> $original_data['orig_id'],
-            'intIdSede'    => $original_data['branch_id']));
+            'intIdSede'    => $original_data['branch_id']
+        ));
 
         if ($data['error'] == false) {
             $uidIdPrograma = $original_data['orig_id'];
             $uidIdPersona  = $original_data['item_id'];
-            $score         = $data['infoextra'];
+            $score         = $data['name'];
 
             $session_id = self::get_session_id_by_programa_id($uidIdPrograma);
             $user_id = self::get_user_id_by_persona_id($uidIdPersona);
@@ -1786,21 +1787,23 @@ error_log('Editing extra field: '.print_r($extra_field_option_info,1));
 
                         //Try to create a gradebook evaluation
                         if (empty($evals_found)) {
+                            error_log("Trying to create a new evaluation in course code:  {$course_data['code']} - session_id: $session_id");
+
                             $params = array(
                                 'session_id' => $session_id,
                                 'gradebook_description' =>  'Evaluación General',
                                 'gradebook_evaluation_type_id' => 0
                             );
                             self::create_gradebook_evaluation($params);
-                            error_log("Trying to create a new evaluation in course code:  {$course_data['code']} - session_id: $session_id");
                             $evals_found = $eval->load(null, null, null, $gradebook['id'], null, null);
                         }
 
                         if (!empty($evals_found)) {
-                            error_log("Gradebook exists: {$gradebook['id']}");
                             $evaluation = current($evals_found);
                             $eval_id = $evaluation->get_id();
 
+                            error_log("Gradebook exists: {$gradebook['id']} eval_id: $eval_id");
+
                             //Eval found
                             $res = new Result();
                             $check_result = Result :: load (null, $user_id, $eval_id);