From 2ffb1a0c05b4da618b6c825db98a2b0189384c2b Mon Sep 17 00:00:00 2001 From: Julio Montoya Date: Mon, 26 Nov 2018 13:00:13 +0100 Subject: [PATCH] Minor - update from 1.11.x --- main/announcements/announcements.php | 19 +- main/course_home/activity.php | 110 +- main/course_progress/thematic.php | 18 +- main/coursecopy/import_moodle.php | 15 +- main/exercise/TestCategory.php | 10 +- main/exercise/exercise.class.php | 4 +- main/exercise/question_pool.php | 73 +- .../gradebook/lib/fe/gradebooktable.class.php | 1 + main/group/group_space.php | 10 +- main/inc/ajax/agenda.ajax.php | 6 +- main/inc/ajax/lp.ajax.php | 10 +- main/inc/ajax/statistics.ajax.php | 2 - main/inc/lib/AnnouncementManager.php | 22 +- main/inc/lib/MoodleImport.php | 972 +++++++++--------- main/inc/lib/agenda.lib.php | 3 +- main/inc/lib/attendance.lib.php | 7 +- main/inc/lib/course.lib.php | 22 +- main/inc/lib/course_home.lib.php | 469 +++++---- main/inc/lib/document.lib.php | 1 + main/inc/lib/exercise.lib.php | 2 +- .../lib/formvalidator/FormValidator.class.php | 86 -- main/inc/lib/groupmanager.lib.php | 24 +- main/inc/lib/pear/HTML/Common.php | 16 +- main/inc/lib/pear/HTML/QuickForm.php | 6 +- main/inc/lib/pear/HTML/QuickForm/Renderer.php | 1 - main/inc/lib/pear/HTML/QuickForm/checkbox.php | 7 +- main/inc/lib/pear/HTML/QuickForm/element.php | 93 +- main/inc/lib/pear/HTML/QuickForm/file.php | 3 +- main/inc/lib/pear/HTML/QuickForm/input.php | 25 - main/inc/lib/pear/HTML/QuickForm/label.php | 10 - main/inc/lib/pear/HTML/QuickForm/link.php | 4 - main/inc/lib/pear/HTML/QuickForm/reset.php | 8 - main/inc/lib/pear/HTML/QuickForm/static.php | 30 - main/inc/lib/pear/HTML/QuickForm/submit.php | 11 +- main/inc/lib/pear/HTML/QuickForm/textarea.php | 29 +- main/inc/lib/social.lib.php | 5 +- main/inc/lib/userportal.lib.php | 10 +- main/inc/lib/zombie/zombie_manager.class.php | 21 +- main/inc/lib/zombie/zombie_report.class.php | 114 +- main/install/install.lib.php | 116 ++- main/lp/learnpath.class.php | 19 +- main/lp/learnpathItem.class.php | 28 +- main/lp/lp_add_item.php | 1 - main/lp/scorm_api.php | 2 + main/messages/inbox.php | 1 - main/mySpace/exercise_category_report.php | 6 +- main/mySpace/lp_tracking.php | 2 +- main/social/personal_data.php | 1 - main/survey/create_meeting.php | 2 +- main/survey/reporting.php | 1 - main/survey/surveyUtil.class.php | 9 +- main/work/add_document.php | 11 +- 52 files changed, 1133 insertions(+), 1345 deletions(-) diff --git a/main/announcements/announcements.php b/main/announcements/announcements.php index e6ccc7e404..78615057e8 100755 --- a/main/announcements/announcements.php +++ b/main/announcements/announcements.php @@ -41,7 +41,6 @@ $allowToEdit = ( $sessionId = api_get_session_id(); $drhHasAccessToSessionContent = api_drh_can_access_all_session_content(); - if (!empty($sessionId) && $drhHasAccessToSessionContent) { $allowToEdit = $allowToEdit || api_is_drh(); } @@ -66,12 +65,12 @@ $isTutor = false; if (!empty($group_id)) { $groupProperties = GroupManager:: get_group_properties($group_id); $interbreadcrumb[] = [ - "url" => api_get_path(WEB_CODE_PATH)."group/group.php?".api_get_cidreq(), - "name" => get_lang('Groups'), + 'url' => api_get_path(WEB_CODE_PATH)."group/group.php?".api_get_cidreq(), + 'name' => get_lang('Groups'), ]; $interbreadcrumb[] = [ - "url" => api_get_path(WEB_CODE_PATH)."group/group_space.php?".api_get_cidreq(), - "name" => get_lang('GroupSpace').' '.$groupProperties['name'], + 'url' => api_get_path(WEB_CODE_PATH)."group/group_space.php?".api_get_cidreq(), + 'name' => get_lang('GroupSpace').' '.$groupProperties['name'], ]; if ($allowToEdit === false) { @@ -86,7 +85,7 @@ if (!empty($group_id)) { /* Tracking */ Event::event_access_tool(TOOL_ANNOUNCEMENT); -$announcement_id = isset($_GET['id']) ? intval($_GET['id']) : null; +$announcement_id = isset($_GET['id']) ? (int) $_GET['id'] : null; $action = isset($_GET['action']) ? Security::remove_XSS($_GET['action']) : 'list'; $announcement_number = AnnouncementManager::getNumberAnnouncements(); @@ -118,8 +117,9 @@ switch ($action) { $announcementInfo = AnnouncementManager::get_by_id($courseId, $thisAnnouncementId); $sql = "SELECT DISTINCT announcement.id, announcement.display_order - FROM $tbl_announcement announcement, - $tbl_item_property itemproperty + FROM $tbl_announcement announcement + INNER JOIN $tbl_item_property itemproperty + ON (announcement.c_id = itemproperty.c_id) WHERE announcement.c_id = $courseId AND itemproperty.c_id = $courseId AND @@ -555,7 +555,8 @@ switch ($action) { if (!isset($parts[1]) || empty($parts[1])) { continue; } - $form->addHtml(" + $form->addHtml( + "