diff --git a/.travis.yml b/.travis.yml index f518025e2e..a12e6fb78b 100755 --- a/.travis.yml +++ b/.travis.yml @@ -52,4 +52,5 @@ script: # configure notifications (email, IRC, campfire etc) notifications: - irc: "irc.freenode.org#chamilo" \ No newline at end of file + # IRC notifications - disabled for creating a lot of noise on the channel + # irc: "irc.freenode.org#chamilo" diff --git a/main/admin/add_users_to_group.php b/main/admin/add_users_to_group.php index 3b2afad310..c28938c1e1 100755 --- a/main/admin/add_users_to_group.php +++ b/main/admin/add_users_to_group.php @@ -448,9 +448,9 @@ if (!empty($errorMsg)) { - +

- + diff --git a/main/admin/add_users_to_session.php b/main/admin/add_users_to_session.php index 4f81e5f6d1..f63f8af23c 100755 --- a/main/admin/add_users_to_session.php +++ b/main/admin/add_users_to_session.php @@ -90,19 +90,12 @@ function search_users($needle, $type) $order_clause = ' ORDER BY official_code, firstname, lastname, username'; } - if (api_is_session_admin() - && isset($_configuration['prevent_session_admins_to_manage_all_users']) - && $_configuration['prevent_session_admins_to_manage_all_users'] == 'true' - ) { + if (api_is_session_admin() && api_get_setting('prevent_session_admins_to_manage_all_users') === 'true') { $order_clause = " AND user.creator_id = " . api_get_user_id() . $order_clause; } $cond_user_id = ''; - if (api_is_session_admin() && api_get_setting('prevent_session_admins_to_manage_all_users') == 'true') { - $order_clause = " AND user.creator_id = ".api_get_user_id().$order_clause; - } - // Only for single & multiple if (in_array($type, array('single','multiple'))) if (!empty($id_session)) { @@ -411,7 +404,9 @@ if ($ajax_search) { } } } - + if (api_is_session_admin() && api_get_setting('prevent_session_admins_to_manage_all_users') === 'true') { + $order_clause = " AND u.creator_id = " . api_get_user_id() . $order_clause; + } if ($use_extra_fields) { $sql = "SELECT user_id, lastname, firstname, username, id_session, official_code FROM $tbl_user u diff --git a/main/admin/user_list.php b/main/admin/user_list.php index b55eed7820..8a42993577 100755 --- a/main/admin/user_list.php +++ b/main/admin/user_list.php @@ -124,6 +124,25 @@ $(document).ready(function() { document.getElementById(\'extra_data_text\').style.display="none"; } } + + $(".agenda_opener").click(function() { + var url = this.href; + var dialog = $("#dialog"); + + if ($("#dialog").length == 0) { + dialog = $(\'
\').appendTo(\'body\'); + } + // load remote content + dialog.load( + url, + {}, + function(responseText, textStatus, XMLHttpRequest) { + dialog.dialog({width:720, height:550, modal:true}); + } + ); + //prevent the browser to follow the link + return false; + }); }); //Load user calendar diff --git a/main/auth/courses.php b/main/auth/courses.php index a8f45ce586..e43e5cf1e6 100755 --- a/main/auth/courses.php +++ b/main/auth/courses.php @@ -19,7 +19,7 @@ if (api_get_setting('show_courses_descriptions_in_catalog') == 'true') { $htmlHeadXtra[] = ' '; diff --git a/main/template/default/gradebook/certificate_report.tpl b/main/template/default/gradebook/certificate_report.tpl index 67f3fdc953..8fc6dc3a1d 100644 --- a/main/template/default/gradebook/certificate_report.tpl +++ b/main/template/default/gradebook/certificate_report.tpl @@ -109,7 +109,7 @@ {% for certificate in student.certificates %} - {{ 'Certificate' | get_lang }} + {{ 'Certificate' | get_lang }} {% endfor %} diff --git a/main/template/default/skill/skill_tree.tpl b/main/template/default/skill/skill_tree.tpl index fc704d4c97..95432e7601 100755 --- a/main/template/default/skill/skill_tree.tpl +++ b/main/template/default/skill/skill_tree.tpl @@ -69,7 +69,7 @@ jsPlumb.ready(function() { }); //Return to root button - $('#return_to_root').live('click', function(){ + $('#return_to_root').click(function(){ clean_values(); console.log('Clean values'); console.log('Reopen the root '); @@ -193,7 +193,7 @@ jsPlumb.ready(function() { }); //Clicking in a box skill (we use live instead of bind because we're creating divs on the fly ) - $(".open_block").live('click', function() { + $(".open_block").click(function() { var id = $(this).attr('id'); console.log('click.open_block id: ' + id); @@ -271,7 +271,7 @@ jsPlumb.ready(function() { }); //Skill title click - $(".edit_block").live('click',function() { + $(".edit_block").click(function() { var my_id = $(this).attr('id'); my_id = my_id.split('_')[2]; diff --git a/main/template/default/skill/skill_tree_student.tpl b/main/template/default/skill/skill_tree_student.tpl index fdb7dab51c..e44bfd03be 100755 --- a/main/template/default/skill/skill_tree_student.tpl +++ b/main/template/default/skill/skill_tree_student.tpl @@ -41,7 +41,7 @@ jsPlumb.bind("ready", function() { }); //Clicking in a box skill (we use live instead of bind because we're creating divs on the fly ) - $(".open_block").live('click', function() { + $(".open_block").click(function() { var id = $(this).attr('id'); console.log('click.open_block id: ' + id); @@ -119,7 +119,7 @@ jsPlumb.bind("ready", function() { }); - $(".edit_block").live('click',function() { + $(".edit_block").click(function() { var my_id = $(this).attr('id'); my_id = my_id.split('_')[2]; diff --git a/plugin/courselegal/CourseLegalPlugin.php b/plugin/courselegal/CourseLegalPlugin.php index 2ba254f78b..753e19e43b 100755 --- a/plugin/courselegal/CourseLegalPlugin.php +++ b/plugin/courselegal/CourseLegalPlugin.php @@ -112,7 +112,7 @@ class CourseLegalPlugin extends Plugin * @param int $courseCode * @param int $sessionId * @param boolean $sendEmail Optional. Indicate whether the mail must be sent. Default is true - * @return bool + * @return mixed */ public function saveUserLegal($userId, $courseCode, $sessionId, $sendEmail = true) { diff --git a/plugin/ticket/src/tutor.php b/plugin/ticket/src/tutor.php index 4afede4b01..91512309f8 100755 --- a/plugin/ticket/src/tutor.php +++ b/plugin/ticket/src/tutor.php @@ -13,26 +13,27 @@ require_once 'tutor_report.lib.php'; $htmlHeadXtra[] = '