From 4455484b8a56f5db70b316cc5014dba1a338deec Mon Sep 17 00:00:00 2001 From: Julio Montoya Date: Fri, 3 Aug 2018 08:19:13 +0200 Subject: [PATCH 01/11] Minor - Get correct user #2554 --- main/auth/inscription.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/main/auth/inscription.php b/main/auth/inscription.php index 923b95ea8f..7b0ce68d19 100755 --- a/main/auth/inscription.php +++ b/main/auth/inscription.php @@ -898,7 +898,7 @@ if ($form->validate()) { Event::addEvent( LOG_TERM_CONDITION_ACCEPTED, LOG_USER_OBJECT, - api_get_user_info(), + api_get_user_info($user_id), api_get_utc_datetime() ); From c4ad69395994fb8fca2b93b0c6bea84ac8aca52c Mon Sep 17 00:00:00 2001 From: Julio Montoya Date: Fri, 3 Aug 2018 08:33:07 +0200 Subject: [PATCH 02/11] Minor - flint fixes --- main/cron/lang/langstats.class.php | 1 + main/cron/lang/list_unused_langvars.php | 1 - main/exercise/MultipleAnswerTrueFalseDegreeCertainty.php | 2 +- main/extra/myStudents.php | 3 +-- main/inc/lib/template.lib.php | 1 + main/lp/lp_final_item.php | 2 +- 6 files changed, 5 insertions(+), 5 deletions(-) diff --git a/main/cron/lang/langstats.class.php b/main/cron/lang/langstats.class.php index 6d0ad415ac..60c630d125 100755 --- a/main/cron/lang/langstats.class.php +++ b/main/cron/lang/langstats.class.php @@ -139,6 +139,7 @@ class langstats return $this->db->lastInsertRowID(); } } + return true; } diff --git a/main/cron/lang/list_unused_langvars.php b/main/cron/lang/list_unused_langvars.php index 9ff99b3934..68154b99e5 100755 --- a/main/cron/lang/list_unused_langvars.php +++ b/main/cron/lang/list_unused_langvars.php @@ -61,7 +61,6 @@ foreach ($files as $file) { } $usedTerms[$term] = $shortFile; } - } } else { $myTerms = []; diff --git a/main/exercise/MultipleAnswerTrueFalseDegreeCertainty.php b/main/exercise/MultipleAnswerTrueFalseDegreeCertainty.php index 482ccd34be..e07d0d8020 100644 --- a/main/exercise/MultipleAnswerTrueFalseDegreeCertainty.php +++ b/main/exercise/MultipleAnswerTrueFalseDegreeCertainty.php @@ -1311,7 +1311,7 @@ class MultipleAnswerTrueFalseDegreeCertainty extends Question .api_get_cidreq() ."&id=$exeId'>"; $exerciseTitle = $objExercise->title; - + $message .= sprintf( get_lang('MessageQuestionCertainty'), $exerciseTitle, diff --git a/main/extra/myStudents.php b/main/extra/myStudents.php index ebedee26c5..55e1192db8 100644 --- a/main/extra/myStudents.php +++ b/main/extra/myStudents.php @@ -64,7 +64,6 @@ if (isset($_GET['from']) && $_GET['from'] == 'myspace') { $this_section = SECTION_COURSES; } - $nameTools = get_lang('StudentDetails'); $em = Database::getManager(); @@ -592,7 +591,7 @@ if (!empty($studentId)) { 'absmiddle', 'hspace' => '3px'] diff --git a/main/inc/lib/template.lib.php b/main/inc/lib/template.lib.php index 6bda632326..24ce8cf73d 100755 --- a/main/inc/lib/template.lib.php +++ b/main/inc/lib/template.lib.php @@ -1376,6 +1376,7 @@ class Template { $queryString = empty($_SERVER['QUERY_STRING']) ? '' : $_SERVER['QUERY_STRING']; $requestURI = empty($_SERVER['REQUEST_URI']) ? '' : $_SERVER['REQUEST_URI']; + return [ 'web' => api_get_path(WEB_PATH), 'web_url' => api_get_web_url(), diff --git a/main/lp/lp_final_item.php b/main/lp/lp_final_item.php index f4206864ba..44502bc63d 100644 --- a/main/lp/lp_final_item.php +++ b/main/lp/lp_final_item.php @@ -54,7 +54,7 @@ if ($checker) { 'normal', false ), - ''. $url .'' + ''.$url.'' ); $tpl->assign('content', $content); $tpl->display_blank_template(); From bfe18800f7948b2d58af709060eba9a73bf2c449 Mon Sep 17 00:00:00 2001 From: Julio Montoya Date: Fri, 3 Aug 2018 08:49:24 +0200 Subject: [PATCH 03/11] Minor - format code, use (int) casting --- main/lp/lp_view.php | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/main/lp/lp_view.php b/main/lp/lp_view.php index 6c2c3a9068..95bb07e833 100755 --- a/main/lp/lp_view.php +++ b/main/lp/lp_view.php @@ -35,7 +35,7 @@ $show_learnpath = true; api_protect_course_script(); -$lp_id = !empty($_GET['lp_id']) ? intval($_GET['lp_id']) : 0; +$lp_id = !empty($_GET['lp_id']) ? (int) $_GET['lp_id'] : 0; $sessionId = api_get_session_id(); $course_code = api_get_course_id(); $course_id = api_get_course_int_id(); @@ -60,8 +60,8 @@ $visibility = api_get_item_visibility( $sessionId ); -if (!api_is_allowed_to_edit(false, true, false, false) && - intval($visibility) == 0 +if ($visibility === 0 && + !api_is_allowed_to_edit(false, true, false, false) ) { api_not_allowed(true); } @@ -113,7 +113,7 @@ if (!$is_allowed_to_edit) { } } -$platform_theme = api_get_setting('stylesheets'); // Platform's css. +$platform_theme = api_get_setting('stylesheets'); $my_style = $platform_theme; $ajaxUrl = api_get_path(WEB_AJAX_PATH).'lp.ajax.php?a=get_item_prerequisites&'.api_get_cidreq(); $htmlHeadXtra[] = '