diff --git a/documentation/changelog.html b/documentation/changelog.html index 6013ee0817..d8f9297125 100644 --- a/documentation/changelog.html +++ b/documentation/changelog.html @@ -165,6 +165,7 @@
  • Fixed a bug in migration for several versions at once whereby new course tools were repeated several times (SVN#17935)
  • Fixed security issue allowing users to upload php files on the server through FCKEditor (FS#2970)
  • Fixed folders by default into document tool must not be removed - see FS#3611
  • +
  • Fixed qualification of themes into forum tool - see FS#3609

  • CSS changes

    diff --git a/main/forum/editpost.php b/main/forum/editpost.php index 5effe99a51..9e162c3b3b 100644 --- a/main/forum/editpost.php +++ b/main/forum/editpost.php @@ -102,6 +102,20 @@ $nameTools=get_lang('Forum'); */ include('forumconfig.inc.php'); include('forumfunction.inc.php'); + +// javascript +$htmlHeadXtra[] = ''; /* ============================================================================== diff --git a/main/forum/forumbody.inc.php b/main/forum/forumbody.inc.php index a25673c27b..b512633a58 100644 --- a/main/forum/forumbody.inc.php +++ b/main/forum/forumbody.inc.php @@ -63,7 +63,7 @@ $output .= '
    '.get_lang('Qualification').' :
    -   '.get_lang('MaxScore').' : '.$max_qualify.'
    +   '.get_lang('MaxScore').' : '.$max_qualify.' diff --git a/main/forum/forumfunction.inc.php b/main/forum/forumfunction.inc.php index 9fd17b43da..ae59464ec7 100644 --- a/main/forum/forumfunction.inc.php +++ b/main/forum/forumfunction.inc.php @@ -1876,14 +1876,17 @@ function show_add_post_form($action='', $id='', $form_values='') { if( (api_is_course_admin() || api_is_course_coach() || api_is_course_tutor()) && !($my_thread) ){ // thread qualify - - $form->addElement('static','Group','
    '.get_lang('AdvancedParameters').'
    '); + + $form->addElement('static','Group',''.get_lang('AdvancedParameters').''); $form->addElement('html',''); } @@ -1925,7 +1928,11 @@ function show_add_post_form($action='', $id='', $form_values='') { if( $form->validate() ) { $check = Security::check_token('post'); if ($check) { - $values = $form->exportValues(); + $values = $form->exportValues(); + if($values['thread_qualify_gradebook']=='1' && empty($values['weight_calification'])){ + Display::display_error_message(get_lang('YouMustAssignWeightOfQualification').' '.get_lang('Back').'',false); + return false; + } Security::clear_token(); return $values; } @@ -1958,7 +1965,7 @@ function show_add_post_form($action='', $id='', $form_values='') { function store_theme_qualify($user_id,$thread_id,$thread_qualify=0,$qualify_user_id=0,$qualify_time,$session_id=null) { $table_threads_qualify = Database::get_course_table(TABLE_FORUM_THREAD_QUALIFY,''); $table_threads =Database::get_course_table(TABLE_FORUM_THREAD,''); - if ($user_id==strval(intval($user_id)) && $thread_id==strval(intval($thread_id)) && $thread_qualify==strval(intval($thread_qualify))) { + if ($user_id==strval(intval($user_id)) && $thread_id==strval(intval($thread_id)) && $thread_qualify==strval(floatval($thread_qualify))) { //testing @@ -1974,7 +1981,7 @@ function store_theme_qualify($user_id,$thread_id,$thread_qualify=0,$qualify_user if ($row[0]==0) { $sql="INSERT INTO $table_threads_qualify (user_id," . "thread_id,qualify,qualify_user_id,qualify_time,session_id)" . - "VALUES('".$user_id."','".$thread_id."','".$thread_qualify."'," . + "VALUES('".$user_id."','".$thread_id."',".(float)$thread_qualify."," . "'".$qualify_user_id."','".$qualify_time."','".$session_id."')"; $res=api_sql_query($sql,__FILE__,__LINE__); @@ -2086,7 +2093,7 @@ function store_qualify_historical($option,$couser_id,$forum_id,$user_id,$thread_ //insert thread_historical $sql1="INSERT INTO $table_threads_qualify_log (user_id," . "thread_id,qualify,qualify_user_id,qualify_time,session_id)" . - "VALUES('".$user_id."','".$thread_id."','".$row[0]."'," . + "VALUES('".$user_id."','".$thread_id."',".(float)$row[0]."," . "'".$qualify_user_id."','".$row[1]."','')"; api_sql_query($sql1,__FILE__,__LINE__); @@ -2258,14 +2265,22 @@ function show_edit_post_form($current_post, $current_thread, $current_forum, $fo $form->addElement('html_editor', 'post_text', get_lang('Text')); if (!isset($_GET['edit'])) { - $form->addElement('static','Group','
    '.get_lang('AdvancedParameters').'
    '); + $form->addElement('static','Group',''.get_lang('AdvancedParameters').''); $form->addElement('html',''; } else {