Improve duplicate code performance

pull/2827/head
Julio Montoya 7 years ago
parent 9b0dc03e3f
commit 3f1a59978b
  1. 2
      main/exercise/admin.php
  2. 6
      main/exercise/question.class.php

@ -252,7 +252,7 @@ if (!empty($clone_question) && !empty($objExercise->id)) {
$new_answer_obj->duplicate($new_question_obj);
// Reloading tne $objExercise obj
$objExercise->read($objExercise->id);
$objExercise->read($objExercise->id, false);
header('Location: admin.php?'.api_get_cidreq().'&exerciseId='.$objExercise->id.'&page='.$page);
exit;

@ -1261,9 +1261,9 @@ abstract class Question
// checks if the exercise ID is not in the list
if (!in_array($exerciseId, $this->exerciseList)) {
$this->exerciseList[] = $exerciseId;
$new_exercise = new Exercise();
$new_exercise->read($exerciseId);
$count = $new_exercise->selectNbrQuestions();
$newExercise = new Exercise();
$newExercise->read($exerciseId, false);
$count = $newExercise->getQuestionCount();
$count++;
$sql = "INSERT INTO $exerciseRelQuestionTable (c_id, question_id, exercice_id, question_order)
VALUES ({$this->course['real_id']}, ".intval($id).", ".intval($exerciseId).", '$count')";

Loading…
Cancel
Save