Fix PHP warning, format code

main/admin/dashboard_add_courses_to_user.php

@@ -159,7 +159,7 @@ $UserList = array();
 
 $msg = '';
 if (isset($_POST['formSent']) && intval($_POST['formSent']) == 1) {
-    $courses_list = $_POST['CoursesList'];
+    $courses_list = isset($_POST['CoursesList']) ? $_POST['CoursesList'] : [];
     $affected_rows = CourseManager::subscribeCoursesToDrhManager($user_id, $courses_list);
     if ($affected_rows)	{
         $msg = get_lang('AssignedCoursesHaveBeenUpdatedSuccessfully');
@@ -228,7 +228,7 @@ if(!empty($msg)) {
 <div class="row">
     <div class="col-md-4">
         <h5><?php echo get_lang('CoursesListInPlatform') ?> :</h5>
-        
+
         <div id="ajax_list_courses_multiple">
 	<select id="origin" name="NoAssignedCoursesList[]" multiple="multiple" size="20" style="width:340px;">
 	<?php while ($enreg = Database::fetch_array($result)) { ?>
@@ -236,7 +236,7 @@ if(!empty($msg)) {
 	<?php } ?>
 	</select>
         </div>
-        
+
     </div>
     <div class="col-md-4">
         <div class="code-course">
@@ -262,10 +262,10 @@ if(!empty($msg)) {
             <div class="separate-action">
                 <?php echo '<button class="btn btn-success" type="button" value="" onclick="valide()" >'.$tool_name.'</button>'; ?>
             </div>
-        </div>    
-        
-        
-        
+        </div>
+
+
+
     </div>
     <div class="col-md-4">
         <h5><?php
@@ -277,7 +277,7 @@ if(!empty($msg)) {
 			echo get_lang('AssignedCoursesListToHumanResourcesManager');
 		}
             ?>: </h5>
-        
+
         <select id='destination' name="CoursesList[]" multiple="multiple" size="20" style="width:320px;">
             <?php
             if (is_array($assigned_courses_to_hrm)) {

main/inc/lib/api.lib.php

@@ -7362,7 +7362,8 @@ function api_remove_tags_with_space($in_html, $in_double_quote_replace = true) {
 function api_drh_can_access_all_session_content()
 {
     $a = api_get_setting('drh_can_access_all_session_content');
-    return $a == 'true';
+
+    return $a === 'true';
 }
 
 /**

main/inc/lib/usermanager.lib.php

@@ -4052,7 +4052,7 @@ class UserManager
 
         $userId = intval($userId);
 
-        $limitCondition = null;
+        $limitCondition = '';
 
         if (isset($from) && isset($numberItems)) {
             $from = intval($from);
@@ -4211,6 +4211,7 @@ class UserManager
 
         $sql .= $orderBy;
         $sql .= $limitCondition;
+
         $result = Database::query($sql);
         $users = array();
         if (Database::num_rows($result) > 0) {

main/mySpace/users.php

@@ -56,8 +56,7 @@ function get_users($from, $limit, $column, $direction)
     $active = isset($_GET['active']) ? $_GET['active'] : 1;
     $keyword = isset($_GET['keyword']) ? Security::remove_XSS($_GET['keyword']) : null;
     $sleepingDays = isset($_GET['sleeping_days']) ? intval($_GET['sleeping_days']) : null;
-    $status = isset($_GET['status']) ? Security::remove_XSS($_GET['status']) : null;
-
+    $status = isset($_GET['status']) ? Security::remove_XSS($_GET['status']) : '';
 
     $lastConnectionDate = null;
     if (!empty($sleepingDays)) {
@@ -89,7 +88,7 @@ function get_users($from, $limit, $column, $direction)
         }
     }
 
-    if ($drhLoaded == false) {
+    if ($drhLoaded === false) {
         $students = UserManager::getUsersFollowedByUser(
             api_get_user_id(),
             $status,
@@ -105,7 +104,7 @@ function get_users($from, $limit, $column, $direction)
             COURSEMANAGER,
             $keyword
         );
-    }
+      }
 
     $all_datas = array();