Internal - Fix static permissions for files/directories: use API functions to get the right permissions - refs #2582

plugin/pens/pens.php

@@ -35,7 +35,8 @@ class ChamiloPackageHandler extends PENSPackageHandler
         // Moves the package to archive/pens
         $path_to_archives = api_get_path(SYS_ARCHIVE_PATH).'pens';
         if (!is_dir($path_to_archives)) {
-            mkdir($path_to_archives, 0777, true);
+            $mode = api_get_permissions_for_new_directories();
+            mkdir($path_to_archives, $mode, true);
         }
         rename($path_to_package, $path_to_archives.'/'.$request->getFilename());
         // Insert the request in the database

plugin/vchamilo/install.php

@@ -74,5 +74,6 @@ api_add_setting(0, 'vchamilo_vcrontickperiod', 'vchamilo', 'setting', 'Plugins')
 // create root storage directory for templates
 global $_configuration;
 if (!is_dir($_configuration['root_sys'].'plugin/vchamilo/templates')) {
-    mkdir($_configuration['root_sys'].'plugin/vchamilo/templates', 0777, true);
+    $mode = api_get_permissions_for_new_directories();
+    mkdir($_configuration['root_sys'].'plugin/vchamilo/templates', $mode, true);
 }

plugin/vchamilo/lib/Virtual.php

@@ -604,7 +604,8 @@ class Virtual
 
         // Scans the templates.
         if (!is_dir($tempDir)) {
-            mkdir($tempDir, 0777, true);
+            $mode = api_get_permissions_for_new_directories();
+            mkdir($tempDir, $mode, true);
         }
 
         $finder = new \Symfony\Component\Finder\Finder();
@@ -1278,10 +1279,10 @@ class Virtual
         // this is very important here (DO NOT USE api_get_path() !!) because storage may be remotely located
         $absAlternateCourse = self::getConfig('vchamilo', 'course_real_root');
         $courseDir = $absAlternateCourse.'/'.$slug;
-
+        $mode = api_get_permissions_for_new_directories();
         if (!is_dir($courseDir)) {
             self::ctrace("Creating physical course dir in $courseDir");
-            mkdir($courseDir, 0777, true);
+            mkdir($courseDir, $mode, true);
             // initiate default index
             $indexFile = $courseDir.'/index.html';
             if ($indexFile) {
@@ -1314,7 +1315,7 @@ class Virtual
             self::ctrace("Making dir as $dir");
 
             if (!is_dir($dir)) {
-                if (!mkdir($dir, 0777, true)) {
+                if (!mkdir($dir, $mode, true)) {
                     self::ctrace("Error creating dir $dir \n");
                 }
             }

plugin/vchamilo/vcron.php

@@ -41,7 +41,8 @@ $VCRON->TRACE = '/data/log/chamilo/vcrontrace.log'; // Trace file where to colle
 $VCRON->TRACE_ENABLE = true; // enables tracing
 
 if (!is_dir($_configuration['root_sys'].'plugin/vchamilo/log')) {
-    mkdir($_configuration['root_sys'].'plugin/vchamilo/log', 0777, true);
+    $mode = api_get_permissions_for_new_directories();
+    mkdir($_configuration['root_sys'].'plugin/vchamilo/log', $mode, true);
 }
 
 /**

plugin/vchamilo/views/manage.controller.php

@@ -125,6 +125,7 @@ switch ($action) {
 
         // Make template directory (files and SQL).
         $separator = DIRECTORY_SEPARATOR;
+        $dirMode = api_get_permissions_for_new_directories();
 
         $backupDir = api_get_path(SYS_PATH).'plugin'.$separator.'vchamilo'.$separator.'templates'.$separator.$vhost->slug.$separator;
 
@@ -132,7 +133,7 @@ switch ($action) {
         $absolute_sqldir = $backupDir.'dump.sql';
 
         if (!is_dir($backupDir)) {
-            $result = mkdir($backupDir, 0777, true);
+            $result = mkdir($backupDir, $dirMode, true);
             if ($result) {
                 Display::addFlash(
                     Display::return_message('Directory created: '.$backupDir)
@@ -147,8 +148,8 @@ switch ($action) {
         if ($vchamilostep == 0) {
             // Create directories, if necessary.
             if (!is_dir($absolute_datadir)) {
-                mkdir($absolute_datadir, 0777, true);
-                mkdir($absolute_datadir.'/home', 0777, true);
+                mkdir($absolute_datadir, $dirMode, true);
+                mkdir($absolute_datadir.'/home', $dirMode, true);
             }
 
             if (empty($fullautomation)) {