From 465d16f644ea5b8a8b27d7536cf599d1df95c3a4 Mon Sep 17 00:00:00 2001 From: Scrutinizer Auto-Fixer Date: Wed, 19 Apr 2017 10:27:11 +0000 Subject: [PATCH] Scrutinizer Auto-Fixes This commit consists of patches automatically generated for this project on https://scrutinizer-ci.com --- custompages/language.php | 2 +- main/admin/career_dashboard.php | 20 +-- main/admin/course_export.php | 22 +-- main/admin/user_edit.php | 20 +-- main/course_home/activity.php | 18 +-- .../copy_course_session_selected.php | 76 +++++----- main/exercise/hotspot.inc.php | 2 +- main/exercise/hotspot_updatescore.inc.php | 6 +- main/exercise/qti2.php | 8 +- .../lib/formvalidator/Element/DatePicker.php | 16 +-- main/inc/lib/online.inc.php | 26 ++-- main/inc/lib/pdf.lib.php | 40 +++--- main/inc/lib/sortable_table.class.php | 30 ++-- main/ticket/assign_tickets.php | 20 +-- main/webservices/lp.php | 86 +++++------ plugin/buycourses/src/paymentsetup.php | 16 +-- plugin/ims_lti/start.php | 4 +- .../Component/CourseCopy/CourseRestorer.php | 136 +++++++++--------- .../CourseCopy/Resources/SurveyQuestion.php | 2 +- 19 files changed, 275 insertions(+), 275 deletions(-) diff --git a/custompages/language.php b/custompages/language.php index cff015a6f0..736bdf01df 100755 --- a/custompages/language.php +++ b/custompages/language.php @@ -6,7 +6,7 @@ * @package chamilo.custompages */ // Get helper functions -require_once __DIR__ . '/language.inc.php'; +require_once __DIR__.'/language.inc.php'; // Define the languages you want to make available for auto-detection here $available_langs = array('en', 'fr', 'es', 'gl', 'eu'); diff --git a/main/admin/career_dashboard.php b/main/admin/career_dashboard.php index f5066c8ef0..50afd79174 100755 --- a/main/admin/career_dashboard.php +++ b/main/admin/career_dashboard.php @@ -29,7 +29,7 @@ $interbreadcrumb[] = array( Display :: display_header(null); -$form = new FormValidator('filter_form','GET', api_get_self()); +$form = new FormValidator('filter_form', 'GET', api_get_self()); $career = new Career(); @@ -60,11 +60,11 @@ $form->addButtonSearch(get_lang('Filter')); // action links echo '
'; echo ''. - Display::return_icon('back.png', get_lang('BackTo').' '.get_lang('PlatformAdmin'),'',ICON_SIZE_MEDIUM).''; + Display::return_icon('back.png', get_lang('BackTo').' '.get_lang('PlatformAdmin'), '', ICON_SIZE_MEDIUM).''; echo ''. - Display::return_icon('career.png',get_lang('Careers'),'',ICON_SIZE_MEDIUM).''; + Display::return_icon('career.png', get_lang('Careers'), '', ICON_SIZE_MEDIUM).''; echo ''. - Display::return_icon('promotion.png',get_lang('Promotions'),'',ICON_SIZE_MEDIUM).''; + Display::return_icon('promotion.png', get_lang('Promotions'), '', ICON_SIZE_MEDIUM).''; echo '
'; $form->display(); @@ -124,22 +124,22 @@ if (!empty($career_array)) { foreach ($career_array as $career_id => $data) { $career = $data['name']; $promotions = $data['promotions']; - $career = Display::url($career, 'careers.php?action=edit&id=' . $career_id); + $career = Display::url($career, 'careers.php?action=edit&id='.$career_id); $career = Display::tag('h4', $career); - echo '' . $career . ''; + echo ''.$career.''; if (!empty($promotions)) { foreach ($promotions as $promotion_id => $promotion) { $promotion_name = $promotion['name']; - $promotion_url = Display::url($promotion_name, 'promotions.php?action=edit&id=' . $promotion_id); + $promotion_url = Display::url($promotion_name, 'promotions.php?action=edit&id='.$promotion_id); $sessions = $promotion['sessions']; $count = count($promotion['sessions']); $rowspan = ''; if (!empty($count)) { - $rowspan = 'rowspan="' . $count . '"'; + $rowspan = 'rowspan="'.$count.'"'; } echo ''. - ''. + ''. Display::tag('h5', $promotion_url). ''; @@ -167,7 +167,7 @@ if (!empty($career_array)) { echo '
  • '; $url = Display::url( $course['title'], - api_get_path(WEB_COURSE_PATH) . $course['directory'] . '/index.php?id_session=' . $session['data']['id'] + api_get_path(WEB_COURSE_PATH).$course['directory'].'/index.php?id_session='.$session['data']['id'] ); echo $url; echo '
  • '; diff --git a/main/admin/course_export.php b/main/admin/course_export.php index be866533be..230e34b428 100755 --- a/main/admin/course_export.php +++ b/main/admin/course_export.php @@ -14,7 +14,7 @@ $this_section = SECTION_PLATFORM_ADMIN; api_protect_admin_script(); $tool_name = get_lang('ExportCourses'); -$interbreadcrumb[] = array ('url' => 'index.php', 'name' => get_lang('PlatformAdmin')); +$interbreadcrumb[] = array('url' => 'index.php', 'name' => get_lang('PlatformAdmin')); set_time_limit(0); @@ -59,17 +59,17 @@ if (isset($_POST['formSent']) && $_POST['formSent']) { $dataToExport = []; foreach ($courses as $course) { - $dataToExport['code'] = str_replace(';',',',$course['code']); - $dataToExport['title'] = str_replace(';',',',$course['title']); - $dataToExport['category_code'] = str_replace(';',',',$course['category_code']); + $dataToExport['code'] = str_replace(';', ',', $course['code']); + $dataToExport['title'] = str_replace(';', ',', $course['title']); + $dataToExport['category_code'] = str_replace(';', ',', $course['category_code']); $categoryInfo = CourseCategory::getCategory($course['category_code']); if ($categoryInfo) { - $dataToExport['category_name'] = str_replace(';',',',$categoryInfo['name']); + $dataToExport['category_name'] = str_replace(';', ',', $categoryInfo['name']); } else { $dataToExport['category_name'] = ''; } - $dataToExport['tutor_name'] = str_replace(';',',',$course['tutor_name']); - $dataToExport['course_language'] = str_replace(';',',',$course['course_language']); + $dataToExport['tutor_name'] = str_replace(';', ',', $course['tutor_name']); + $dataToExport['course_language'] = str_replace(';', ',', $course['course_language']); $dataToExport['students'] = ''; $dataToExport['teachers'] = ''; @@ -79,9 +79,9 @@ if (isset($_POST['formSent']) && $_POST['formSent']) { if (is_array($usersInCourse) && !empty($usersInCourse)) { foreach ($usersInCourse as $user) { if ($user['status_rel'] == COURSEMANAGER) { - $dataToExport['teachers'] .= $user['username'] . '|'; + $dataToExport['teachers'] .= $user['username'].'|'; } else { - $dataToExport['students'] .= $user['username'] . '|'; + $dataToExport['students'] .= $user['username'].'|'; } } } @@ -153,8 +153,8 @@ if (!empty($course_list)) { $form->addHtml(''); } -$form->addElement('radio', 'file_type', get_lang('OutputFileType'), 'CSV' , 'csv', null); -$form->addElement('radio', 'file_type', '' , 'XLS' , 'xls', null); +$form->addElement('radio', 'file_type', get_lang('OutputFileType'), 'CSV', 'csv', null); +$form->addElement('radio', 'file_type', '', 'XLS', 'xls', null); $form->addElement('radio', 'file_type', null, 'XML', 'xml', null, array('id' => 'file_type_xml')); $form->setDefaults(['select_type' => '1', 'file_type' => 'csv']); diff --git a/main/admin/user_edit.php b/main/admin/user_edit.php index 9c39057a0e..678a6726ee 100755 --- a/main/admin/user_edit.php +++ b/main/admin/user_edit.php @@ -73,7 +73,7 @@ $geolocalization = $gMapsPlugin->get('enable_api') === 'true'; if ($geolocalization) { $gmapsApiKey = $gMapsPlugin->get('api_key'); - $htmlHeadXtra[] = ''; + $htmlHeadXtra[] = ''; } $htmlHeadXtra[] = api_get_css_asset('cropper/dist/cropper.min.css'); @@ -153,7 +153,7 @@ if (api_get_setting('registration', 'email') == 'true') { } if (api_get_setting('login_is_email') == 'true') { - $form->addRule('email', sprintf(get_lang('UsernameMaxXCharacters'), (string)USERNAME_MAX_LENGTH), 'maxlength', USERNAME_MAX_LENGTH); + $form->addRule('email', sprintf(get_lang('UsernameMaxXCharacters'), (string) USERNAME_MAX_LENGTH), 'maxlength', USERNAME_MAX_LENGTH); $form->addRule('email', get_lang('UserTaken'), 'username_available', $user_data['username']); } @@ -187,7 +187,7 @@ if (strlen($user_data['picture_uri']) > 0) { if (api_get_setting('login_is_email') != 'true') { $form->addElement('text', 'username', get_lang('LoginName'), array('maxlength' => USERNAME_MAX_LENGTH)); $form->addRule('username', get_lang('ThisFieldIsRequired'), 'required'); - $form->addRule('username', sprintf(get_lang('UsernameMaxXCharacters'), (string)USERNAME_MAX_LENGTH), 'maxlength', USERNAME_MAX_LENGTH); + $form->addRule('username', sprintf(get_lang('UsernameMaxXCharacters'), (string) USERNAME_MAX_LENGTH), 'maxlength', USERNAME_MAX_LENGTH); $form->addRule('username', get_lang('OnlyLettersAndNumbersAllowed'), 'username'); $form->addRule('username', get_lang('UserTaken'), 'username_available', $user_data['username']); } @@ -224,7 +224,7 @@ if (isset($extAuthSource) && !empty($extAuthSource) && count($extAuthSource) > 0 } $form->addElement('radio', 'reset_password', null, get_lang('AutoGeneratePassword'), 1); $group = array(); -$group[] =$form->createElement('radio', 'reset_password', null, get_lang('EnterPassword'), 2); +$group[] = $form->createElement('radio', 'reset_password', null, get_lang('EnterPassword'), 2); $group[] = $form->createElement( 'password', 'password', @@ -260,10 +260,10 @@ $display = isset($user_data['status']) && ($user_data['status'] == STUDENT || (i // Platform admin if (api_is_platform_admin()) { $group = array(); - $group[] =$form->createElement('radio', 'platform_admin', null, get_lang('Yes'), 1); - $group[] =$form->createElement('radio', 'platform_admin', null, get_lang('No'), 0); + $group[] = $form->createElement('radio', 'platform_admin', null, get_lang('Yes'), 1); + $group[] = $form->createElement('radio', 'platform_admin', null, get_lang('No'), 0); - $user_data['status'] == 1 ? $display = 'block':$display = 'none'; + $user_data['status'] == 1 ? $display = 'block' : $display = 'none'; $form->addElement('html', '
    '); $form->addGroup($group, 'admin', get_lang('PlatformAdmin'), null, false); @@ -287,7 +287,7 @@ $form->addElement('label', get_lang('RegistrationDate'), $date); if (!$user_data['platform_admin']) { // Expiration Date $form->addElement('radio', 'radio_expiration_date', get_lang('ExpirationDate'), get_lang('NeverExpires'), 0); - $group = array (); + $group = array(); $group[] = $form->createElement('radio', 'radio_expiration_date', null, get_lang('Enabled'), 1); $group[] = $form->createElement('DateTimePicker', 'expiration_date', null, array('onchange' => 'javascript: enable_expiration_date();')); $form->addGroup($group, 'max_member_group', null, null, false); @@ -305,7 +305,7 @@ $studentBossToSelect = []; if ($studentBoss) { foreach ($studentBoss as $bossId => $userData) { $bossInfo = api_get_user_info($userData['user_id']); - $studentBossToSelect[$bossInfo['user_id']] = $bossInfo['complete_name_with_username']; + $studentBossToSelect[$bossInfo['user_id']] = $bossInfo['complete_name_with_username']; } } @@ -331,7 +331,7 @@ $returnParams = $extraField->addElements( $jquery_ready_content = $returnParams['jquery_ready_content']; // the $jquery_ready_content variable collects all functions that will be load in the $(document).ready javascript function -$htmlHeadXtra[] ='