From 49bad1ddba702a40ae1a3aff0807ecb4d070dd7e Mon Sep 17 00:00:00 2001
From: Angel Fernando Quiroz Campos <angelfqc.18@gmail.com>
Date: Wed, 24 Oct 2018 14:41:41 -0500
Subject: [PATCH] LTI fix read result request - refs BT#13469

---
 plugin/ims_lti/outcome_service.php              |  2 --
 plugin/ims_lti/src/ImsLtiServiceReadRequest.php | 14 ++++++++------
 2 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/plugin/ims_lti/outcome_service.php b/plugin/ims_lti/outcome_service.php
index a915ffd8c1..c31aca9eca 100644
--- a/plugin/ims_lti/outcome_service.php
+++ b/plugin/ims_lti/outcome_service.php
@@ -7,6 +7,4 @@ $plugin = ImsLtiPlugin::create();
 
 $process = $plugin->processServiceRequest();
 
-error_log($process);
-
 echo $process;
diff --git a/plugin/ims_lti/src/ImsLtiServiceReadRequest.php b/plugin/ims_lti/src/ImsLtiServiceReadRequest.php
index 9c5e4af8e7..d58881ab99 100644
--- a/plugin/ims_lti/src/ImsLtiServiceReadRequest.php
+++ b/plugin/ims_lti/src/ImsLtiServiceReadRequest.php
@@ -52,13 +52,15 @@ class ImsLtiServiceReadRequest extends ImsLtiServiceRequest
             /** @var Result $result */
             $result = $results[0];
 
-            $ltiScore = $evaluation->getMax() / $result->get_score() / 10;
+            if (!empty($result->get_score())) {
+                $ltiScore = $result->get_score() / $evaluation->getMax();
 
-            $responseDescription = sprintf(
-                get_plugin_lang('ScoreForXUserIsYScore', 'ImsLtiPlugin'),
-                $user->getId(),
-                $ltiScore
-            );
+                $responseDescription = sprintf(
+                    get_plugin_lang('ScoreForXUserIsYScore', 'ImsLtiPlugin'),
+                    $user->getId(),
+                    $ltiScore
+                );
+            }
         }
 
         $this->statusInfo