From 407536472f49e450c8e9c12db1ddb87512d629c6 Mon Sep 17 00:00:00 2001
From: Angel Fernando Quiroz Campos <angelfqc.18@gmail.com>
Date: Thu, 9 Aug 2018 19:30:01 -0500
Subject: [PATCH] Behat add test to check exercises with questions by
 categories

---
 main/exercise/TestCategory.php                |   2 +-
 main/exercise/overview.php                    |   5 +
 .../features/bootstrap/FeatureContext.php     |  97 +++++++++++++++++-
 tests/behat/features/toolExercise.feature     |  71 +++++++++++++
 tests/behat/uploadable_files/exercise.xls     | Bin 0 -> 14848 bytes
 5 files changed, 172 insertions(+), 3 deletions(-)
 create mode 100644 tests/behat/uploadable_files/exercise.xls

diff --git a/main/exercise/TestCategory.php b/main/exercise/TestCategory.php
index 8ae87f2983..fa138bcd42 100644
--- a/main/exercise/TestCategory.php
+++ b/main/exercise/TestCategory.php
@@ -801,7 +801,7 @@ class TestCategory
         }
         $category_name_list = self::getListOfCategoriesNameForTest($exerciseId);
 
-        $table = new HTML_Table(['class' => 'table table-bordered']);
+        $table = new HTML_Table(['class' => 'table table-bordered', 'id' => 'category_results']);
         $table->setHeaderContents(0, 0, get_lang('Categories'));
         $table->setHeaderContents(0, 1, get_lang('AbsoluteScore'));
         $table->setHeaderContents(0, 2, get_lang('RelativeScore'));
diff --git a/main/exercise/overview.php b/main/exercise/overview.php
index c3c605c904..68f1930a6b 100755
--- a/main/exercise/overview.php
+++ b/main/exercise/overview.php
@@ -83,6 +83,11 @@ if ($is_allowed_to_edit && $objExercise->sessionId == $sessionId) {
         Display::return_icon('edit.png', get_lang('Edit'), [], ICON_SIZE_SMALL),
         api_get_path(WEB_CODE_PATH).'exercise/admin.php?'.api_get_cidreq().'&exerciseId='.$objExercise->id
     );
+} elseif (api_is_teacher()) {
+    $edit_link = Display::url(
+        Display::return_icon('test_results.png', get_lang('Results'), [], ICON_SIZE_SMALL),
+        'exercise_report.php?'.api_get_cidreq().'&exerciseId='.$objExercise->id
+    );
 }
 $iconExercise = Display::return_icon('test-quiz.png', null, [], ICON_SIZE_MEDIUM);
 // Exercise name.
diff --git a/tests/behat/features/bootstrap/FeatureContext.php b/tests/behat/features/bootstrap/FeatureContext.php
index 5b9c6a4206..4e0fa9cd5c 100644
--- a/tests/behat/features/bootstrap/FeatureContext.php
+++ b/tests/behat/features/bootstrap/FeatureContext.php
@@ -1,5 +1,6 @@
 <?php
 
+use Behat\Gherkin\Node\TableNode;
 use Behat\MinkExtension\Context\MinkContext;
 
 /**
@@ -141,7 +142,7 @@ class FeatureContext extends MinkContext
     {
         $this->visit('/index.php?logout=logout');
         $this->iAmOnHomepage();
-        $this->fillFields(new \Behat\Gherkin\Node\TableNode([
+        $this->fillFields(new TableNode([
             ['login', $username],
             ['password', $username]
         ]));
@@ -181,7 +182,7 @@ class FeatureContext extends MinkContext
     public function iHaveAPublicPasswordProtectedCourse($code, $password)
     {
         $this->visit('/main/admin/course_add.php');
-        $this->fillFields(new \Behat\Gherkin\Node\TableNode([
+        $this->fillFields(new TableNode([
             ['title', 'Password Protected'],
             ['visual_code', $code],
             ['visibility', 3]
@@ -471,4 +472,96 @@ class FeatureContext extends MinkContext
         }
         return false;
     }
+
+    /**
+     * @Given /^I am a student subscribed to session "([^"]*)"$/
+     *
+     * @param string$sessionName
+     */
+    public function iAmStudentSubscribedToXSession($sessionName)
+    {
+        $this->iAmAPlatformAdministrator();
+        $this->visit('/main/session/session_add.php');
+        $this->fillField('name', $sessionName);
+        $this->pressButton('Next step');
+        $this->selectOption('NoSessionCoursesList[]', 'TEMP (TEMP)');
+        $this->pressButton('add_course');
+        $this->pressButton('Next step');
+        $this->assertPageContainsText('Update successful');
+        $this->fillField('user_to_add', 'acostea');
+        $this->waitForThePageToBeLoaded();
+        $this->clickLink('Costea Andrea (acostea)');
+        $this->pressButton('Finish session creation');
+        $this->assertPageContainsText('Session overview');
+        //$this->assertPageContainsText('Costea Andrea (acostea)');
+        $this->iAmAStudent();
+    }
+
+    /**
+     * Example: Then I should see the table "#category_results":
+     *               | Categories    | Absolute score | Relative score |
+     *               | Categoryname2 | 50 / 70        | 71.43%         |
+     *               | Categoryname1 | 60 / 60        | 100%           |
+     *
+     * @Then /^I should see the table "([^"]*)":$/
+     *
+     * @param string    $tableId
+     * @param TableNode $tableData
+     *
+     * @throws Exception
+     */
+    public function assertPageContainsTable($tableId, TableNode $tableData)
+    {
+        $table = $this->getSession()->getPage()->find('css', $tableId);
+        $rows = $tableData->getRowsHash();
+        $i = 1;
+
+        $right = array_keys($rows);
+
+        foreach ($right as $text) {
+            $cell = $table->find('css', 'tr:nth-child('.$i.') :nth-child(1)');
+            $i++;
+
+            if (!$cell) {
+                throw new Exception('Cell not found.');
+            }
+
+            if ($cell->getText() != $text) {
+                throw new Exception('Table text not found.');
+            }
+        }
+
+        $i = 1;
+
+        foreach ($rows as $field => $cols) {
+            if (is_array($cols)) {
+                $j = 2;
+
+                foreach ($cols as $col) {
+                    $cell = $table->find('css', 'tr:nth-child('.$i.') :nth-child('.$j.')');
+                    $j++;
+
+                    if (!$cell) {
+                        throw new Exception('Cell not found.');
+                    }
+
+                    if ($cell->getText() != $col) {
+                        throw new Exception('Table text not found. Found "'.$cell->getText().'" <> "'.$col.'"');
+                    }
+                }
+            } else {
+                $cell = $table->find('css', 'tr:nth-child('.$i.') :nth-child(2)');
+
+                if (!$cell) {
+                    throw new Exception('Cell not found.');
+                }
+
+                if ($cell->getText() != $cols) {
+                    throw new Exception('Table text not found. Found "'.$cell->getText().'" <> "'.$cols.'"');
+                }
+            }
+
+            $i++;
+        }
+    }
 }
diff --git a/tests/behat/features/toolExercise.feature b/tests/behat/features/toolExercise.feature
index 706c93b795..c689d8ae4b 100644
--- a/tests/behat/features/toolExercise.feature
+++ b/tests/behat/features/toolExercise.feature
@@ -310,6 +310,77 @@ Feature: Exercise tool
     Then I should see "Exercise copied"
     And I should see "Exercise 1 - Copy"
 
+  Scenario: Import exercise to test questions categories
+    Given I am on "/main/exercise/upload_exercise.php?cidReq=TEMP"
+    And I should see "Import quiz from Excel"
+    And I attach the file "/tests/behat/uploadable_files/exercise.xls" to "user_upload_quiz"
+    When I press "Upload"
+    And wait for the page to be loaded
+    Then I should see "Exercise for Behat test"
+
+  Scenario: Try exercise with categorized questions as student
+    Given I am a student subscribed to session "Session Exercise"
+    And I am on "/user_portal.php"
+    And I follow "Session Exercise"
+    And wait for the page to be loaded
+    And I follow "tabs2"
+    And I follow "TEMP"
+    And I am on "/main/exercise/exercise.php?cidReq=TEMP"
+    And I follow "Exercise for Behat test"
+    And I follow "Start test"
+    When wait for the page to be loaded
+    And I press "Next question"
+    And I check "oligarchy"
+    And I check "oligopoly"
+    And I check "timocracy"
+    And I check "autocracy"
+    And I press "Next question"
+    And I check the "semantics" radio button
+    And I press "Next question"
+    And I check the "RNASL" radio button
+    And I press "Next question"
+    And I check the "10" radio button
+    And I press "Next question"
+    And fill in the following:
+      | choice_id_6_0 | words  |
+      | choice_id_6_1 | fill   |
+      | choice_id_6_2 | blanks |
+    And I press "Next question"
+    And I select "A" from "choice_id_7_1"
+    And I select "B" from "choice_id_7_2"
+    And I select "C" from "choice_id_7_3"
+    And I press "Next question"
+    And I check "1"
+    And I press "Next question"
+    And I press "End test"
+    Then I should see "Score for the test: 190 / 190"
+    And I should see the table "#category_results":
+      | Categories    | Absolute score | Relative score |
+      | Categoryname2 | 50 / 70        | 71.43%         |
+      | Categoryname1 | 60 / 60        | 100%           |
+      | none          | 80 / 60        | 133.33%        |
+      | Total         | 190 / 190      | 100%           |
+
+  Scenario: Teacher see exercise results by categories
+    Given I am on "/user_portal.php"
+    And I follow "Session Exercise"
+    And wait for the page to be loaded
+    And I follow "tabs2"
+    And I follow "TEMP"
+    And I am on "/main/exercise/exercise.php?cidReq=TEMP"
+    And I follow "Exercise for Behat test"
+    And I follow "Results and feedback"
+    Then I should see "Learner score"
+    And wait for the page to be loaded
+    And I follow "Grade activity"
+    Then I should see "Score for the test: 190 / 190"
+    And I should see the table "#category_results":
+      | Categories    | Absolute score | Relative score |
+      | Categoryname2 | 50 / 70        | 71.43%         |
+      | Categoryname1 | 60 / 60        | 100%           |
+      | none          | 80 / 60        | 133.33%        |
+      | Total         | 190 / 190      | 100%           |
+
   Scenario: Delete an exercise
     Given I am on "/main/exercise/exercise.php?cidReq=TEMP"
     And I follow "Delete"
diff --git a/tests/behat/uploadable_files/exercise.xls b/tests/behat/uploadable_files/exercise.xls
new file mode 100644
index 0000000000000000000000000000000000000000..59b79bcf50346df75ea46c5f7be42491b4e5cd23
GIT binary patch
literal 14848
zcmeHOYiu0Xb-v4&NIfZ8c5KR8-4#WOj};}7mMzJa#fM1CwnR}BT?eq;cDNjJCz{=1
zW|pRy^g%nxj{*&lG=K{tMywS6(ZE2Pq(y=vK`Z|#P@rs6v<aH_m(w39g0=utBq##d
zX20*u&fVSNu%cb3fL#rBXLi2(-E;3f=iGB2yZXED?SJd5-)Q@hid~PYdiCx`i)yOE
zQ~2B#y|*g$F?=TW?#9MO1mok~>qDf0cgk(8hXEUq8j)!89Z1bcEl4|&b|LLX+Jm$g
zX&(|?K<!65fOHSiL8N<;?n9zaFg;NIe5m~V5UJ+>MN_Aghrg22YD^XJ^wlyfwf*Zp
zcucjTwo|e?UTlYdC(hmaD;l_yu9#n~|CVNq;-*IRojq$D@-p^+r0Uey8{WiSseeIw
zUM(;-j9P9^|6g4r(grKVHr&P}b3WCCxuy=Y(yO@dRevlw-<A7$i9jF@DSZYH&PqQ^
z4S}cB=jDD>?t5`hsc%b}e-@-4^Vwg4wej0u;6#Q3jj3Ub0Y_QNRk2(UKDgX;x!&)x
zk##AxBlRoFM$NORxro%SB1YJ<J2McoV=~eWyVdKA<WJZ|+qc}eBtpNge!ihmX>{Gz
z#Mynpf3`iG%}(NPg;Q!0|D%h)4xMUtuY5&%?hW;@9>=@4z_VN6JzL-{iMWC%q}0)H
z(w3^j_B0BvmAX{ho+iPu0{D0m4mpYVR&s#n%W@jN+(3Ub@^9ASVS6AyhKKyE@M`(J
zdn)p)`PDf1=vsJ%dI;qMH|>0F3pv$z6<<}$sj9aIui`iS&KB~k@l2H-LOir%S4IB~
zd-g};TI@R+_DYrU&Hbw8qdh~l{LS*eu_IZ2h;No(&4>I;k^E}Br>gxSz9aI(D*b<{
z4ztdR+TgQwrCy%<SDNH`V5LEx_pI!Y=fRc6jo-s;bw;ZD@sBr@Y)Q&D?oR~4hZQo)
zw-r2B_<|3&Z{NmaMXj!GsMWzatZLTO_x|<gY7T!Jz}4KET3e$)G>L!wDDp&t$Y3oB
zoHgKUD8I3>s#fv7v5K;gyRo*a2In@^px|JyA*~|KLHyjRdgYZ@6bNc?6~G|=A+1UR
zHi)tSejW2yN_`G<V1bKpjHK&%+b;DJ`TnsgWPr$@bygvRzpEM`c2K>UYDQ9O`tvFE
zZ|W0V&9BdpsG8Q{Te8$|z=OL2Ce98_b>(M-4XR!1T>bwAhEub8DTUoa^X=3S?n5g5
zQ|=G2Uued@p&5I{=Kn(Ud0YK$(;omIMM4eN7M)KaYwV`&=bXUSbDpn9?7UUdB|9iJ
zlYpn=6+yaa&pAbhFWQ^ap6kq8elEX^9n1Bc=i8`d+_q<DtlW)hf6;~lr}Ivr=N#Le
z)lN`6Ueb$!Ju6js3wBX|vMf5t>Y2roc1pU4@_{aSddAiZz8%;_z(rlk+xn(UQLe4K
zz{^=hQtZM)X}KFcjOrb?+`z`}XsqZvxqQ_03+&&5Yn3GxY^&%L=h+7eF4=xTzj4cS
z=hk;v<+8WvYj3Hjmpp$qcphD}T{~COmg`C>s~9ZVKH5rE&3d}0=#_eO&MPdqb_qfu
z*eY7CH@|#N>jm2btk3CLyWr(~E4QrAozqLU<(BgJsIfvA7J2=!pJ@o}ebeL&lykfV
z&s{d?;7+9$+{IET)W8pcTyn})8T2$zE8@bkqgKhD_xxq(FZx)t3ibeeal)Ih=dF_S
zqAiv^3Wn$V(tl~^Ine`+R;hiYY;Twxx)2S(E2;|h=}FhN;A6SGox2fgI0rQYDWEC7
zW4V1$^cCxdt%F4$=CyKp<0Lw71#po-jPk~<S_{Kwu2ZzL+JoZ#B|0(;sFxgAYu+wt
z??u~pt%cwjxQbJpt+HTfz!~_sF&>RtWj)s_&M#W?b^t>~t^?~W<Q>-wyah2JG;8~d
zvobbdHchjb{3c|U@=h)QE3gYzv4qdC%DitC3YH&Je?K<tab=rQ*xXNG=w#7CsJX0Z
zr__hFz_X|!uf3uj`E_7ZS#uix2;~MCFRr%~jU3DO(Jc%{r-;#JVPw5%8|GMX-gSb!
zxc&u<?&0aFXD0BRyn1nL1kb67;p><2ymIx@@HC!d)0d|vGMk${r6=^TzOFCpuApf7
zZg(28+=3UB`t-EF42$}+wvR!76Yk;^>|2=*mAa1IZ~-fEjrG5U_4vGe{-j#OGr<1X
zL4FarHWnxg!r^MYg6EOrBXw#-xKJs@#lj5g3G&_|A`#*S?JKoPM1UFtc%L0y(0br>
zRu4RcG?3N(XOT|h++-SK{CEKW5O40&&)RUSS*ZF}=Fw_@m6+k%FFN*;R1tG-7)M7<
zk^1@&Q^)C|Y|jk*>_(vNn-)U|v?_rI5gI|yg$srGh_O*rn_gb9kE3za-jY+w>*u7z
z3k;vnvCs>QW6y=<Ucgjv#VY0U41DD}AaopFkYi<&mhaFfM{IZASu7wrjQEQ|V7mcY
zFbUtr<FZq*a0+$N4syP;z-a&)-d0$g^IZBKyNQVC<PZ{1Y2Az4c_gew;tr3{zu*-y
ziu>v0Eaw&7WqLRIA=3~-#ByQA@d78<!1>sy`VF)h+EKaYdy(*=eDOStR~^Qr3OC!W
zHJk0-m{eym0drE{FB5DlrqZ{+_S3(=GBbJM*92dwtX5SA7e%Tg^%8R4Z0L~^y>fq9
zxCd1`+*5Uqb{?IEQwMqi?l9$H+-D~|zhJpXJNpMZhwoKgs^d<yNyHu9Ir$k8|5>?r
zqA6H~;QGmh<5i!#@cA<*e)#f<AFf~MuKN5{>^WM{!Ib>Htg@+WDk>j6Q|cMWZc)D}
z8dU0QtyG7Scb5C+$1Cr3$oWU;ILfa_T}Sp-@)6`xyLW}}s*Wd>@KL!_ZOwIDlW<Mb
zlj3tF^?+b}saGd!FxF5HMOX9c1v^`VQEt2}TzV4*f8QhzF24z*^Tg{#uQp+Hs5p<O
zv~i4H8OIRxH(}IOoW})b9HR!~*!~(!i%z*NtnfmNr^IoLr^a!Nqb82=R5^|zf^EX?
zPr!Hz9WTpoGU6CdspHs#3E1HT471CovPWXrJBSs$*cYY3w-mldp+lwW=pl9Le!+>f
ziI<bbQE&*-Ll)1$9uyXRw2kX%Da{aaNc|Q<4M)jgH3gidS*}e^_QN-_SQl%o7bbB^
zX_IsR@U5EFU|96*HjKGYa--Bp@1(3o!=m&w-a-~n?$Xk8vYLP&k#^Dh)AG#%Yuq6$
zdTaPb7X6fOtS^n-O!P*1^vy7@n#s1L<(moSwTMi5Cu?poHPZ@dIW;7U`c2C>7~xyB
zJdUWeoSQLkmoVv_;afG6El(R;>=q_%!2o~6*n&Mui~T8KkFe;)Y~LQ!KK3*XPYCh7
z!Xlq1m=&#118HN|eZr!rQx+p&sAZ1Vw6SZeu;}|_wHg+6ls0zVFD#A*vN$b;vN)zQ
zcnkY~0IUo=F=QP8epK|rQJyh&y+>FaG3>!T!s1xr8^?ae*p;V{8PpWYJ80xl-x*`m
zdxfQeQ37XzqiA{f#&MM~cD+xS8Iwn5<Wbal#@Ll3FoWDs%ExMC(h3=4*ZYM@yWTIX
zXpB+s8DrN6gw+m=`g_3ignG{yi?s>sSeeDq9_o*J&lrmx5*Frak#)$hsP~Lm?9ZWx
z2ZhCRZfb?vZpY`aKZlXmt~$#S4g)_XENZRY*eNY6Ea{{kj^2<(d$b!H9T8R+FxGQK
zSd_z=RpS|tp45IEqn_g!brr{`nK(v0#4+|Pj<FwcjIEAi-3eGv0@e$x!K?<t*({sD
zJCT6(C158Luv3DCs}PmiCpzt~;zig%0)|5()3=ECPy%*30ed(Bdn5rnlYpH~z|JLL
z*r{x4-(!N+_V;`O@9_i-hblGl=#3g!yNMH8JeBqh^XSjf=%-h<n>djXCaq2;<J&P4
zQRu7fCQcj`CVhcSj<yPu9^7u?M7uB<CpZp|nfOniZZ{F&n6T(aj1$L%Ny+r`b`t@x
zEyWu>i>waAqTjchnB6HX`WjiCV1?0yBY|bYHXjG8L(%)lIu5*3`ogi%A+dmM?gHz$
z(NCAKq8Lk!c1S!Rvs;*qyOh^$<WZX)Vhgf*gcWI+o0d*v3u?1N>LRmOnDijZ<Hjaz
zUoWh!ja8_z4x{TV%5=!OCoB9YCR1Y_M%O2V#W6<7CyZojti$NKPgopvWc3*qHP&IG
z?MY!#$Fvq@Qb(bNPa&^Mag0*JDd640qRbu>ZTp4AQOjQU3oFtO%l4RvJ0MJsWikh9
zm@MC8JbqA^9N}aR)-YMVOEkvW;vq15#ae7XOLUpJ>$K!WYm(EZ{frV_ig)(wVPUbJ
zhlRlv3uQ5Ga4#6Wu^wV9^N5kfNJ3kMtTT|6m6Ln2&Hz6lvKU+XjK<D_by5*yJ!io>
zrRXPo<Fn6b?3^$eal$;xW31sD(LSTGM}^6l6Xuc0Xu~&_$QmDeOqlHNW759J$5=LN
zba!4@(Y$}&^n^0AMt6@JS&s|jK)FW7v_7M|3t(jxF>2+4FgeQ(0f}a@DAErnU?U0G
zXaaUI0UJxe#uKn760l1N*pms^QwiA93E1TX>`DSQk$_!Iz$O#0YY7-F9M|*p7)C!C
z0#@1U48dw?!DzK1SS?&R(?a21hdwkctU6$14I9>ousD{;8mVE87#6J<?s3Q(tznHC
z7VR4DamczTtR`S=^F?7rvmvb=?s3Q*tC2Tm<k9|>{mr<r$R8I*G#=;?Y2)cn7}gWQ
z+F7ojK2q7=ToM-Bb*ZLZ^qR_E=}BQlW9v!NF8Wbr7xa{{sBLQYDZ`>?Rdzv73#+Zn
zdfKq)Yn5HlWnpnOPFa@?i{4k+1ziCv16zfxD`185F8#5xZ<r7k^)(@kNMH2OjM3Ls
z!@4Rg&a2c5eYUc@m=snNp(jm^^y13y;u=`}W}kn}uvl|tcQIANnldbUdS!QUU25cd
z=ikv5>@C-6K^#=BGt#G!7%2Ct`gP8Q`&5H`i<nX^>#fX-U3F@wlw+Aj<UL+@Kz)m@
ziSfeg({jIs>`&w5@G#|ul}JS@m72%biSw+veBt1OzkuQ!J?w)!X5COPq0b+pV^-=Z
zg(h#~n03=JX<3<gR2vyvor;m6^Y?6Ilrct@Du(2qXk_MuM#lG3ca6NoS^5WW<Wto~
z-u*s|j55CrBa5fpz5Nn3z|j`{RvY11tjJJIj1iX4yVplo11VUz9+M_}*xJk$sZzJ)
zuEx3Yx#Hw}{LWymq{nXNY*(Ls<ixav@A6$+mKGz<+#EM^@B4!Pg_XWf3GZUo=Y$u(
z=+|$3?zR8?#npW48((Zzy~qFLpSU(zL!w_Z{}K{?o~tWjd88JkFCcLp@hZ|Tq(4ML
zfKz{p#5MD6B-Z$oceq*%e^NP}$5*U@p7bsJ{>HZjKa9L#{LI1C<F;S4iuj!le(&Ua
zpVFiFmfZ`GEj+Al)M;#zhX{P}*}vqvR6g?^*AUXmKV*0Q$F;vs@$+ll{;!@q^?h~$
z)=Ta`+gJC4zxlzdeTQ1V^!w<4_7{J25m;jkdmb21xG9W@>ot~T-?qY$efRo^XyAkV
z{~zK%u^5u1Ci>M7oebBr_&trUZm1bNJv`s*#c!P`isP6uY&+%2|4LWLOkw}bU;Hen
zt7yX~wo|-@!}>XXSvRkm%>Utqds|*9)a&B+LhtwDcfDcF;e9)D*#CoNVxzi_-!>KS
z$6q@wt0(d6ra7?*k?40#TTA7+Cu`>FkI$`{l^p8p?ec3Q&LTXOlQ!7$Kak#Adw5#N
ldZVjS%hsQEAgi=>_Iu8W>gIDhg{%Mn&35>A;{0#w|8I(mHZ1@E

literal 0
HcmV?d00001