Minor change on Force test in LP edit, display warning - ref #5288

main/exercice/admin.php

@@ -429,7 +429,7 @@ function DetectFlashVer(reqMajorVer, reqMinorVer, reqRevision)
 </script>";
 
 Display::display_header($nameTools,'Exercise');
-if ($objExercise->edit_exercise_in_lp == false) {
+if ($objExercise->exercise_was_added_in_lp == true) {
     Display::display_warning_message(get_lang('EditingExerciseCauseProblemsInLP'));
 }
 

main/exercice/exercice.php

@@ -502,7 +502,7 @@ if (!empty($exercise_list)) {
                 // Teacher only
                 if ($is_allowedToEdit) {
                     $lp_blocked = null;
-                    if ($exercise_obj->edit_exercise_in_lp == false) {
+                if ($exercise_obj->exercise_was_added_in_lp == true) {
                         $lp_blocked = Display::div(get_lang('AddedToLPCannotBeAccessed'), array('class' => 'lp_content_type_label'));
                     }
 
@@ -551,7 +551,7 @@ if (!empty($exercise_list)) {
 
                         //Visible / invisible
                         //Check if this exercise was added in a LP
-                        if ($exercise_obj->edit_exercise_in_lp == false) {
+                    		if ($exercise_obj->exercise_was_added_in_lp == true) {
                             $actions .= Display::return_icon('invisible.png', get_lang('AddedToLPCannotBeAccessed'), '', ICON_SIZE_SMALL);
                         } else {
                             if ($row['active'] == 0 || $visibility == 0) {

main/exercice/exercise.class.php

@@ -152,7 +152,7 @@ class Exercise {
                 $this->exercise_was_added_in_lp = true;
             }
 
-            $this->force_edit_exercise_in_lp = isset($_configuration['force_edit_exercise_in_lp']) ? $_configuration['force_edit_exercise_in_lp'] : true;
+            $this->force_edit_exercise_in_lp = isset($_configuration['force_edit_exercise_in_lp']) ? $_configuration['force_edit_exercise_in_lp'] : false;
 
             if ($this->exercise_was_added_in_lp) {
                 $this->edit_exercise_in_lp = $this->force_edit_exercise_in_lp == true;

main/exercice/question.class.php

@@ -1351,7 +1351,7 @@ abstract class Question
 			eval('$explanation = get_lang('.$a_type[1].'::$explanationLangVar);');
 			echo '<li>';
 			echo '<div class="icon_image_content">';
-			if ($objExercise->edit_exercise_in_lp == false) {
+			if ($objExercise->exercise_was_added_in_lp == true) {
                 $img = pathinfo($img);
 				$img = $img['filename'].'_na.'.$img['extension'];
 				echo Display::return_icon($img,$explanation);
@@ -1364,7 +1364,7 @@ abstract class Question
 
 		echo '<li>';
 		echo '<div class="icon_image_content">';
-		if ($objExercise->edit_exercise_in_lp == false) {
+		if ($objExercise->exercise_was_added_in_lp == true) {
             echo Display::return_icon('database_na.png', get_lang('GetExistingQuestion'));
 		} else {
 			if ($feedback_type==1) {