Use session_rel_user to check if user is allowed to coach student

public/main/inc/lib/tracking.lib.php

@@ -3617,6 +3617,7 @@ class Tracking
 
         $tbl_session_course_user = Database::get_main_table(TABLE_MAIN_SESSION_COURSE_USER);
         $tbl_session_course = Database::get_main_table(TABLE_MAIN_SESSION_COURSE);
+        $tblSessionRelUser = Database::get_main_table(TABLE_MAIN_SESSION_USER);
         $tbl_session = Database::get_main_table(TABLE_MAIN_SESSION);
 
         // At first, courses where $coach_id is coach of the course
@@ -3628,14 +3629,13 @@ class Tracking
         }
 
         // Then, courses where $coach_id is coach of the session
-        $sql = 'SELECT session_course_user.user_id
-                FROM '.$tbl_session_course_user.' as session_course_user
-                INNER JOIN '.$tbl_session_course.' as session_course
-                ON session_course.c_id = session_course_user.c_id
-                INNER JOIN '.$tbl_session.' as session
-                ON session.id = session_course.session_id
-                AND session.id_coach = '.$coach_id.'
-                WHERE user_id = '.$student_id;
+        $sql = "SELECT srcru.user_id
+            FROM $tbl_session_course_user srcru
+            INNER JOIN $tbl_session_course src ON (srcru.c_id = src.c_id AND srcru.session_id = src.session_id)
+            INNER JOIN $tbl_session s ON srcru.session_id = s.id AND src.session_id = s.id
+            INNER JOIN $tblSessionRelUser sru on s.id = sru.session_id
+            WHERE (srcru.status = ".SessionEntity::STUDENT." AND srcru.user_id = $student_id)
+                AND (sru.relation_type = ".SessionEntity::SESSION_COACH." AND sru.user_id = $coach_id)";
         $result = Database::query($sql);
         if (Database::num_rows($result) > 0) {
             return true;