diff --git a/src/CoreBundle/Controller/SocialController.php b/src/CoreBundle/Controller/SocialController.php index 240c2cbe01..ee7e6deefa 100644 --- a/src/CoreBundle/Controller/SocialController.php +++ b/src/CoreBundle/Controller/SocialController.php @@ -1,4 +1,5 @@ 'exact', ])] - class GradebookCategory { use CourseTrait; @@ -45,7 +44,6 @@ class GradebookCategory #[ORM\Id] #[ORM\GeneratedValue] #[Groups(['document:read', 'gradebookCategory:read'])] - protected ?int $id = null; #[Assert\NotBlank] @@ -62,7 +60,6 @@ class GradebookCategory #[ORM\ManyToOne(targetEntity: Course::class, inversedBy: 'gradebookCategories')] #[ORM\JoinColumn(name: 'c_id', referencedColumnName: 'id', onDelete: 'CASCADE')] #[Groups(['gradebookCategory:read'])] - protected Course $course; #[ORM\ManyToOne(targetEntity: self::class, inversedBy: 'subCategories')] @@ -119,7 +116,7 @@ class GradebookCategory protected ?int $certifMinScore = null; #[ORM\OneToOne(inversedBy: 'gradebookCategory', targetEntity: CDocument::class)] - #[ORM\JoinColumn(name: 'document_id', referencedColumnName: 'iid', onDelete: "set null")] + #[ORM\JoinColumn(name: 'document_id', referencedColumnName: 'iid', onDelete: 'set null')] #[ApiSubresource] #[Groups(['gradebookCategory:read', 'gradebookCategory:write'])] protected ?CDocument $document = null; @@ -252,6 +249,8 @@ class GradebookCategory /** * Set documentId. * + * @param mixed $document + * * @return GradebookCategory */ public function setDocument($document) diff --git a/src/CoreBundle/Entity/Session.php b/src/CoreBundle/Entity/Session.php index fdd5aa67f6..b3b097bc18 100644 --- a/src/CoreBundle/Entity/Session.php +++ b/src/CoreBundle/Entity/Session.php @@ -46,7 +46,6 @@ use Symfony\Component\Validator\Constraints as Assert; denormalizationContext: ['groups' => ['session:write']], security: "is_granted('ROLE_ADMIN')" )] - #[ORM\Table(name: 'session')] #[ORM\UniqueConstraint(name: 'title', columns: ['title'])] #[ORM\EntityListeners([SessionListener::class])] @@ -55,7 +54,7 @@ use Symfony\Component\Validator\Constraints as Assert; #[ApiFilter(filterClass: SearchFilter::class, properties: ['title' => 'partial'])] #[ApiFilter(filterClass: PropertyFilter::class)] #[ApiFilter(filterClass: OrderFilter::class, properties: ['id', 'title'])] -class Session implements ResourceWithAccessUrlInterface, \Stringable +class Session implements ResourceWithAccessUrlInterface, Stringable { public const VISIBLE = 1; public const READ_ONLY = 2; diff --git a/src/CoreBundle/Form/JuryType.php b/src/CoreBundle/Form/JuryType.php index 9bf3b5e9fc..9837703c06 100644 --- a/src/CoreBundle/Form/JuryType.php +++ b/src/CoreBundle/Form/JuryType.php @@ -47,8 +47,8 @@ class JuryType extends AbstractType 'property' => 'title', 'query_builder' => function (EntityRepository $er) { return $er->createQueryBuilder('u') - //->where('u.role LIKE :role') - //->setParameter(':role', 'ROLE_JURY%') + // ->where('u.role LIKE :role') + // ->setParameter(':role', 'ROLE_JURY%') ->orderBy('u.title', Criteria::DESC) ; }, diff --git a/src/CoreBundle/Migrations/Schema/V200/Version20230508153435.php b/src/CoreBundle/Migrations/Schema/V200/Version20230508153435.php index f0fb4c96da..901ce8189f 100644 --- a/src/CoreBundle/Migrations/Schema/V200/Version20230508153435.php +++ b/src/CoreBundle/Migrations/Schema/V200/Version20230508153435.php @@ -232,7 +232,6 @@ final class Version20230508153435 extends AbstractMigrationChamilo ); } - if ($schema->hasTable('specific_field')) { $this->addSql( 'ALTER TABLE specific_field CHANGE name title VARCHAR(200) NOT NULL' @@ -310,7 +309,6 @@ final class Version20230508153435 extends AbstractMigrationChamilo 'ALTER TABLE skill_level_profile CHANGE name title VARCHAR(255) NOT NULL' ); } - } public function down(Schema $schema): void diff --git a/src/CoreBundle/Migrations/Schema/V200/Version20240114174300.php b/src/CoreBundle/Migrations/Schema/V200/Version20240114174300.php index 639c6dab33..954c8a3d9e 100644 --- a/src/CoreBundle/Migrations/Schema/V200/Version20240114174300.php +++ b/src/CoreBundle/Migrations/Schema/V200/Version20240114174300.php @@ -90,12 +90,10 @@ final class Version20240114174300 extends AbstractMigrationChamilo 'ALTER TABLE lti_external_tool CHANGE name title VARCHAR(255) NOT NULL' ); } - } public function down(Schema $schema): void { - $table = $schema->getTable('lti_external_tool'); if ($table->hasColumn('title')) { $this->addSql('ALTER TABLE lti_external_tool CHANGE title name VARCHAR(255) NOT NULL'); diff --git a/src/CoreBundle/Migrations/Schema/V200/Version20240114212100.php b/src/CoreBundle/Migrations/Schema/V200/Version20240114212100.php index dfe98b1ad0..02aff20059 100644 --- a/src/CoreBundle/Migrations/Schema/V200/Version20240114212100.php +++ b/src/CoreBundle/Migrations/Schema/V200/Version20240114212100.php @@ -16,7 +16,6 @@ final class Version20240114212100 extends AbstractMigrationChamilo public function up(Schema $schema): void { - if ($schema->hasTable('contact_form_contact_category')) { $this->addSql( 'ALTER TABLE contact_form_contact_category CHANGE name title VARCHAR(255) NOT NULL' @@ -43,12 +42,10 @@ final class Version20240114212100 extends AbstractMigrationChamilo 'ALTER TABLE fos_group CHANGE name title VARCHAR(255) NOT NULL' ); } - } public function down(Schema $schema): void { - $table = $schema->getTable('resource_file'); if ($table->hasColumn('title')) { $this->addSql('ALTER TABLE resource_file CHANGE title name VARCHAR(255) NOT NULL'); @@ -71,6 +68,5 @@ final class Version20240114212100 extends AbstractMigrationChamilo if ($table->hasColumn('title')) { $this->addSql('ALTER TABLE contact_form_contact_category CHANGE title name VARCHAR(255) NOT NULL'); } - } } diff --git a/src/CoreBundle/Repository/BranchSyncRepository.php b/src/CoreBundle/Repository/BranchSyncRepository.php index f710adf0a7..420e5c8579 100644 --- a/src/CoreBundle/Repository/BranchSyncRepository.php +++ b/src/CoreBundle/Repository/BranchSyncRepository.php @@ -39,7 +39,7 @@ class BranchSyncRepository extends ServiceEntityRepository // Selecting courses for users // $qb->innerJoin('u.courses', 'c'); - //@todo check app settings + // @todo check app settings $qb->addOrderBy('b.title', 'ASC'); $qb->where('b.title LIKE :keyword'); $qb->setParameter('keyword', "%$keyword%", Types::STRING); diff --git a/src/CourseBundle/Entity/CForumCategory.php b/src/CourseBundle/Entity/CForumCategory.php index 6e1f484b5a..46b0986834 100644 --- a/src/CourseBundle/Entity/CForumCategory.php +++ b/src/CourseBundle/Entity/CForumCategory.php @@ -71,8 +71,6 @@ class CForumCategory extends AbstractResource implements ResourceInterface, Stri /** * Get title. - * - * @return string */ public function getTitle(): string { diff --git a/tests/CoreBundle/Repository/SessionRepositoryTest.php b/tests/CoreBundle/Repository/SessionRepositoryTest.php index 87cf933788..58921bf612 100644 --- a/tests/CoreBundle/Repository/SessionRepositoryTest.php +++ b/tests/CoreBundle/Repository/SessionRepositoryTest.php @@ -500,7 +500,7 @@ class SessionRepositoryTest extends AbstractApiTest $this->assertNotNull($category->getDateEnd()); $this->assertNotNull($category->getUrl()); - $session = ($sessionRepo->create()) + $session = $sessionRepo->create() ->setTitle('session 1') ->addGeneralCoach($coach) ->addAccessUrl($url) @@ -549,7 +549,7 @@ class SessionRepositoryTest extends AbstractApiTest $coach = $this->createUser('coach'); $course = $this->createCourse('new'); - $session = ($sessionRepo->create()) + $session = $sessionRepo->create() ->setTitle('session 1') ->addGeneralCoach($coach) ->addAccessUrl($url)