From 82697e63faec970e6b5d18ef0ed6c7fa80dfb5f7 Mon Sep 17 00:00:00 2001 From: Angel Fernando Quiroz Campos Date: Thu, 11 Apr 2019 12:00:50 -0500 Subject: [PATCH 1/4] Learnpath: Optimizate query to get player - refs BT#15533 --- main/lp/learnpath.class.php | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/main/lp/learnpath.class.php b/main/lp/learnpath.class.php index 331d0033ce..28b1d2a562 100755 --- a/main/lp/learnpath.class.php +++ b/main/lp/learnpath.class.php @@ -2298,11 +2298,16 @@ class learnpath $tbl_lp_item_view = Database::get_course_table(TABLE_LP_ITEM_VIEW); $lpItemId = (int) $lpItemId; + /** @var learnpathItem $item */ + $item = $this->items[$lpItemId]; + $itemViewId = (int) $item->db_item_view_id; + // Getting all the information about the item. - $sql = "SELECT * FROM $tbl_lp_item as lpi + $sql = "SELECT lpi.audio, lpi.item_type, lp_view.status FROM $tbl_lp_item as lpi INNER JOIN $tbl_lp_item_view as lp_view ON (lpi.iid = lp_view.lp_item_id) WHERE + lp_view.iid = $itemViewId AND lpi.iid = $lpItemId AND lp_view.c_id = $course_id"; $result = Database::query($sql); @@ -2336,6 +2341,8 @@ class learnpath $autostart_audio = 'true'; } + error_log($autostart_audio); + $courseInfo = api_get_course_info(); $audio = $row['audio']; From 934f3704e9e7d9becf461aafb429c181dbec1cb5 Mon Sep 17 00:00:00 2001 From: Angel Fernando Quiroz Campos Date: Thu, 11 Apr 2019 12:01:59 -0500 Subject: [PATCH 2/4] Learnpath: Fix autoplay in player with wav/ogg - refs BT#15533 --- main/inc/lib/display.lib.php | 15 ++++++--------- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/main/inc/lib/display.lib.php b/main/inc/lib/display.lib.php index 30073d221f..570535f96e 100755 --- a/main/inc/lib/display.lib.php +++ b/main/inc/lib/display.lib.php @@ -2174,17 +2174,14 @@ class Display { $fileInfo = pathinfo($file); + $autoplay = isset($params['autoplay']) && 'true' === $params['autoplay'] ? 'autoplay' : ''; + $id = isset($params['id']) ? $params['id'] : $fileInfo['basename']; + $width = isset($params['width']) ? 'width="'.$params['width'].'"' : null; + $class = isset($params['class']) ? ' class="'.$params['class'].'"' : null; + switch ($fileInfo['extension']) { case 'mp3': case 'webm': - $autoplay = null; - if (isset($params['autoplay']) && $params['autoplay'] == 'true') { - $autoplay = 'autoplay'; - } - $width = isset($params['width']) ? 'width="'.$params['width'].'"' : null; - $id = isset($params['id']) ? $params['id'] : $fileInfo['basename']; - $class = isset($params['class']) ? ' class="'.$params['class'].'"' : null; - $html = '