From 6d8f30289b3d2c26a63f308fcf1a6a07177c4026 Mon Sep 17 00:00:00 2001
From: Angel Fernando Quiroz Campos <1697880+AngelFQC@users.noreply.github.com>
Date: Fri, 31 Jan 2025 16:19:40 -0500
Subject: [PATCH] Display: Fix js errors in forms

---
 public/main/admin/user_edit.php                              | 1 +
 public/main/inc/lib/formvalidator/Element/DateTimePicker.php | 4 ++--
 public/main/inc/lib/formvalidator/FormValidator.class.php    | 2 +-
 public/main/search/search.php                                | 4 ++--
 4 files changed, 6 insertions(+), 5 deletions(-)

diff --git a/public/main/admin/user_edit.php b/public/main/admin/user_edit.php
index 2177c407aa..497f3865e3 100644
--- a/public/main/admin/user_edit.php
+++ b/public/main/admin/user_edit.php
@@ -230,6 +230,7 @@ $group[] = $form->createElement(
     'password',
     null,
     [
+        'id' => 'password',
         'onkeydown' => 'javascript: password_switch_radio_button();',
         'show_hide' => true,
     ]
diff --git a/public/main/inc/lib/formvalidator/Element/DateTimePicker.php b/public/main/inc/lib/formvalidator/Element/DateTimePicker.php
index 42df171221..21e6c713d6 100644
--- a/public/main/inc/lib/formvalidator/Element/DateTimePicker.php
+++ b/public/main/inc/lib/formvalidator/Element/DateTimePicker.php
@@ -19,7 +19,7 @@ class DateTimePicker extends HTML_QuickForm_text
         if (!isset($attributes['id'])) {
             $attributes['id'] = $elementName;
         }
-        $attributes['class'] = 'p-component p-inputtext';
+        $attributes['class'] = 'p-component p-inputtext p-filled';
         parent::__construct($elementName, $elementLabel, $attributes);
         $this->_appendName = true;
     }
@@ -98,7 +98,7 @@ class DateTimePicker extends HTML_QuickForm_text
                     }
                 });
 
-                document.querySelector('label[for=\"' + '{$id}' + '\"]').classList.add('datepicker-label');
+                document.querySelector('label[for=\"' + '{$id}' + '\"]')?.classList.add('datepicker-label');
             }
 
             function loadLocaleAndInitialize() {
diff --git a/public/main/inc/lib/formvalidator/FormValidator.class.php b/public/main/inc/lib/formvalidator/FormValidator.class.php
index 85fe7c9bb6..053e0a8fcc 100644
--- a/public/main/inc/lib/formvalidator/FormValidator.class.php
+++ b/public/main/inc/lib/formvalidator/FormValidator.class.php
@@ -1748,7 +1748,7 @@ EOT;
             $(function() {
                 var defaultValue = '$defaultId';
                 $('#$typeNoDots').val(defaultValue);
-                $('#$typeNoDots').selectpicker('render');
+                //$('#$typeNoDots').selectpicker('render');
                 if (defaultValue != '') {
                     var selected = $('#$typeNoDots option:selected').val();
                     $.ajax({
diff --git a/public/main/search/search.php b/public/main/search/search.php
index 90aeaf6f6f..ab92285973 100644
--- a/public/main/search/search.php
+++ b/public/main/search/search.php
@@ -12,7 +12,7 @@ require_once __DIR__.'/../inc/global.inc.php';
 
 api_block_anonymous_users();
 
-if ('false' === api_get_setting('session.allow_search_diagnostic')) {
+if ('false' !== api_get_setting('session.allow_search_diagnostic')) {
     api_not_allowed();
 }
 
@@ -89,7 +89,7 @@ $htmlHeadXtra[] = '
       const diapoButton = document.querySelector("#card_"+targetBlockWithoutHash+" a");
 
       setTimeout(function() {
-        diapoButton.click();
+        diapoButton?.click();
       }, 500);
     });
 </script>