Minor: ECS

src/CoreBundle/Controller/CourseController.php

@@ -10,7 +10,6 @@ use Chamilo\CoreBundle\Entity\Course;
 use Chamilo\CoreBundle\Entity\ExtraField;
 use Chamilo\CoreBundle\Entity\Tag;
 use Chamilo\CoreBundle\Framework\Container;
-use Chamilo\CoreBundle\Repository\ExtraFieldRelTagRepository;
 use Chamilo\CoreBundle\Repository\LanguageRepository;
 use Chamilo\CoreBundle\Repository\LegalRepository;
 use Chamilo\CoreBundle\Repository\Node\IllustrationRepository;
@@ -93,7 +92,7 @@ class CourseController extends ToolBaseController
                 $condArray = explode(':', $request->get('legal_accept_type'));
                 if (!empty($condArray[0]) && !empty($condArray[1])) {
                     $time = time();
-                    $conditionToSave = intval($condArray[0]).':'.intval($condArray[1]).':'.$time;
+                    $conditionToSave = (int) ($condArray[0]).':'.(int) ($condArray[1]).':'.$time;
                     UserManager::update_extra_field_value(
                         $userId,
                         'legal_accept',
@@ -106,7 +105,7 @@ class CourseController extends ToolBaseController
             $allow = api_get_configuration_value('allow_public_course_with_no_terms_conditions');
             if (true === $allow &&
                 null !== $course->getVisibility() &&
-                COURSE_VISIBILITY_OPEN_WORLD == $course->getVisibility()
+                COURSE_VISIBILITY_OPEN_WORLD === $course->getVisibility()
             ) {
                 $redirect = false;
             }

src/CoreBundle/DataProvider/Extension/CourseExtension.php

@@ -10,7 +10,6 @@ use ApiPlatform\Core\Bridge\Doctrine\Orm\Extension\QueryCollectionExtensionInter
 //use ApiPlatform\Core\Bridge\Doctrine\Orm\Extension\QueryItemExtensionInterface;
 use ApiPlatform\Core\Bridge\Doctrine\Orm\Util\QueryNameGeneratorInterface;
 use Chamilo\CoreBundle\Entity\Course;
-use Chamilo\CoreBundle\Entity\ResourceLink;
 use Doctrine\ORM\QueryBuilder;
 use Symfony\Component\HttpFoundation\RequestStack;
 use Symfony\Component\Security\Core\Exception\AccessDeniedException;

src/CoreBundle/EventListener/CourseListener.php

@@ -13,6 +13,7 @@ use Chamilo\CoreBundle\Entity\User;
 use Chamilo\CoreBundle\Security\Authorization\Voter\CourseVoter;
 use Chamilo\CoreBundle\Security\Authorization\Voter\GroupVoter;
 use Chamilo\CoreBundle\Security\Authorization\Voter\SessionVoter;
+use Chamilo\CoreBundle\Settings\SettingsManager;
 use Chamilo\CourseBundle\Controller\CourseControllerInterface;
 use Chamilo\CourseBundle\Entity\CGroup;
 use Doctrine\ORM\EntityManager;
@@ -26,9 +27,6 @@ use Symfony\Component\Security\Core\Authorization\AuthorizationCheckerInterface;
 use Symfony\Component\Security\Core\Exception\AccessDeniedException;
 use Symfony\Component\Security\Core\User\UserInterface;
 use Twig\Environment;
-use Chamilo\CoreBundle\Repository\LegalRepository;
-use Chamilo\CoreBundle\Settings\SettingsManager;
-use Symfony\Component\HttpFoundation\RedirectResponse;
 
 /**
  * Class CourseListener.
@@ -49,7 +47,7 @@ class CourseListener
     ) {
         $this->twig = $twig;
         $this->authorizationChecker = $authorizationChecker;
-        $this->settingsManager= $settingsManager;
+        $this->settingsManager = $settingsManager;
     }
 
     /**

src/CoreBundle/Form/ExtraFieldType.php

@@ -199,16 +199,17 @@ class ExtraFieldType extends AbstractType
 
                     break;
                 case \ExtraField::FIELD_TYPE_CHECKBOX:
-                    $defaultOptions['data'] = (int) $value === 1;
+                    $defaultOptions['data'] = 1 === (int) $value;
 
                     $builder->add($variable, CheckboxType::class, $defaultOptions);
+
                     break;
                 case \ExtraField::FIELD_TYPE_RADIO:
                 case \ExtraField::FIELD_TYPE_SELECT:
                 case \ExtraField::FIELD_TYPE_SELECT_MULTIPLE:
                     if (empty($value)) {
                         $defaultOptions['data'] = null;
-                        if ($extraField->getFieldType() === \ExtraField::FIELD_TYPE_CHECKBOX) {
+                        if (\ExtraField::FIELD_TYPE_CHECKBOX === $extraField->getFieldType()) {
                             $defaultOptions['data'] = [];
                         }
                     }

src/CoreBundle/Repository/LegalRepository.php

@@ -13,6 +13,7 @@ use Doctrine\Bundle\DoctrineBundle\Repository\ServiceEntityRepository;
 use Doctrine\Common\Collections\Criteria;
 use Doctrine\Persistence\ManagerRegistry;
 use Exception;
+use ExtraFieldValue;
 
 class LegalRepository extends ServiceEntityRepository
 {
@@ -89,11 +90,11 @@ class LegalRepository extends ServiceEntityRepository
     {
         if ('true' === api_get_setting('allow_terms_conditions')) {
             // Check if exists terms and conditions
-            if (0 == $this->countTerms()) {
+            if (0 === $this->countTerms()) {
                 return true;
             }
 
-            $extraFieldValue = new \ExtraFieldValue('user');
+            $extraFieldValue = new ExtraFieldValue('user');
             $data = $extraFieldValue->get_values_by_handler_and_field_variable(
                 $user->getId(),
                 'legal_accept'
@@ -149,6 +150,7 @@ class LegalRepository extends ServiceEntityRepository
             ;
         if (!empty($result)) {
             $version = explode(':', $result);
+
             return (int) $version[0];
         }