chamilo
/
chamilo-lms
mirror of https://github.com/chamilo/chamilo-lms/tree/1.11.x
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

Work: Security: Sanitize file name that could import document with special characters - refs BT#22273

Browse Source
pull/5961/head
Angel Fernando Quiroz Campos 9 months ago
parent 3075eeba7a
commit 7212fb2a1e
No known key found for this signature in database
GPG Key ID: B284841AE3E562CD
4 changed files with 23 additions and 32 deletions
Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL
Show Stats Download Patch File Download Diff File
  1. 13
      main/inc/ajax/document.ajax.php
  2. 15
      main/inc/ajax/dropbox.ajax.php
  3. 10
      main/inc/ajax/work.ajax.php
  4. 17
      main/inc/lib/fileUpload.lib.php

13
main/inc/ajax/document.ajax.php
Unescape View File

@ -153,17 +153,8 @@ switch ($action) {
}
$resultList = [];
foreach ($fileList as $file) {
if (isset($_REQUEST['chunkAction']) && 'done' === $_REQUEST['chunkAction']) {
// to rename and move the finished file
$tmpFile = disable_dangerous_file(
api_replace_dangerous_char($file['name'])
);
$chunkedFile = api_get_path(SYS_ARCHIVE_PATH).$tmpFile;
$file['tmp_name'] = $chunkedFile;
$file['size'] = filesize($chunkedFile);
$file['copy_file'] = true;
}
foreach ($fileList as $fileInfo) {
$file = processChunkedFile($fileInfo);
$globalFile = [];
$globalFile['files'] = $file;

15
main/inc/ajax/dropbox.ajax.php
Unescape View File

@ -79,19 +79,8 @@ switch ($action) {
}
$resultList = [];
foreach ($fileList as $file) {
if (isset($_REQUEST['chunkAction']) && 'done' === $_REQUEST['chunkAction']) {
// to rename and move the finished file
$tmpFile = disable_dangerous_file(
api_replace_dangerous_char($file['name'])
);
// to rename and move the finished file
$chunkedFile = api_get_path(SYS_ARCHIVE_PATH).$tmpFile;
$file['tmp_name'] = $chunkedFile;
$file['size'] = filesize($chunkedFile);
$file['copy_file'] = true;
}
foreach ($fileList as $fileInfo) {
$file = processChunkedFile($fileInfo);
$globalFile = [];
$globalFile['files'] = $file;

10
main/inc/ajax/work.ajax.php
Unescape View File

@ -120,14 +120,8 @@ switch ($action) {
}
$resultList = [];
foreach ($fileList as $file) {
if (isset($_REQUEST['chunkAction']) && 'done' === $_REQUEST['chunkAction']) {
// to rename and move the finished file
$chunkedFile = api_get_path(SYS_ARCHIVE_PATH).$file['name'];
$file['tmp_name'] = $chunkedFile;
$file['size'] = filesize($chunkedFile);
$file['copy_file'] = true;
}
foreach ($fileList as $fileInfo) {
$file = processChunkedFile($fileInfo);
$globalFile = [];
$globalFile['files'] = $file;

17
main/inc/lib/fileUpload.lib.php
Unescape View File

@ -2255,3 +2255,20 @@ function getFileUploadSizeLimitForTeacher()
return $size;
}
function processChunkedFile(array $file): array
{
if (isset($_REQUEST['chunkAction']) && 'done' === $_REQUEST['chunkAction']) {
// to rename and move the finished file
$tmpFile = disable_dangerous_file(
api_replace_dangerous_char($file['name'])
);
$chunkedFile = api_get_path(SYS_ARCHIVE_PATH) . $tmpFile;
$file['tmp_name'] = $chunkedFile;
$file['size'] = filesize($chunkedFile);
$file['copy_file'] = true;
}
return $file;
}

Write Preview
Loading…
Cancel
Save