From 75e4e20119ace8aed07298a6c2c94e3d21103fef Mon Sep 17 00:00:00 2001
From: Julio Montoya <gugli100@gmail.com>
Date: Thu, 30 Jan 2020 08:59:27 +0100
Subject: [PATCH] Fix cloud link PHP warnings BT#16249

---
 main/document/add_link.php | 7 ++++---
 main/document/document.php | 6 +++---
 2 files changed, 7 insertions(+), 6 deletions(-)

diff --git a/main/document/add_link.php b/main/document/add_link.php
index d3e9358fa9..98624842ba 100644
--- a/main/document/add_link.php
+++ b/main/document/add_link.php
@@ -1,4 +1,5 @@
 <?php
+
 /* For licensing terms, see /license.txt */
 
 /**
@@ -78,7 +79,7 @@ $interbreadcrumb[] = [
 // Interbreadcrumb for the current directory root path
 if (empty($document_data['parents'])) {
     // Hack in order to not add the document to the breadcrumb in case it is a link
-    if ($document_data['filetype'] != 'link') {
+    if ($document_data && $document_data['filetype'] != 'link') {
         $interbreadcrumb[] = ['url' => '#', 'name' => $document_data['title']];
     }
 } else {
@@ -144,7 +145,7 @@ if ($form->validate()) {
                 Display::addFlash(Display::return_message(get_lang('ErrorAddCloudLink'), 'warning', false));
             }
         }
-        header('Location: document.php?'.api_get_cidreq());
+        header('Location: document.php?'.api_get_cidreq().'&id='.$documentId);
         exit;
     }
 }
@@ -177,7 +178,7 @@ echo DocumentManager::build_directory_selector(
 echo '<script>
 $(function() {
     $("[data-toggle=\'tooltip\']").tooltip({
-        content: 
+        content:
             function() {
                 return $(this).attr("title");
             }
diff --git a/main/document/document.php b/main/document/document.php
index 45ce9bf4e1..95585ede99 100755
--- a/main/document/document.php
+++ b/main/document/document.php
@@ -209,7 +209,7 @@ if (!empty($groupId)) {
 }
 
 // Actions.
-$document_id = isset($_REQUEST['id']) ? (int) $_REQUEST['id'] : null;
+$documentIdFromGet = $document_id = isset($_REQUEST['id']) ? (int) $_REQUEST['id'] : null;
 $currentUrl = api_get_self().'?'.api_get_cidreq().'&id='.$document_id;
 $curdirpath = isset($_GET['curdirpath']) ? Security::remove_XSS($_GET['curdirpath']) : null;
 
@@ -604,8 +604,8 @@ if (isset($document_id) && empty($action)) {
             0
         );
     }
-    // If the document is not a folder we show the document.
 
+    // If the document is not a folder we show the document.
     if ($document_data) {
         $parent_id = $document_data['parent_id'];
         // Hack in order to clean the document id in case of false positive from links
@@ -1771,7 +1771,7 @@ if ($isAllowedToEdit ||
     if ($fileLinkEnabled && !$is_certificate_mode) {
         $actionsLeft .= Display::url(
             Display::return_icon('clouddoc_new.png', get_lang('AddCloudLink'), '', ICON_SIZE_MEDIUM),
-            api_get_path(WEB_CODE_PATH).'document/add_link.php?'.api_get_cidreq().'&id='.$document_id
+            api_get_path(WEB_CODE_PATH).'document/add_link.php?'.api_get_cidreq().'&id='.$documentIdFromGet
         );
     }
 }