From 76efa7dc77972bcf34d984d1f213b5d706ba58c9 Mon Sep 17 00:00:00 2001
From: Julio Montoya <gugli100@gmail.com>
Date: Tue, 26 Nov 2019 11:54:13 +0100
Subject: [PATCH] Add php exif extension requirement.

---
 documentation/installation_guide.html | 34 +++++++++++++--------------
 main/inc/lib/diagnoser.lib.php        | 10 ++++++++
 main/install/install.lib.php          |  7 ++++--
 3 files changed, 31 insertions(+), 20 deletions(-)

diff --git a/documentation/installation_guide.html b/documentation/installation_guide.html
index 8a9c6194ca..a3ce780024 100755
--- a/documentation/installation_guide.html
+++ b/documentation/installation_guide.html
@@ -277,30 +277,28 @@ date.timezone = 'America/New_York'
 <p><strong>Note:</strong> <span class="text-muted">PHP 5.3.9 introduces a new setting "max_input_vars", which limits the number of elements you can send in one single form. If you are dealing with numerous users or very long learning paths (many items), make sure you set this setting higher than its default value of 1000.</span></p>
 
 <p><strong>BSD and CentOS users:</strong> these php libraries have to be included during the PHP installation (php5 might have to be replaced by php in some instances):</p>
-
 <ul>
-    <li>php5-session: The session shared extension for php</li>
-    <li>php5-mysqlnd (or php5-mysqli): The mysql shared extension for php</li>
-    <li>php5-zlib: The zlib shared extension for php</li>
-    <li>php5-pcre: The pcre shared extension for php</li>
-    <li>php5-xml</li>
-    <li>php5-json</li>
-    <li>php5-mcrypt</li>
-    <li>php5-iconv or php5-mbstring (either one of them)</li>
-    <li>php5-gd The graphics-generation extension for PHP</li>
-    <li>php5-intl The international behaviours extension for PHP</li>
+    <li>php-session: The session shared extension for php</li>
+    <li>php-mysqlnd (or php5-mysqli): The mysql shared extension for php</li>
+    <li>php-zlib: The zlib shared extension for php</li>
+    <li>php-pcre: The pcre shared extension for php</li>
+    <li>php-xml</li>
+    <li>php-json</li>
+    <li>php-mcrypt</li>
+    <li>php-iconv or php-mbstring (either one of them)</li>
+    <li>php-gd The graphics-generation extension for PHP</li>
+    <li>php-intl The international behaviours extension for PHP</li>
+    <li>php-exif</li>
 </ul>
 
 <p>You might also add the following php modules and packages:</p>
 <ul>
-    <li>php5-ctype</li>
-    <li>php5-ldap</li>
-    <li>php5-xapian</li>
-    <li>php5-curl</li>
-    <li>php5-xsl</li>
+    <li>php-ctype</li>
+    <li>php-ldap</li>
+    <li>php-xapian</li>
+    <li>php-curl</li>
+    <li>php-xsl</li>
 </ul>
-
-
 <hr />
 <h2><a name="3._Upgrade"></a>3. Upgrade</h2>
 
diff --git a/main/inc/lib/diagnoser.lib.php b/main/inc/lib/diagnoser.lib.php
index ec96cb1bf5..3e2a59d2a5 100755
--- a/main/inc/lib/diagnoser.lib.php
+++ b/main/inc/lib/diagnoser.lib.php
@@ -597,6 +597,16 @@ class Diagnoser
                 'expected' => 2,
                 'comment' => get_lang('This extension should be loaded.'),
             ],
+            'exif' => [
+                'link' => 'http://www.php.net/exif',
+                'expected' => 1,
+                'comment' => get_lang('This extension should be loaded.'),
+            ],
+            'mbstring' => [
+                'link' => 'http://www.php.net/mbstring',
+                'expected' => 1,
+                'comment' => get_lang('This extension should be loaded.'),
+            ],
         ];
 
         foreach ($extensions as $extension => $data) {
diff --git a/main/install/install.lib.php b/main/install/install.lib.php
index d53faf47a5..9f1921dbdf 100755
--- a/main/install/install.lib.php
+++ b/main/install/install.lib.php
@@ -835,11 +835,14 @@ function display_requirements(
                 <td class="requirements-item"><a href="http://php.net/manual/en/book.curl.php" target="_blank">cURL</a>'.get_lang('Support').'</td>
                 <td class="requirements-value">'.checkExtension('curl', get_lang('Yes'), get_lang('No')).'</td>
             </tr>
-
             <tr>
-                <td class="requirements-item"><a href="http://php.net/manual/en/book.mbstring.php" target="_blank">Multibyte string</a> '.get_lang('Support').' ('.get_lang('Optional').')</td>
+                <td class="requirements-item"><a href="http://php.net/manual/en/book.mbstring.php" target="_blank">Multibyte string</a> '.get_lang('Support').'</td>
                 <td class="requirements-value">'.checkExtension('mbstring', get_lang('Yes'), get_lang('MBString extension not available'), true).'</td>
             </tr>
+           <tr>
+                <td class="requirements-item"><a href="http://php.net/manual/en/book.exif.php" target="_blank">Exif</a> '.get_lang('Support').'</td>
+                <td class="requirements-value">'.checkExtension('exif', get_lang('Yes'), get_lang('Exif extension not available'), true).'</td>
+            </tr>
             <tr>
                 <td class="requirements-item"><a href="http://php.net/opcache" target="_blank">Zend OpCache</a> '.get_lang('Support').' ('.get_lang('Optional').')</td>
                 <td class="requirements-value">'.checkExtension('Zend OPcache', get_lang('Yes'), get_lang('No'), true, 'opcache.enable').'</td>