diff --git a/main/gradebook/lib/fe/displaygradebook.php b/main/gradebook/lib/fe/displaygradebook.php index 61bf30b54f..c32aa717f7 100755 --- a/main/gradebook/lib/fe/displaygradebook.php +++ b/main/gradebook/lib/fe/displaygradebook.php @@ -485,7 +485,7 @@ class DisplayGradebook Display::return_icon('percentage.png', get_lang('EditAllWeights'), '', ICON_SIZE_MEDIUM).''; } $score_display_custom = api_get_setting('gradebook_score_display_custom'); - if (api_get_setting('teachers_can_change_score_settings') == 'true' && $score_display_custom['my_display_custom'] == 'true') { + if (api_get_setting('teachers_can_change_score_settings') == 'true' && $score_display_custom == 'true') { $actionsRight .= ''. Display::return_icon('ranking.png', get_lang('ScoreEdit'), '', ICON_SIZE_MEDIUM).''; } diff --git a/main/gradebook/lib/scoredisplay.class.php b/main/gradebook/lib/scoredisplay.class.php index e86c68ebb9..ab25fc9e19 100755 --- a/main/gradebook/lib/scoredisplay.class.php +++ b/main/gradebook/lib/scoredisplay.class.php @@ -30,7 +30,6 @@ class ScoreDisplay // Loading portal settings + using standard functions. $value = api_get_setting('gradebook_score_display_coloring'); - $value = $value['my_display_coloring']; // Setting coloring. $this->coloring_enabled = $value == 'true' ? true : false; @@ -44,7 +43,6 @@ class ScoreDisplay // Setting custom enabled $value = api_get_setting('gradebook_score_display_custom'); - $value = $value['my_display_custom']; $this->custom_enabled = $value == 'true' ? true : false; if ($this->custom_enabled) { diff --git a/src/CoreBundle/Settings/GradebookSettingsSchema.php b/src/CoreBundle/Settings/GradebookSettingsSchema.php index 3adbf99a73..6dda422b90 100644 --- a/src/CoreBundle/Settings/GradebookSettingsSchema.php +++ b/src/CoreBundle/Settings/GradebookSettingsSchema.php @@ -74,7 +74,7 @@ class GradebookSettingsSchema extends AbstractSettingsSchema ->add('gradebook_locking_enabled', YesNoType::class) ->add('gradebook_default_grade_model_id') ->add('gradebook_show_percentage_in_reports') - ->add('my_display_coloring') + ->add('my_display_coloring', YesNoType::class) ->add( 'student_publication_to_take_in_gradebook', ChoiceType::class,